Skip to content

[Due for payment 2026-10-01] Spend - Feed filter popup modal is cramped and cuts off content #102009

Closed

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: v9.4.92-0
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/projects/2219752/test-runs/75291760/folder/13176890/41237383/1789798410?sort=%2Bidentifier
Email or phone of affected tester (no customers): leungbratt6+2009@gmail.com
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: Windows 10/Chrome
App Component: Left Hand Navigation (LHN)

Action Performed:

Preconditions; User has issued some Expensify Card before

  1. Open the New Dot app
  2. Navigate to Workspace - Expensify Card - View transactions
  3. Click on the Feed filter

Expected Result:

Feed filter display fully like Prod

Actual Result:

Feed filter popup modal is reduced in height and requires scrolling

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

Bug7266946_1790148420690.expnesifycard.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Julia Ponikarchuk
Bug ID: 7266946

Issue OwnerCurrent Issue Owner: @Krishna2323

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Sep 23, 2026
  2. applause-bot commented on Sep 23, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/0db191a393e53cfa889a36f317d7d438047eeb843aa50324d1f237fdefbde48c

  3. github-actions commented on Sep 23, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    Triggered auto assignment to @yuwenmemon (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  5. melvin-bot commented on Sep 23, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. MelvinBot commented on Sep 23, 2026

    @MelvinBot
    Contributor

    🔍 Investigation Summary

    Classification: Frontend bug
    Causing PR: [Payment due @Krishna2323] Add paginated tag filters with server-side search (Expensify/App#99831) - by @ShridharGoel (High confidence)
    Related Issues: Expense - Status modal is scrollable (Expensify/App#102004) — same root cause, and Deploy Checklist: New Expensify 2026-09-23 (Expensify/App#101971)

    Recommendation: ROLL FORWARD

    PR #99831 is a large change (29 files, a new API command, new Onyx keys and pagination state), so reverting it is far riskier than the ~2-line guard needed here: only build footerContent when there is actually something to render. The same fix also resolves deploy blocker #102004.

    Assigned: @ShridharGoel (PR author), @JS00001 and @Krishna2323 (approving reviewers) from highest-confidence causing PR only
    Labels: No change. DeployBlockerCash is kept because an App PR caused this. DeployBlocker was not present, so nothing was removed.

    📋 Detailed Analysis

    Evidence

    • Staging only, not production, and the reported version v9.4.92-0 matches the current deploy checklist, so the cause is one of the PRs on staging.
    • Diffing production...staging over the whole search-filter render path shows that the popover sizing helper itself is unchanged: getSelectionListPopoverHeight in src/styles/index.ts#L7099-L7128, ListFilterViewWrapper.tsx, and the feed-specific FilterComponents/FeedSelector.tsx (which pins itemHeight={variables.optionRowHeight}) are all byte-identical to production. So the popover is still being given the same height as production — what changed is what consumes that height from the inside.
    • The only vertical-space change on that path is in FilterComponents/MultiSelect.tsx, introduced by PR [Payment due @Krishna2323] Add paginated tag filters with server-side search #99831 (commit 5243195, "Keep the confirm footer visible while loading more tag filter pages"). It converted footerContent from a conditional value into an unconditional JSX fragment.
    • Corroboration: deploy blocker [Due for payment 2026-10-01] Expense - Status modal is scrollable #102004 ("Status modal is scrollable", also staging-only on 9.4.92-0) goes through TableFilterPopoverComponent → MultiSelectPopup → the same MultiSelect. Two independently reported "popup is unexpectedly scrollable" blockers converging on one component is strong confirmation.

    Verification

    Affected files (all on the Feed filter render path):

    1. src/components/Search/FilterComponents/MultiSelect.tsx#L173-L185 — footerContent is now always a truthy fragment, passed at L206.
    2. src/components/SelectionList/BaseSelectionList.tsx#L570 — renders the footer as a sibling of the list inside the fixed-height container.
    3. src/components/SelectionList/components/Footer.tsx#L27 — if (footerContent) truthiness check.
    4. src/components/FixedFooter.tsx#L39-L43 — if (!children) return null; then renders a padded View.

    gh pr view 99831 --json files confirms the PR modifies both src/components/Search/FilterComponents/MultiSelect.tsx and src/components/SelectionList/BaseSelectionList.tsx. Merge commit e635f26 is present on staging/main and absent from production, merged 2026-09-22 13:49 UTC — about 18 hours before this report.

    Navigation path check: "View transactions" on the Expensify Card page builds a search query with a feed filter and navigates to the Spend page (WorkspaceCardsListLabel.tsx#L187-L196), so the "Feed filter" chip is ListPopup → ListFilterContent (FEED) → FilterComponents/FeedSelector → MultiSelect. Confirmed the causing PR sits directly on that path.

    Root Cause

    The feed filter popover uses a fixed pixel height computed from the row count:

    ESTIMATED_LIST_HEIGHT = itemCount * itemHeight + SEARCHBAR_HEIGHT + extraHeight
    

    For the feed filter that is exactly itemCount * 64, with contentContainerStyle: styles.pb0, so the list content is sized to fit the container with nothing to spare.

    Before PR #99831, MultiSelect passed footerContent={footer} straight through. In the popover path footer is undefined (ListPopup/MultiSelectPopup render their Apply/Reset buttons in BasePopup, outside the list), so Footer returned null and the list got the full fixed height.

    PR #99831 changed it to:

    const footerContent = (
        <>
            {!!isLoadingMore && (<View …><ActivityIndicator … /></View>)}
            {footer}
        </>
    );

    A JSX fragment element is always truthy, even when it renders nothing. So Footer's if (footerContent) now always takes the first branch, and FixedFooter's if (!children) guard never trips. The result is an always-present, visually empty footer View with styles.ph5, flexShrink0, mtAuto and ~20px of paddingBottom rendered as a sibling of the FlashList inside the fixed-height popover.

    That footer eats ~20px out of a container whose height was computed assuming the list gets all of it, so the last feed row is clipped and the popover becomes scrollable — exactly the "cramped / cuts off content / requires scrolling" symptom. It regresses every MultiSelect-based filter popup (Feed, Status, Has, Type, Card, In, Workspace, …), which is why #102004 reports the same thing on the Status popup.

    Suggested targeted fix — keep the fragment only when there is real content:

    const footerContent =
        isLoadingMore || footer ? (
            <>
                {!!isLoadingMore && (<View …><ActivityIndicator … /></View>)}
                {footer}
            </>
        ) : undefined;

    💡 Suggested AI code review rule

    This bug looks like a recurring, mechanically detectable pattern, so it may be worth a coding-standards rule so the AI reviewer catches the next one. Proposed for Expensify/App:

    • Rule: UI-4 Do not pass an unconditional JSX fragment to an optional render prop
    • Condition: When a value handed to an optional *Content / footerContent / header / listEmptyContent-style render prop is built as a bare <>…</> wrapper around conditionally-rendered children, gate the whole wrapper (cond ? <>…</> : undefined) instead — a fragment is always truthy, so consumers that do if (prop) will render an empty container.
    • Why: The consumer's truthiness check (Footer's if (footerContent) → FixedFooter) stops working, rendering an invisible padded container that steals space inside fixed-height layouts; here it shrank every Search filter popover's list and shipped two deploy blockers (this issue and [Due for payment 2026-10-01] Expense - Status modal is scrollable #102004).
    • Search pattern: const \w*(Content|Footer|Header|Element)\s*=\s*\(\s*<> — i.e. a variable assigned an unconditional fragment that is later passed to an optional render prop; AST equivalent: VariableDeclarator > JSXFragment where the identifier flows into a JSXAttribute on an optional prop.
    • Offending code (❌): MultiSelect.tsx#L173-L185 (consumed at Footer.tsx#L27 and FixedFooter.tsx#L39)
    • Fix (✅): the pre-regression shape, MultiSelect.tsx#L150 on production, or the gated ternary sketched above

    The full rule file, with the ❌/✅ code inline in Expensify/App's .claude/skills/app-coding-standards/ format, would go in Expensify/App itself. If it's worth adding, a maintainer can open it there as a draft PR.

  7. m-natarajan commented on Sep 23, 2026

    @m-natarajan

    Chrome / v9.4.92-2, Not repro

    bandicam.2026-09-23.15-36-28-705.mp4
  8. self-assigned this
    on Sep 23, 2026
  9. changed the title [-]Spend - Feed filter popup modal is cramped and cuts off content[/-] [+][Due for payment 2026-10-01] Spend - Feed filter popup modal is cramped and cuts off content[/+] on Sep 24, 2026
  10. melvin-bot commented on Sep 24, 2026

    @melvin-bot

    @Krishna2323

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.4.92-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-01. 🎊

    The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2Engineering

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions