Skip to content

[CP Staging] fix: avoid empty footerContent in MultiSelect - #102018

Merged
lakchote merged 5 commits into
Expensify:mainfrom
ShridharGoel:shridhar/fix-multiselect-empty-footer
Sep 23, 2026
Merged

lakchote merged 5 commits into
Expensify:mainfrom
ShridharGoel:shridhar/fix-multiselect-empty-footer

Conversation

@ShridharGoel

Copy link
Copy Markdown
Contributor

Explanation of Change

Only construct footerContent in MultiSelect when isLoadingMore or footer is present.

Previously, footerContent was unconditionally initialized as a React fragment (<>...</>). Even when empty, a React fragment is truthy in JavaScript, which caused SelectionList to mount FixedFooter with 20px bottom padding. Because styles.getSelectionListPopoverHeight sizes the modal container to fit the list items exactly without expecting a footer, the extra 20px overflowed the container, causing FlashList to become scrollable and partially cut off the bottom item.

Fixed Issues

$ #102004
$ #102009
PROPOSAL:

Tests

  1. Open a workspace chat and create a report.
  2. Click Add expense > Add existing expense.
  3. Click the filter button to open the Status filter modal.
  4. Verify both Unreported and Draft options are fully visible without scrolling or an unexpected scrollbar.
  5. Navigate to Workspace settings > Expensify Card > View transactions.
  6. Click the Feed filter.
  7. Verify the options are fully visible without unnecessary vertical scrollbar.
  • Verify that no errors appear in the JS console

Offline tests

  • Same as tests

QA Steps

  • Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Empty React fragment passed as footerContent is truthy, causing SelectionList to mount FixedFooter with 20px padding and overflow the popover container.
@ShridharGoel
ShridharGoel marked this pull request as ready for review September 23, 2026 09:36
@ShridharGoel
ShridharGoel requested review from a team as code owners September 23, 2026 09:36
@melvin-bot
melvin-bot Bot requested review from a team, Krishna2323, situchan and trjExpensify and removed request for a team September 23, 2026 09:36
@melvin-bot

melvin-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown

@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team September 23, 2026 09:36
@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewing...

@lakchote lakchote changed the title fix: avoid empty footerContent in MultiSelect [CP Staging] fix: avoid empty footerContent in MultiSelect Sep 23, 2026

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small test notes:

  1. The footer={<></>} case only asserts that footerContent is defined, but an empty fragment is exactly the truthy-but-renders-nothing case this PR is fixing. Could we use a real node there instead?
  2. Worth adding the isLoadingMore={true} case so both sides of the condition are covered.

Could you also add the screenshots?

@Krishna2323

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Monosnap.screencast.2026-09-23.15-14-58.mp4

@Krishna2323 Krishna2323 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested review from JS00001 and yuwenmemon September 23, 2026 10:25

@lakchote lakchote left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lakchote
lakchote merged commit beb7231 into Expensify:main Sep 23, 2026
35 of 37 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Sep 23, 2026
…-empty-footer

[CP Staging] fix: avoid empty footerContent in MultiSelect

(cherry picked from commit beb7231)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Sep 23, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.92-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes are required for this PR, so I did not create a draft docs PR.

This is a purely visual rendering fix inside a shared component: src/components/Search/FilterComponents/MultiSelect.tsx:173 now passes undefined for footerContent instead of an always-truthy empty fragment, which stops SelectionList from mounting an empty FixedFooter and adding 20px of padding.

Nothing user-facing changed that the help site documents:

  • No new or renamed feature, tab, setting, or button.
  • No change to any filter option — Unreported, Draft, and the Feed filter options are the same; they're just no longer clipped.
  • No change to any workflow or step a user follows.

The articles that cover these flows — Managing Expenses in a Report and Use Search Operators to Filter and Analyze — describe what the filters do, not how the modal is sized, so they stay accurate as written.

Note: I reviewed this from the code and diff only. Browser verification was unavailable in this run, so I could not confirm the visual result in NewDot.

ShridharGoel — since no docs PR was created, there is no help site PR to review or mark Ready for review. If you think an article should call out the filter behavior anyway, reply with @MelvinBot and the article you want updated and I'll open the draft PR.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.93-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes are required for this PR, so I did not create a docs PR.

Why: this is a pixel-level rendering fix, not a behavior or terminology change. src/components/Search/FilterComponents/MultiSelect.tsx:173 now passes undefined for footerContent instead of an always-truthy empty fragment, so SelectionList stops mounting an empty FixedFooter and its 20px of padding. The visible result is that filter popovers no longer show an unnecessary scrollbar or clip the last option.

Nothing in the change adds, removes, or renames a feature, tab, setting, button, or filter option — so no documented step or label in docs/articles became inaccurate.

What I checked

Diff scope — two files only: src/components/Search/FilterComponents/MultiSelect.tsx (conditional footerContent) and tests/ui/MultiSelectTest.tsx (three new assertions). No copy changes, no src/languages/* changes, no new UI affordance.

Docs search — I looked for articles describing the affected flows, including the Status filter (Unreported, Draft) and the Feed filter:

Each documents which filter options exist and what they mean. None documents footer spacing or scroll behavior in a filter popover, and this PR changes neither the option names nor the navigation paths.

Linked issues — [Due for payment 2026-10-01] Expense - Status modal is scrollable and [Due for payment 2026-10-01] Spend - Feed filter popup modal is cramped and cuts off content are both reported as visual defects, not as incorrect or missing documentation.

Per HELP_AUTHORING_GUIDELINES.md, help articles describe current, correct behavior — writing one here would mean documenting an already-fixed visual glitch.

@ShridharGoel — there is no linked help site PR to review, because no docs update is needed. If you disagree and want an article updated anyway, reply with @MelvinBot naming the specific article, and I'll open the draft PR with the HelpDot label and assign it to you.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/lakchote in version: 9.4.93-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants