Repository navigation
[CP Staging] fix: avoid empty footerContent in MultiSelect - #102018
Conversation
Empty React fragment passed as footerContent is truthy, causing SelectionList to mount FixedFooter with 20px padding and overflow the popover container.
|
@Krishna2323 @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Reviewing... |
Krishna2323
left a comment
There was a problem hiding this comment.
Two small test notes:
- The
footer={<></>}case only asserts thatfooterContentis defined, but an empty fragment is exactly the truthy-but-renders-nothing case this PR is fixing. Could we use a real node there instead? - Worth adding the
isLoadingMore={true}case so both sides of the condition are covered.
Could you also add the screenshots?
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-09-23.15-14-58.mp4 |
|
🚧 lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…-empty-footer [CP Staging] fix: avoid empty footerContent in MultiSelect (cherry picked from commit beb7231) (cherry-picked to staging by lakchote)
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.92-1 🚀
|
|
No help site changes are required for this PR, so I did not create a draft docs PR. This is a purely visual rendering fix inside a shared component: Nothing user-facing changed that the help site documents:
The articles that cover these flows — Managing Expenses in a Report and Use Search Operators to Filter and Analyze — describe what the filters do, not how the modal is sized, so they stay accurate as written. Note: I reviewed this from the code and diff only. Browser verification was unavailable in this run, so I could not confirm the visual result in NewDot.
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.92-8 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.4.93-0 🚀
|
|
🤖 No help site changes are required for this PR, so I did not create a docs PR. Why: this is a pixel-level rendering fix, not a behavior or terminology change. Nothing in the change adds, removes, or renames a feature, tab, setting, button, or filter option — so no documented step or label in What I checkedDiff scope — two files only: Docs search — I looked for articles describing the affected flows, including the Status filter (Unreported, Draft) and the Feed filter:
Each documents which filter options exist and what they mean. None documents footer spacing or scroll behavior in a filter popover, and this PR changes neither the option names nor the navigation paths. Linked issues — [Due for payment 2026-10-01] Expense - Status modal is scrollable and [Due for payment 2026-10-01] Spend - Feed filter popup modal is cramped and cuts off content are both reported as visual defects, not as incorrect or missing documentation. Per HELP_AUTHORING_GUIDELINES.md, help articles describe current, correct behavior — writing one here would mean documenting an already-fixed visual glitch. @ShridharGoel — there is no linked help site PR to review, because no docs update is needed. If you disagree and want an article updated anyway, reply with |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.4.93-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Only construct
footerContentinMultiSelectwhenisLoadingMoreorfooteris present.Previously,
footerContentwas unconditionally initialized as a React fragment (<>...</>). Even when empty, a React fragment is truthy in JavaScript, which causedSelectionListto mountFixedFooterwith 20px bottom padding. Becausestyles.getSelectionListPopoverHeightsizes the modal container to fit the list items exactly without expecting a footer, the extra 20px overflowed the container, causingFlashListto become scrollable and partially cut off the bottom item.Fixed Issues
$ #102004
$ #102009
PROPOSAL:
Tests
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari