Repository navigation
[NO QA] Docs updates for E/A#100885 Add GL code steps for dependent multi-level tags - #102459
Conversation
Co-authored-by: Neeraj Bachani <neerajbachani@users.noreply.github.com>
|
@MelvinBot mark this PR as ready for review |
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @sakluger |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@DylanDylann @sakluger One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR updates Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a top-level summary review of the proposed diff only. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0814596153
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ## How to add or edit a tag GL code | ||
|
|
||
| Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker. | ||
| Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. This includes single-level tags and every level of dependent or independent multi-level tags. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker. |
There was a problem hiding this comment.
| Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. This includes single-level tags and every level of dependent or independent multi-level tags. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker. | |
| Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker. |
There was a problem hiding this comment.
It would be helpful to call out exclusions, but there are no exclusions, so this added sentence is unnecessary.
|
Ehhhhh, I made a suggestion, but I'm not passionate about it. I think it's fine either way, so I'm just going to approve the current form so we can get it merged. |
|
🚀 Deployed to staging by https://github.com/sakluger in version: 9.5.1-0 🚀
|
|
Any QA steps here? |
Hi @stephanieelliott @DylanDylann @sakluger reminder to make these PRs NO QA in the title. It holds up the deploy when QA need to verify |
|
🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.1-9 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Updates the help site to reflect #100885, which lets Workspace Admins view and edit GL codes on every level of dependent multi-level tags.
Changes to
docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md:workspace.tags.glCode).multi-level tag GL codeanddependent tag GL codekeywords.@neerajbachani, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #98488
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari