Skip to content

[NO QA] Docs updates for E/A#100885 Add GL code steps for dependent multi-level tags - #102459

Merged
sakluger merged 1 commit into
mainfrom
claude-docsDependentTagGLCodes
Oct 1, 2026
Merged

sakluger merged 1 commit into
mainfrom
claude-docsDependentTagGLCodes

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Updates the help site to reflect #100885, which lets Workspace Admins view and edit GL codes on every level of dependent multi-level tags.

Changes to docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md:

  • How to add or edit a tag GL code: states that GL codes are supported on every level of dependent and independent multi-level tags, adds a step to select the tag list (level) first, and explains that each dependent tag keeps its own GL code even when the same name appears under different parents.
  • Fixes the field label from GL Code to GL code to match the UI (workspace.tags.glCode).
  • Updates the multi-level note so it no longer implies GL codes can only be changed by re-importing.
  • Adds the FAQ Can I add GL codes to dependent multi-level tags?
  • Adds multi-level tag GL code and dependent tag GL code keywords.

@neerajbachani, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #98488
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: Neeraj Bachani  <neerajbachani@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team September 28, 2026 21:40
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Sep 28, 2026
@neerajbachani

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

@blimpich
blimpich marked this pull request as ready for review September 28, 2026 22:28
@melvin-bot

melvin-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @sakluger

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-28T22:38:05.273092Z 0814596 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from DylanDylann and sakluger and removed request for a team September 28, 2026 22:28
@melvin-bot

melvin-bot Bot commented Sep 28, 2026

Copy link
Copy Markdown

@DylanDylann @sakluger One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR updates docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md to document that GL codes are now supported and editable on every level of dependent and independent multi-level tags. The proposed changes are small, focused, and align well with the governance standards.

Scores Summary

  • Readability: 9/10 - Steps are sequential and action-oriented; the added dependent-tag explanation and FAQ answer are concise and easy to scan. The Springfield/Illinois/Missouri example clarifies a genuinely tricky concept.
  • AI Readiness: 9/10 - New keywords (multi-level tag GL code, dependent tag GL code) reflect real search intent; internalScope remains accurate; the new FAQ entry is a proper question nested under the single FAQ section. Only H1 and H2 headings are used.
  • Style Compliance: 9/10 - Corrects the field label from GL Code to GL code to match the UI (workspace.tags.glCode); buttons/fields are bolded in Sentence case; navigation follows the unified web/mobile pattern.

Key Findings

  • Correct UI-terminology fix: GL Code to GL code, matching the product string.
  • The multi-level Note was accurately loosened so it no longer implies GL codes require re-importing.
  • New step ordering (select the tag list/level first) matches the real UI flow for multi-level tags.
  • The new FAQ is correctly nested under the existing FAQ heading and phrased as a question (exempt from task-based rules).
  • Keyword additions are specific and search-aligned rather than generic.

Recommendations

  • Minor: consider linking the new FAQ answer's mention of importing to the existing import-tags section for prerequisite context (optional per Cross-Linking Standards; keep volume low).
  • No blocking documentation-governance issues. The PR's own Tests/QA sections still need to be filled in by the human co-author before it is marked ready.

Files Reviewed

  • docs/articles/new-expensify/workspaces/Create-and-manage-expense-tags.md - Compliant. Focused, accurate updates to the GL code workflow and FAQ.

Note: This is a top-level summary review of the proposed diff only.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0814596153

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

## How to add or edit a tag GL code

Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker.
Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. This includes single-level tags and every level of dependent or independent multi-level tags. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. This includes single-level tags and every level of dependent or independent multi-level tags. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker.
Workspaces on the Control plan can assign a GL code to each tag for exporting purposes. By default, tag GL codes are not visible to members, but you can choose to show them in the tag picker.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be helpful to call out exclusions, but there are no exclusions, so this added sentence is unnecessary.

@sakluger

sakluger commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Ehhhhh, I made a suggestion, but I'm not passionate about it. I think it's fine either way, so I'm just going to approve the current form so we can get it merged.

@sakluger
sakluger merged commit 4b48ba2 into main Oct 1, 2026
22 of 27 checks passed
@sakluger
sakluger deleted the claude-docsDependentTagGLCodes branch October 1, 2026 00:30
@OSBotify OSBotify mentioned this pull request Oct 1, 2026
73 tasks done
@OSBotify

OSBotify commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/sakluger in version: 9.5.1-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@IuliiaHerets

Copy link
Copy Markdown

Any QA steps here?

cc @sakluger @stephanieelliott @DylanDylann

@Julesssss Julesssss changed the title Docs updates for E/A#100885 Add GL code steps for dependent multi-level tags [NO QA] Docs updates for E/A#100885 Add GL code steps for dependent multi-level tags Oct 2, 2026
@Julesssss

Copy link
Copy Markdown
Contributor

Any QA steps here?

Hi @stephanieelliott @DylanDylann @sakluger reminder to make these PRs NO QA in the title. It holds up the deploy when QA need to verify

@OSBotify

OSBotify commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.1-9 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants