[BC][R1] Scope the Business Central icon gradient ids to each rendered copy by c3024 · Pull Request #102554 · Expensify/App

c3024 · 2026-09-29T15:23:15Z

Explanation of Change

On web, the Business Central icon next to "…are imported from your Dynamics 365 Business Central settings" on the Tags and Categories pages shows only its navy background after the admin opens the Accounting page first.

Web builds give every copy of an SVG file the same ids, and the Accounting screen stays mounted with display: none after navigating away. The icon's gradients then resolve to the hidden copy on the Accounting screen, which the browser does not paint. Business Central is the only connection icon whose mark is drawn with gradients.

This PR turns the icon into a react-native-svg component that prefixes its gradient ids with useId, the same way the map marker icons scope their filter ids. Every rendered copy now has its own gradients, so the icon keeps Microsoft's mark unchanged.

Fixed Issues

$ tied to #99052
PROPOSAL: N/A

Tests

Sign in as an admin of a Control workspace connected to Dynamics 365 Business Central.
Go to Workspace settings > Accounting.
Verify the Dynamics 365 Business Central row shows the Business Central mark on a navy circle.
Click Categories in the workspace menu.
Verify the icon before "Dynamics 365 Business Central settings" shows the full Business Central mark, not only the navy circle.
Enable Tags, import tags from Business Central, go to Accounting again and then click Tags.
Verify the icon before "Dynamics 365 Business Central settings" shows the full Business Central mark.
Repeat steps 2 to 7 in dark mode.

Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

after-2-categories-after-accounting-light

after-5-categories-after-accounting-dark

after-8-narrow-categories-after-accounting-light

Web builds give every copy of an SVG file the same ids, and screens that are no longer focused stay mounted with display: none. The gradients of the Business Central mark then resolved to a hidden copy, which the browser does not paint, so only the navy background showed. The icon is now a react-native-svg component that prefixes its gradient ids with useId, like the map marker icons.

codecov · 2026-09-29T15:29:52Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/components/Icon/chunks/expensify-icons.chunk.ts	`0.00% <ø> (ø)`
src/components/Icon/BusinessCentralSquare.tsx	`0.00% <0.00%> (ø)`
... and 205 files with indirect coverage changes

melvin-bot · 2026-09-29T16:32:45Z

@daledah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NikkiWines

LGTM, some small suggestions. But let's also remove assets/images/integrationicons/business-central-icon-square.svg

NikkiWines · 2026-09-30T12:00:22Z

 import Zoom from '@assets/images/zoom.svg';

+// This icon is a React component because its gradient ids must be unique to each rendered copy
+import BusinessCentralSquare from '@components/Icon/BusinessCentralSquare';


Suggested change

import BusinessCentralSquare from '@components/Icon/BusinessCentralSquare';

import BusinessCentralSquare from '@components/Icon/BusinessCentralSquare';

(comment below needs a newline above it)

oxfmt removes blank lines between imports in the same group, so I combined the two comments into one above the group.

NikkiWines · 2026-09-30T12:03:29Z

This one is pretty simple so no need fro a review @daledah 🙇

… SVG

…group

NikkiWines · 2026-09-30T13:27:14Z

@c3024 ~~please fill out the author checklist and add some QA steps 🙇~~ nvm the steps are done but looks like the author checklist might be out of date

c3024 · 2026-09-30T13:31:16Z

@NikkiWines yea, the author checklist has changed yesterday. updated the checklist. thanks!

NikkiWines · 2026-09-30T13:37:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

NikkiWines

thank you!

github-actions · 2026-09-30T13:48:34Z

🚧 NikkiWines has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-09-30T13:49:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-09-30T13:52:46Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #102554.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-92b8b12-a5dc5a1-d9464f47cee126203259c998491f741b8573f51e/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-92b8b12-a5dc5a1-c8c4fefbe4506b848fcf619907e010ef97a60352/index.html

Web 🕸️
https://102554.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-01T00:03:43Z

🚀 Deployed to staging by https://github.com/NikkiWines in version: 9.5.0-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-01T00:07:51Z

No help site update is needed. This PR fixes a web rendering bug in the Dynamics 365 Business Central icon, and no article text describes that icon or depends on how it renders.

view run

OSBotify · 2026-10-01T22:49:22Z

🚀 Deployed to production by https://github.com/Julesssss in version: 9.5.0-5 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned c3024 Sep 29, 2026

c3024 mentioned this pull request Sep 29, 2026

[BC][R1] Define the Business Central icon gradients in the global SVG definitions #102557

Closed

40 tasks

c3024 marked this pull request as ready for review September 29, 2026 16:32

c3024 requested review from a team as code owners September 29, 2026 16:32

melvin-bot Bot requested review from daledah and flaviadefaria and removed request for a team September 29, 2026 16:32

melvin-bot Bot removed the request for review from a team September 29, 2026 16:32

NikkiWines requested changes Sep 30, 2026

View reviewed changes

NikkiWines removed the request for review from daledah September 30, 2026 12:03

Reword the Business Central icon comment and remove the unused square…

4f8503c

… SVG

c3024 requested a review from a team as a code owner September 30, 2026 12:37

Describe the React component icons in one comment above their import …

bece597

…group

c3024 requested a review from NikkiWines September 30, 2026 12:43

NikkiWines approved these changes Sep 30, 2026

View reviewed changes

NikkiWines merged commit 92b8b12 into Expensify:main Sep 30, 2026
35 of 39 checks passed

OSBotify mentioned this pull request Sep 30, 2026

Deploy Checklist: New Expensify 2026-09-30 #102701

Closed

70 tasks done

	import BusinessCentralSquare from '@components/Icon/BusinessCentralSquare';
	import BusinessCentralSquare from '@components/Icon/BusinessCentralSquare';

Conversation

c3024 commented Sep 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov Bot commented Sep 29, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Sep 29, 2026

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

NikkiWines Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

NikkiWines Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

c3024 Sep 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

NikkiWines commented Sep 30, 2026

Uh oh!

NikkiWines commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

c3024 commented Sep 30, 2026

Uh oh!

NikkiWines commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

NikkiWines left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

OSBotify commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

OSBotify commented Oct 1, 2026

Uh oh!

MelvinBot commented Oct 1, 2026

Uh oh!

OSBotify commented Oct 1, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

c3024 commented Sep 29, 2026 •

edited

Loading

codecov Bot commented Sep 29, 2026 •

edited by github-actions Bot

Loading

NikkiWines commented Sep 30, 2026 •

edited

Loading

NikkiWines commented Sep 30, 2026 •

edited

Loading