[c3024]

Explanation of Change

On web, the Business Central icon next to "…are imported from your Dynamics 365 Business Central settings" on the Tags and Categories pages shows only its navy background after the admin opens the Accounting page first.

Web builds give every copy of an SVG file the same ids, and the Accounting screen stays mounted and hidden after navigating away. The icon's gradients then resolve to the copy on the hidden Accounting screen, which the browser does not paint. Business Central is the only connection icon whose mark is drawn with gradients.

The empty-state background hit the same problem in #70060, which added SVGDefinitionsProvider: an always-rendered, zero-size SVG at the app root that defines the gradient under the same id the build generates, so every copy resolves to that visible definition first. This PR adds the Business Central icon's gradients and clip paths to it with the ids the build generates (business-central-icon-square_svg__*). The SVG file is unchanged, so the icon keeps Microsoft's mark. On native the provider renders nothing, as before.

This is an alternative to #102552 (solid fills) and #102554 (per-copy ids in a component).

Fixed Issues

$ #99052
PROPOSAL: N/A

Tests

1. Sign in as an admin of a Control workspace connected to Dynamics 365 Business Central.
2. Go to Workspace settings > Accounting.
3. Verify the Dynamics 365 Business Central row shows the Business Central mark on a navy circle.
4. Click Categories in the workspace menu.
5. Verify the icon before "Dynamics 365 Business Central settings" shows the full Business Central mark, not only the navy circle.
6. Enable Tags, import tags from Business Central, go to Accounting again and then click Tags.
7. Verify the icon before "Dynamics 365 Business Central settings" shows the full Business Central mark.
8. Repeat steps 2 to 7 in dark mode.

• Verify that no errors appear in the JS console

Offline tests

Same as Tests.

QA Steps

Same as Tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/SVGDefinitionsProvider/index.tsx	0.00% <ø> (ø)
...tionsProvider/BusinessCentralSquareDefinitions.tsx	0.00% <0.00%> (ø)
... and 10 files with indirect coverage changes