Repository navigation
Keep non-reimbursable-only reports out of Ready to pay before their expenses load #105618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
joekaufmanexpensify
merged 2 commits into
main
from
claude-payOptionalUnloadedNonReimbursableReports
Nov 17, 2026
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an approved report combines non-reimbursable spend with an unloaded reimbursable SmartScan expense whose amount is not known yet, the report totals still look like
reimbursableTotal: 0with a nonzero non-reimbursable total. This empty-transaction branch therefore marks the report pay-optional and removes it from the Pay to-do, LHN badge, and Search Pay action; once its transactions load, the existing unsettled-expense check reverses that decision, so a payer may not discover the reimbursement unless they independently open or fetch the report. Avoid trusting this totals-only classification until the absence of scanning or otherwise unsettled reimbursable expenses can be established.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MelvinBot please review this suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The suggestion identifies a real classification gap, but the P1 impact is not yet demonstrated.
Recommendation: Validate approval and scan-completion recovery for the mixed case. If reachable, preserve fail-closed behavior until complete transactions or an authoritative report-level signal rules out unsettled reimbursements. Add regression coverage for unloaded → loaded → scan-completed transitions; the new tests do not cover them.
No code changes made or runtime tests run for this review.
view run