Repository navigation
[Payment due @TaduJR] [HOLD] Show share report on draft reports - #105650
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-03.at.3.10.37.PM.movAndroid: mWeb ChromeScreen.Recording.2026-11-03.at.3.14.56.PM.moviOS: HybridAppScreen.Recording.2026-11-03.at.3.22.06.PM.moviOS: mWeb SafariScreen.Recording.2026-11-03.at.3.24.01.PM.movMacOS: Chrome / SafariMac-Chrome.mp4 |
|
@mkhutornyi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
sorry guys, idk what is so messed up, please ignore the pings , @TaduJR will be reviewing this PR https://expensify.slack.com/archives/C02NK2DQWUX/p1793702728068839 |
|
No problem. I missed golden assignment. I am available too. |
|
@MelvinBot @codex review |
Review: no blocking issues in the App codeThe change is small and correct on the App side. Removing Please confirm these points before merging:
I didn't run the unit tests or test the UI in this run. |
|
Codex Review: Didn't find any major issues. Delightful! Reviewed commit: ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
|
@stitesExpensify, @NicolasBonet was auto assigned by pullerbear to review the BE PR's , so i switched to them here since they have context 😄 |
the backend change for the email is up, this PR is on HOLD for it
same as submitted reports today, keeping it out of scope
added 65d96e9 |
|
@TaduJR pushed a small change, approvers can't share a draft now, mind taking another look? |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
Merged by mistake, apologies @allgandalf, will create a new PR for reverting the revert once the hold is done 😅 |
|
🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.32-0 🚀
|
|
No FullStory changes needed. This PR fixes draft-report sharing permissions and reuses the existing Share controls and screen. |
|
No help site update needed: this change was reverted, and its replacement remains on hold, so the existing documentation still matches the supported behavior. |
|
@allgandalf This PR is failing because of a regression issue #106014 The issue is reproducible in: web, ios, android Bug7305235_1793828556295.Recording__1966.mp4 |
|
🤖 Payment issue created: #106186 |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.5.32-7 🚀
|
Explanation of Change
canShareReporthid Share report on draft reports. Drafts sit under the workspace chat and other people can open them, so the submitter and workspace admins can share them now. The approver can share once the report is submitted, since that's when they get the share permission.On HOLD until the backend sends the share email for drafts.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/697586
PROPOSAL:
Tests
Offline tests
N/A, sharing a report needs the server.
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
share-draft-report.mp4