Skip to content

[HOLD Auth#26174] Revert "Revert "[Payment due @TaduJR] Show share report on draft reports"" - #105945

Merged
NicolasBonet merged 3 commits into
mainfrom
revert-105943-revert-105650-share-draft-report
Nov 17, 2026
Merged

NicolasBonet merged 3 commits into
mainfrom
revert-105943-revert-105650-share-draft-report

Conversation

@NicolasBonet

@NicolasBonet NicolasBonet commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Re-applies #105650 which was reverted in here: #105943 as the BE wasn't ready yet.

Hold because of https://github.com/Expensify/Auth/pull/26174

@NicolasBonet
NicolasBonet requested review from a team as code owners November 4, 2026 18:17
@melvin-bot
melvin-bot Bot requested a review from garrettmknight November 4, 2026 18:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 4, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-04T18:32:41.563439Z b89604f PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from mollfpr and removed request for a team November 4, 2026 18:18
@melvin-bot

melvin-bot Bot commented Nov 4, 2026

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

@allgandalf fyi

@NicolasBonet NicolasBonet changed the title [HOLD] Revert "Revert "[Payment due @TaduJR] Show share report on draft reports"" [HOLD Auth#26174] Revert "Revert "[Payment due @TaduJR] Show share report on draft reports"" Nov 4, 2026
@allgandalf

Copy link
Copy Markdown
Contributor

BE PR was merged , awaiting deploy

@NicolasBonet

Copy link
Copy Markdown
Contributor Author

@allgandalf auth was deployed, could you please quickly confirm this still works as expected so we can proceed with reviews? 🙏

@allgandalf

Copy link
Copy Markdown
Contributor

LGTM!, @TaduJR can you post the checklist please ?

@TaduJR

TaduJR commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-03.at.3.10.37.PM.mov
Android: mWeb Chrome
Screen.Recording.2026-11-03.at.3.14.56.PM.mov
iOS: HybridApp
Screen.Recording.2026-11-03.at.3.22.06.PM.mov
iOS: mWeb Safari
Screen.Recording.2026-11-03.at.3.24.01.PM.mov
MacOS: Chrome / Safari
Mac-Chrome.mp4

@TaduJR TaduJR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@expensify-chore-bot
expensify-chore-bot Bot requested a review from Gonals November 16, 2026 09:48
@expensify-chore-bot

Copy link
Copy Markdown

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@NicolasBonet
NicolasBonet merged commit ccbcf44 into main Nov 17, 2026
45 of 47 checks passed
@NicolasBonet
NicolasBonet deleted the revert-105943-revert-105650-share-draft-report branch November 17, 2026 21:26
@github-actions

Copy link
Copy Markdown
Contributor

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@m-natarajan

Copy link
Copy Markdown

@NicolasBonet No QA steps, OK to checkoff this one?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@TaduJR

TaduJR commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot

Please create payment issue for this

@MelvinBot

Copy link
Copy Markdown
Contributor

Created Payment issue for this PR, assigned to TaduJR.

Payment timing is pending production deployment. Included the original payment issue for checking against duplicate compensation.


view run

@allgandalf

Copy link
Copy Markdown
Contributor

@NicolasBonet No QA steps, OK to checkoff this one?

@m-natarajan QA steps are:

  1. Create an expense in a workspace chat and don't submit the report
  2. Open the report and click More > Share
  3. Verify Share report shows, then share it with another email
  4. Verify the recipient gets the email with the report
  5. Sign in as the approver of that draft, open it and verify More > Share doesn't show Share report

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants