Repository navigation
[HOLD Auth#26174] Revert "Revert "[Payment due @TaduJR] Show share report on draft reports"" - #105945
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@allgandalf fyi |
…105650-share-draft-report
|
BE PR was merged , awaiting deploy |
…105650-share-draft-report
|
@allgandalf auth was deployed, could you please quickly confirm this still works as expected so we can proceed with reviews? 🙏 |
|
LGTM!, @TaduJR can you post the checklist please ? |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-03.at.3.10.37.PM.movAndroid: mWeb ChromeScreen.Recording.2026-11-03.at.3.14.56.PM.moviOS: HybridAppScreen.Recording.2026-11-03.at.3.22.06.PM.moviOS: mWeb SafariScreen.Recording.2026-11-03.at.3.24.01.PM.movMacOS: Chrome / SafariMac-Chrome.mp4 |
|
🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@NicolasBonet No QA steps, OK to checkoff this one? |
|
🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.41-0 🚀
|
|
Please create payment issue for this |
|
Created Payment issue for this PR, assigned to Payment timing is pending production deployment. Included the original payment issue for checking against duplicate compensation. |
@m-natarajan QA steps are:
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
Re-applies #105650 which was reverted in here: #105943 as the BE wasn't ready yet.
Hold because of https://github.com/Expensify/Auth/pull/26174