Skip to content

Remove contacts prompt - #106089

Merged
mountiny merged 5 commits into
Expensify:mainfrom
software-mansion-labs:fix/remove-contacts-prompt
Nov 7, 2026
Merged

mountiny merged 5 commits into
Expensify:mainfrom
software-mansion-labs:fix/remove-contacts-prompt

Conversation

@staszekscp

@staszekscp staszekscp commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

On iOS, sharing a photo to Expensify could freeze the "Share to Expensify" screen. Nothing on it responded, and it stayed frozen after reopening the app.

Why it happened:

  1. When the shared file fails validation, the share flow shows the "Attachment error" bottom sheet through the global modal stack. In production this was a HEIC photo whose JPEG conversion failed with Cannot read property 'saveAsync' of undefined.
  2. About half a second later, the participant picker opens the import contacts prompt on the same stack. The stack only renders its top modal, so the error sheet is unmounted while iOS is still presenting it, and the prompt is presented 8 ms later.
  3. The prompt then receives no taps. The error sheet's promise never resolves, so validation never finishes: Share and Submit do nothing, and every retry logs Files are already being validated.
  4. Reopening the app processes the shared file again, so the same thing happens.

What this PR changes:

  • The share flow no longer shows the import contacts prompt. MoneyRequestParticipantsSelector and ParticipantSearchResults get a shouldShowContactImportPrompt prop (default true), passed to useContactPermissionModal as isEnabled. When it's false, the hook only focuses the search input. ShareTabParticipantsSelector passes false. The "Import contacts" row and all other flows are unchanged.
  • The share picker waits to focus its search input until the shared file is known. For files that are checked first (HEIC and generic images), it also waits until the check has passed. Before, the keyboard could open right before the error bottom sheet. This adds a shouldDeferTextInputAutoFocus prop to the same two components.
  • Unit tests for useContactPermissionModal and ShareTabParticipantsSelector.

The attachment error bottom sheet stays as it is. Android uses the same code, so its share flow also no longer shows the prompt.

Not in this PR (follow-ups to be verified if can help):

  • The HEIC conversion failure itself: expo-modules-core resolves renderAsync() to undefined instead of rejecting.
  • The global modal stack replacing a visible modal mid-presentation. Any two confirm modals opened close together can still hit this.
  • useFilesValidation staying in the "validating" state until the error sheet is answered.

Fixed Issues

$ #105954
PROPOSAL: https://swmansion.slack.com/archives/C05LX9D6E07/p1793873139611059?thread_ts=1793804524.682409&cid=C05LX9D6E07

Tests

  1. In Photos, share a photo (HEIC if possible) to Expensify.
  2. Verify the "Share to Expensify" screen opens and no import contacts prompt appears.
  3. Switch between the Submit and Share tabs, select a participant and finish the share. Verify it completes normally.

Attachment error:
4. Share a photo that fails validation. File below (unpack it, there is a corrupted heic file)
5. Verify the "Attachment error" bottom sheet shows, the keyboard doesn't open before it, and no import contacts prompt appears.
6. Close the bottom sheet and verify the screen still responds, e.g. the back button works.

corrupted-receipt.heic.zip

Offline tests

QA Steps

  1. In Photos, share a photo (HEIC if possible) to Expensify.
  2. Verify the "Share to Expensify" screen opens and no import contacts prompt appears.
  3. Switch between the Submit and Share tabs, select a participant and finish the share. Verify it completes normally.

Attachment error:
4. Share a photo that fails validation. File below (unpack it, there is a corrupted heic file)
5. Verify the "Attachment error" bottom sheet shows, the keyboard doesn't open before it, and no import contacts prompt appears.
6. Close the bottom sheet and verify the screen still responds, e.g. the back button works.

corrupted-receipt.heic.zip

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2026-11-05.at.14.44.21.mov
Android: mWeb Chrome
iOS: Native
ScreenRecording_11-05-2026.14-10-42_1.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
.../components/Share/ShareTabParticipantsSelector.tsx 62.26% <100.00%> (+62.26%) ⬆️
...rc/hooks/useContactPermissionModal/index.native.ts 56.00% <100.00%> (+56.00%) ⬆️
...s/iou/request/MoneyRequestParticipantsSelector.tsx 0.00% <0.00%> (ø)
src/pages/iou/request/ParticipantSearchResults.tsx 0.00% <0.00%> (-0.37%) ⬇️
... and 649 files with indirect coverage changes

@staszekscp
staszekscp marked this pull request as ready for review November 5, 2026 13:46
@staszekscp
staszekscp requested review from a team as code owners November 5, 2026 13:46
@melvin-bot
melvin-bot Bot requested review from ikevin127 and removed request for a team November 5, 2026 13:46
@melvin-bot

melvin-bot Bot commented Nov 5, 2026

Copy link
Copy Markdown

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

This comment has been minimized.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@mountiny
mountiny self-requested a review November 5, 2026 21:42
@mountiny

mountiny commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

This was approved by @JmillsExpensify

@github-actions

This comment has been minimized.

@ikevin127

ikevin127 commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
screen-20261105-150750-1793920042526.mp4
iOS: HybridApp
Screen.Recording.iPhone.18.Pro.11-05-2026.at.14.57.34.mp4

JmillsExpensify
JmillsExpensify previously approved these changes Nov 5, 2026

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks good to me. We're finding in FullStory sessions that we are overwhelming users with these bottom sheet adverts, so let's pair it back and think more holistically about this.

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Tests well, changes are contained to native, no blockers. Just 4 clean-up comments.

Comment on lines +31 to +34
if (!isEnabled) {
onFocusTextInput();
return;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 This branch does the same thing as the hasDeniedContactImportPrompt one right below it, so they can be a single check:

if (!isEnabled || hasDeniedContactImportPrompt) {
    onFocusTextInput();
    return;
}

👁️ Written by AI, reviewed by Kevin.

onRestrictedParticipantSelected,
onCloseParticipantPicker,
shouldBlockParticipantSelection,
shouldShowContactImportPrompt,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 shouldDeferTextInputAutoFocus has a default here and in ParticipantSearchResults, but shouldShowContactImportPrompt only has one in ParticipantSearchResults. Can we give it = true here as well?

Then this file alone shows the prompt is on unless a caller turns it off.

👁️ Written by AI, reviewed by Kevin.

mountiny
mountiny previously approved these changes Nov 5, 2026

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but lets address the comments from Kevin

@staszekscp

Copy link
Copy Markdown
Contributor Author

Addressed!

@staszekscp
staszekscp dismissed stale reviews from mountiny and JmillsExpensify via a466349 November 6, 2026 10:54

@ikevin127 ikevin127 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 LGTM - Thanks for addressing the comments!

@melvin-bot
melvin-bot Bot requested a review from mountiny November 6, 2026 20:55

@mountiny mountiny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for addressing these. Looks good to me.

@mountiny
mountiny merged commit 29c8db5 into Expensify:main Nov 7, 2026
39 of 41 checks passed
@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

@OSBotify OSBotify mentioned this pull request Nov 7, 2026
85 tasks done
@OSBotify

OSBotify commented Nov 7, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.34-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes a photo-sharing freeze without adding a new workflow or making existing article instructions incorrect.


view run

@MelvinBot

Copy link
Copy Markdown
Contributor

No FullStory changes needed. This PR only fixes the share-screen freeze by suppressing the contacts prompt and deferring search autofocus; it adds no new screens, controls, user-property values, or sensitive content.


view run

@OSBotify

OSBotify commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants