Repository navigation
Remove contacts prompt - #106089
Remove contacts prompt#106089
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This comment has been minimized.
This comment has been minimized.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
This was approved by @JmillsExpensify |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: Nativescreen-20261105-150750-1793920042526.mp4iOS: HybridAppScreen.Recording.iPhone.18.Pro.11-05-2026.at.14.57.34.mp4 |
JmillsExpensify
left a comment
There was a problem hiding this comment.
Yes, looks good to me. We're finding in FullStory sessions that we are overwhelming users with these bottom sheet adverts, so let's pair it back and think more holistically about this.
ikevin127
left a comment
There was a problem hiding this comment.
🟢 Tests well, changes are contained to native, no blockers. Just 4 clean-up comments.
| if (!isEnabled) { | ||
| onFocusTextInput(); | ||
| return; | ||
| } |
There was a problem hiding this comment.
🟢 This branch does the same thing as the hasDeniedContactImportPrompt one right below it, so they can be a single check:
if (!isEnabled || hasDeniedContactImportPrompt) {
onFocusTextInput();
return;
}👁️ Written by AI, reviewed by Kevin.
| onRestrictedParticipantSelected, | ||
| onCloseParticipantPicker, | ||
| shouldBlockParticipantSelection, | ||
| shouldShowContactImportPrompt, |
There was a problem hiding this comment.
🟢 shouldDeferTextInputAutoFocus has a default here and in ParticipantSearchResults, but shouldShowContactImportPrompt only has one in ParticipantSearchResults. Can we give it = true here as well?
Then this file alone shows the prompt is on unless a caller turns it off.
👁️ Written by AI, reviewed by Kevin.
mountiny
left a comment
There was a problem hiding this comment.
Looks good to me, but lets address the comments from Kevin
|
Addressed! |
a466349
ikevin127
left a comment
There was a problem hiding this comment.
🟢 LGTM - Thanks for addressing the comments!
mountiny
left a comment
There was a problem hiding this comment.
Thank you for addressing these. Looks good to me.
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.34-0 🚀
|
|
No help site update needed — this PR fixes a photo-sharing freeze without adding a new workflow or making existing article instructions incorrect. |
|
No FullStory changes needed. This PR only fixes the share-screen freeze by suppressing the contacts prompt and deferring search autofocus; it adds no new screens, controls, user-property values, or sensitive content. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.34-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
On iOS, sharing a photo to Expensify could freeze the "Share to Expensify" screen. Nothing on it responded, and it stayed frozen after reopening the app.
Why it happened:
Cannot read property 'saveAsync' of undefined.Files are already being validated.What this PR changes:
MoneyRequestParticipantsSelectorandParticipantSearchResultsget ashouldShowContactImportPromptprop (defaulttrue), passed touseContactPermissionModalasisEnabled. When it'sfalse, the hook only focuses the search input.ShareTabParticipantsSelectorpassesfalse. The "Import contacts" row and all other flows are unchanged.shouldDeferTextInputAutoFocusprop to the same two components.useContactPermissionModalandShareTabParticipantsSelector.The attachment error bottom sheet stays as it is. Android uses the same code, so its share flow also no longer shows the prompt.
Not in this PR (follow-ups to be verified if can help):
renderAsync()toundefinedinstead of rejecting.useFilesValidationstaying in the "validating" state until the error sheet is answered.Fixed Issues
$ #105954
PROPOSAL: https://swmansion.slack.com/archives/C05LX9D6E07/p1793873139611059?thread_ts=1793804524.682409&cid=C05LX9D6E07
Tests
Attachment error:
4. Share a photo that fails validation. File below (unpack it, there is a corrupted heic file)
5. Verify the "Attachment error" bottom sheet shows, the keyboard doesn't open before it, and no import contacts prompt appears.
6. Close the bottom sheet and verify the screen still responds, e.g. the back button works.
corrupted-receipt.heic.zip
Offline tests
QA Steps
Attachment error:
4. Share a photo that fails validation. File below (unpack it, there is a corrupted heic file)
5. Verify the "Attachment error" bottom sheet shows, the keyboard doesn't open before it, and no import contacts prompt appears.
6. Close the bottom sheet and verify the screen still responds, e.g. the back button works.
corrupted-receipt.heic.zip
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-11-05.at.14.44.21.mov
Android: mWeb Chrome
iOS: Native
ScreenRecording_11-05-2026.14-10-42_1.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari