Skip to content

Fix sharing HEIC/HEIF files on Android - #106816

Merged
mountiny merged 5 commits into
Expensify:mainfrom
mkhutornyi:fix-106387
Nov 13, 2026
Merged

mountiny merged 5 commits into
Expensify:mainfrom
mkhutornyi:fix-106387

Conversation

@mkhutornyi

@mkhutornyi mkhutornyi commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Android never offered Expensify as a share target for HEIC/HEIF files because neither manifest listed those MIME types.
This adds image/heic and image/heif to the share filter (here and in the Mobile-Expensify PR).

With that in place, the shared HEIC failed to convert. convertImageWithManipulator is an async arrow with a destructured default param, and the Hermes version React Native ships resolves the first await in such functions as undefined (meta/hermes#1761, backport meta/hermes#2030 still open).
The callbacks are now a plain param destructured in the body.
Shared HEIF files are also routed through the conversion like HEIC.

Fixed Issues

$ #106387
$ #106879

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/14229

Tests

Android share sheet

  1. Open the device file manager and find a .heic image
  2. Tap Share
  3. Verify Expensify appears in the app list
  4. Select Expensify
  5. Verify the share screen opens with the Submit and Share tabs and no "We couldn't process this image" error
  6. On the Share tab, pick a chat and send
  7. Verify the image is sent as an attachment
  8. Repeat steps 1 to 4, then on the Submit tab pick a recipient and submit
  9. Verify the expense is created with the image as its receipt
  10. Repeat steps 1 to 9 with a .heif image

iOS share extension

  1. Open the Files app, long-press a .heic image and tap Share
  2. Select Expensify
  3. Verify the share screen opens with the Submit and Share tabs and no "We couldn't process this image" error
  4. On the Share tab, pick a chat and send
  5. Verify the image is sent as an attachment
  6. Repeat steps 1 to 5 with a .heif image

Choose file (iOS and Android)

  1. Open a chat, tap + > Add attachment > Choose file and pick a .heic image
  2. Verify the attachment preview opens with no "We couldn't process this image" error and send it
  3. Verify the image is sent as an attachment
  4. Tap the global create button > Create expense > Scan > Choose file and pick a .heic image
  5. Verify the receipt is accepted and the expense can be created
  • Verify that no errors appear in the JS console

Offline tests

Same as tests. Verify the attachment and the expense are created offline and sync when back online.

QA Steps

Same as tests (Android only)

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
before.fix.mov
after.fix.mov
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@mkhutornyi
mkhutornyi marked this pull request as ready for review November 13, 2026 08:32
@mkhutornyi
mkhutornyi requested review from a team as code owners November 13, 2026 08:32
@melvin-bot
melvin-bot Bot requested review from TaduJR and situchan and removed request for a team November 13, 2026 08:32
@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

@TaduJR @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and removed request for a team November 13, 2026 08:32
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T08:45:49.306497Z 8e21675 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@TaduJR

TaduJR commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Reviewing...

@mkhutornyi

Copy link
Copy Markdown
Contributor Author

Sorry. @DylanDylann would you like to review since you're original assignee?

@mkhutornyi
mkhutornyi requested review from mountiny and removed request for TaduJR and situchan November 13, 2026 08:37
@mkhutornyi

Copy link
Copy Markdown
Contributor Author

If this was caught during regression testing, add the test name, ID and link from BrowserStack: #106089

@mountiny I requested your review if you don't mind since the bug was caught during testing PR you reviewed.

Also https://github.com/Expensify/Mobile-Expensify/pull/14229

@mkhutornyi
mkhutornyi requested a review from TaduJR November 13, 2026 08:43
@TaduJR TaduJR self-assigned this Nov 13, 2026
@TaduJR

TaduJR commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@TaduJR

TaduJR commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-13.at.7.55.01.PM.mov
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@TaduJR

TaduJR commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

Bug: HEIF shares don't get the Submit tab.

Prerequisite: a HEIC and a HEIF image on the device.

Steps

  1. Open the Files app, long-press the .heif image and tap Share.
  2. Pick Expensify.

Expected: the Submit and Share tabs both show, as they do for HEIC.

Actual: only the Share tab shows.

Sharing the .heic image the same way shows both tabs, with Submit selected. Android sends image/heif for the .heif file and image/heic for the .heic one.

Cause

  • ShareRootPage.tsx:139 only shows the Submit tab when the MIME type is in CONST.RECEIPT_ALLOWED_FILE_TYPES.
  • That list includes image/heic but not image/heif.
  • IMO the fix is to just add HEIF: 'image/heif' to the list, next to HEIC.
HEIF (Share only) HEIC (Submit + Share)
HEIF share shows only the Share tab HEIC share shows the Submit and Share tabs

@mkhutornyi

Copy link
Copy Markdown
Contributor Author

@TaduJR please check again now.

@TaduJR TaduJR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just some minor things

Tests: the converter fix also covers flows outside the Android share sheet. Can we add these to Tests/QA?

Unit test: can we add a shouldValidateFile({mimeType: 'image/heif'}) case to tests/unit/ReceiptUtilsTest.ts? The unit test box is ticked, but I don't see one in the diff.

mkhutornyi and others added 2 commits November 13, 2026 14:12
Co-authored-by: TaduJR <90861780+TaduJR@users.noreply.github.com>
@mkhutornyi

Copy link
Copy Markdown
Contributor Author

Thanks! All addressed

@TaduJR

TaduJR commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

@mkhutornyi

Copy link
Copy Markdown
Contributor Author

Thanks! Mind checking this one Expensify/Mobile-Expensify#14229 (review)

Updated!

@TaduJR

TaduJR commented Nov 13, 2026

Copy link
Copy Markdown
Contributor

BUG 1: 48 MP HEIC fails to convert

Prerequisite: a 48 MP HEIC on the device:

  1. In the Files app, long-press → Share → Expensify.
  2. Wait about 15 seconds.

Expected: it converts, and the share screen opens normally.

Actual: "We couldn't process this image" appears. Logcat shows Context.renderAsync has been rejected → JobCancellationException: DeferredCoroutine was cancelled.

BUG 2: Share button does nothing after a failed conversion

Prerequisite: a broken HEIC.

  1. Share broken.heic from Files to Expensify.
  2. "We couldn't process this image" appears. Tap Close.
  3. Open the Share tab, pick any chat, tap Share.

Expected: an error or a way back.

Actual: nothing happens. The attachment box shows only a paperclip, and nothing is sent.

BUG 3: WebP can't be shared on Android

Prerequisite: a .webp image on the device.

  1. In the Files app, long-press the .webp → Share.

Expected: Expensify is listed.

Actual: Expensify isn't listed.

BUG 4: a .hif file isn't converted

Prerequisite: a HEIC copied as .hif: cp photo.heic photo.hif.

  1. Share photo.hif from Files to Expensify.
  2. In React DevTools, inspect ShareTabParticipantsSelector and read the VALIDATED_FILE_OBJECT value.

Expected: name: "photo.jpg", type: "image/jpeg".

Actual: name: "photo.hif", type: "image/heif", so the raw HEIF is what would be uploaded. Sharing photo.heic the same way converts to JPEG.

All the above one are pre-existing issues found during review. We can work on them after CME reviews all.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@JmillsExpensify JmillsExpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on the iOS adhoc. This fixed my issue so approving.

@TaduJR TaduJR left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mountiny
mountiny merged commit 2b70552 into Expensify:main Nov 13, 2026
40 of 41 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mountiny in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR fixes HEIC/HEIF sharing and image conversion in existing workflows, restoring expected behavior without making any existing article sentence incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants