Repository navigation
Conversation
Resizing a column on one suggested or saved search no longer changes the widths of other searches with the same data type. Widths are keyed by data type and search key, and a deleted saved search drops its widths.
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Renders the layout for two searches of the same data type and checks each reads the widths stored under its own search key.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMonosnap.screencast.2026-11-07.00-41-48.mp4 |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.35-0 🚀
|
|
No FullStory changes needed — this PR only fixes column-width persistence across existing Spend searches and cleans up stored widths when a saved search is deleted. |
|
No help site update needed — this fixes column-width persistence behind the existing beta, without introducing a public workflow or making any existing article sentence incorrect. |
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.5.35-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Follow-up to #105128. Spend column widths were saved per data type, so resizing Reports also resized every to-do and saved report search. Widths are now keyed by data type and search key, so each search keeps its own, filters keep them, and deleting a saved search clears them.
Fixed Issues
$ #101331
PROPOSAL:
Tests
Requires the
resizableTableColumnsbeta.Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari