Repository navigation
Save Spend column widths per search #106099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JS00001
merged 2 commits into
Expensify:main
from
software-mansion-labs:war-in/search-column-widths-per-search
Nov 8, 2026
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import {render} from '@testing-library/react-native'; | ||
|
|
||
| import SearchListViewLayout from '@components/Search/SearchListViewLayout'; | ||
| import type {SearchColumnType} from '@components/Search/types'; | ||
| import useStoredColumnWidths from '@components/Table/columnResize/useStoredColumnWidths'; | ||
|
|
||
| import type {SearchKey} from '@libs/SearchKeyUtils'; | ||
|
|
||
| import CONST from '@src/CONST'; | ||
|
|
||
| import React from 'react'; | ||
|
|
||
| const mockSearchQueryContext: {currentSearchKey: SearchKey | undefined} = {currentSearchKey: undefined}; | ||
| jest.mock('@components/Search/SearchContext', () => ({ | ||
| useSearchQueryContext: () => mockSearchQueryContext, | ||
| })); | ||
|
|
||
| jest.mock('@hooks/usePermissions', () => () => ({isBetaEnabled: () => true})); | ||
|
|
||
| jest.mock('@libs/measureTextWidth', () => ({ | ||
| __esModule: true, | ||
| default: (text: string) => text.length * 10, | ||
| canMeasureText: () => true, | ||
| })); | ||
|
|
||
| jest.mock('@components/Table/columnResize/useStoredColumnWidths', () => ({ | ||
| __esModule: true, | ||
| default: jest.fn(() => undefined), | ||
| })); | ||
|
|
||
| const COLUMNS: SearchColumnType[] = [CONST.SEARCH.TABLE_COLUMNS.DATE, CONST.SEARCH.TABLE_COLUMNS.TITLE, CONST.SEARCH.TABLE_COLUMNS.TOTAL]; | ||
|
|
||
| function renderLayoutFor(searchKey: SearchKey) { | ||
| mockSearchQueryContext.currentSearchKey = searchKey; | ||
|
|
||
| render( | ||
| <SearchListViewLayout | ||
| columns={COLUMNS} | ||
| type={CONST.SEARCH.DATA_TYPES.EXPENSE_REPORT} | ||
| isActionColumnWide={false} | ||
| columnSizeOptions={{}} | ||
| isHeaderVisible | ||
| dataKey={undefined} | ||
| isKeyboardShown={false} | ||
| safeAreaPaddingBottomStyle={{}} | ||
| containerStyle={{}} | ||
| data={[]} | ||
| > | ||
| {null} | ||
| </SearchListViewLayout>, | ||
| ); | ||
| } | ||
|
|
||
| describe('SearchListViewLayout', () => { | ||
| beforeEach(() => { | ||
| jest.mocked(useStoredColumnWidths).mockClear(); | ||
| mockSearchQueryContext.currentSearchKey = undefined; | ||
| }); | ||
|
|
||
| it('reads the column widths saved for the current search, not for every search of its data type', () => { | ||
| // Given two searches with the same data type, so their tables show the same columns | ||
| const reportsSearchKey = CONST.SEARCH.SEARCH_KEYS.REPORTS; | ||
| const submitSearchKey = CONST.SEARCH.SEARCH_KEYS.SUBMIT; | ||
|
|
||
| // When the table is rendered for each of them | ||
| renderLayoutFor(reportsSearchKey); | ||
| renderLayoutFor(submitSearchKey); | ||
|
|
||
| // Then each one reads its own widths, so resizing a column on Reports leaves Submit untouched | ||
| expect(useStoredColumnWidths).toHaveBeenCalledWith('search:expense-report:reports'); | ||
| expect(useStoredColumnWidths).toHaveBeenCalledWith('search:expense-report:submit'); | ||
| expect(useStoredColumnWidths).not.toHaveBeenCalledWith('search:expense-report'); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.