Repository navigation
[Home Page] Add Getting started section on Home for invited employees - #106400
adamgrzybowski wants to merge 4 commits into
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
f0df923 to
2908957
Compare
2908957 to
3ac79ed
Compare
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3ac79ed5f9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97c0dd1c8e
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
…t and wait for transactions to load
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index c99407d8..c9478a24 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1179,9 +1179,9 @@ const translations: TranslationDeepObject<typeof en> = {
addFirstReceipt: 'Fügen Sie Ihren ersten Beleg hinzu',
addFirstReceiptSubText: 'Beleg scannen oder manuell eingeben',
addName: 'Fügen Sie Ihren Namen hinzu',
- addNameSubText: 'Helfen Sie Ihrem Team, Sie in Expensify zu erkennen.',
- downloadApp: 'Laden Sie die App herunter',
- downloadAppSubText: 'Belege scannen, Ausgaben einreichen und Berichte unterwegs genehmigen.',
+ addNameSubText: 'Helfen Sie Ihren Teammitgliedern, Sie in Expensify wiederzuerkennen.',
+ downloadApp: 'App herunterladen',
+ downloadAppSubText: 'Belege scannen, Ausgaben einreichen und Berichte unterwegs freigeben.',
},
freeTrialSection: {
title: ({count}: {count: number}) => ({
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 703cf967..a454c1f9 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -1235,10 +1235,10 @@ const translations: TranslationDeepObject<typeof en> = {
setupTravel: 'Ρύθμιση ταξιδιού',
setupTravelSubText: 'Ρύθμιση ειδικών κανόνων για ταξίδια',
addFirstReceipt: 'Προσθέστε την πρώτη σας απόδειξη',
- addFirstReceiptSubText: 'Σαρώστε ή καταχωρίστε χειροκίνητα μια απόδειξη',
+ addFirstReceiptSubText: 'Σαρώστε ή εισαγάγετε χειροκίνητα μια απόδειξη',
addName: 'Προσθέστε το όνομά σας',
addNameSubText: 'Βοηθήστε τους συναδέλφους σας να σας αναγνωρίζουν στο Expensify.',
- downloadApp: 'Κατεβάστε την εφαρμογή',
+ downloadApp: 'Κάντε λήψη της εφαρμογής',
downloadAppSubText: 'Σαρώστε αποδείξεις, υποβάλετε δαπάνες και εγκρίνετε αναφορές όπου κι αν βρίσκεστε.',
},
upcomingTravel: 'Επερχόμενα ταξίδια',
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 8771b9b9..dcc11647 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1179,11 +1179,11 @@ const translations: TranslationDeepObject<typeof en> = {
setupTravel: 'Configurar viajes',
setupTravelSubText: 'Configura reglas específicas de viaje',
addFirstReceipt: 'Añade tu primer recibo',
- addFirstReceiptSubText: 'Escanear o introducir manualmente un recibo',
+ addFirstReceiptSubText: 'Escanea o introduce manualmente un recibo',
addName: 'Añade tu nombre',
addNameSubText: 'Ayuda a tus compañeros de trabajo a reconocerte en Expensify.',
- downloadApp: 'Descarga la app',
- downloadAppSubText: 'Escanea recibos, envía gastos y aprueba informes donde estés.',
+ downloadApp: 'Descarga la aplicación',
+ downloadAppSubText: 'Escanea recibos, envía gastos y aprueba informes desde cualquier lugar.',
},
upcomingTravel: 'Próximos viajes',
upcomingTravelSection: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 044ed5cf..8ede10a9 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1197,11 +1197,11 @@ const translations: TranslationDeepObject<typeof en> = {
setupTravel: 'Configurer les déplacements',
setupTravelSubText: 'Configurer des règles spécifiques aux déplacements',
addFirstReceipt: 'Ajoutez votre premier reçu',
- addFirstReceiptSubText: 'Scanner ou saisir manuellement un reçu',
+ addFirstReceiptSubText: 'Scanner ou saisir un reçu manuellement',
addName: 'Ajoutez votre nom',
addNameSubText: 'Aidez vos coéquipiers à vous reconnaître dans Expensify.',
downloadApp: 'Télécharger l’application',
- downloadAppSubText: 'Scannez des reçus, soumettez des dépenses et approuvez des notes de frais où que vous soyez.',
+ downloadAppSubText: 'Scannez les reçus, soumettez les dépenses et approuvez les notes de frais où que vous soyez.',
},
yourSpend: {
title: 'Vos dépenses',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 3a30eca2..9f3cba19 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1200,7 +1200,7 @@ const translations: TranslationDeepObject<typeof en> = {
addName: 'Aggiungi il tuo nome',
addNameSubText: 'Aiuta i tuoi colleghi a riconoscerti in Expensify.',
downloadApp: 'Scarica l’app',
- downloadAppSubText: 'Scansiona ricevute, invia note spese e approva report ovunque ti trovi.',
+ downloadAppSubText: 'Scannerizza ricevute, invia note spese e approva report ovunque ti trovi.',
},
yourSpend: {
title: 'Le tue spese',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 331a8494..e3b8ef35 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1181,11 +1181,11 @@ const translations: TranslationDeepObject<typeof en> = {
setupTravel: '出張を設定',
setupTravelSubText: '出張用のルールを設定する',
addFirstReceipt: '最初のレシートを追加する',
- addFirstReceiptSubText: 'レシートをスキャンするか手入力します',
- addName: '氏名を追加してください',
+ addFirstReceiptSubText: 'レシートをスキャンまたは手動で入力する',
+ addName: '名前を追加してください',
addNameSubText: 'Expensify でチームメイトにあなたを認識してもらいましょう。',
downloadApp: 'アプリをダウンロード',
- downloadAppSubText: '領収書をスキャンして経費を提出し、外出先でもレポートを承認できます。',
+ downloadAppSubText: 'レシートをスキャンして経費を提出し、どこからでもレポートを承認できます。',
},
yourSpend: {
title: 'あなたの支出',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 76860c2f..77b4e249 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1196,7 +1196,7 @@ const translations: TranslationDeepObject<typeof en> = {
addName: 'Voeg je naam toe',
addNameSubText: 'Help je teamgenoten je in Expensify te herkennen.',
downloadApp: 'Download de app',
- downloadAppSubText: 'Scan bonnetjes, dien uitgaven in en keur rapporten goed, waar je ook bent.',
+ downloadAppSubText: 'Scan bonnen, dien uitgaven in en keur rapporten goed, waar je ook bent.',
},
yourSpend: {
title: 'Je uitgaven',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 87a7b24b..bcd07851 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1219,11 +1219,11 @@ const translations: TranslationDeepObject<typeof en> = {
setupTravel: 'Skonfiguruj podróże',
setupTravelSubText: 'Skonfiguruj zasady dotyczące podróży',
addFirstReceipt: 'Dodaj swój pierwszy paragon',
- addFirstReceiptSubText: 'Zeskanuj lub wprowadź paragon ręcznie',
+ addFirstReceiptSubText: 'Zeskanuj lub wpisz paragon ręcznie',
addName: 'Dodaj swoje imię',
- addNameSubText: 'Pomóż współpracownikom rozpoznać cię w Expensify.',
+ addNameSubText: 'Pomóż swoim współpracownikom rozpoznać cię w Expensify.',
downloadApp: 'Pobierz aplikację',
- downloadAppSubText: 'Skanuj paragony, wysyłaj wydatki i zatwierdzaj raporty w dowolnym miejscu.',
+ downloadAppSubText: 'Skanuj paragony, przesyłaj wydatki i zatwierdzaj raporty w dowolnym miejscu.',
},
yourSpend: {
title: 'Twoje wydatki',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index d2191cd9..e66965a3 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1195,11 +1195,11 @@ const translations: TranslationDeepObject<typeof en> = {
setupTravel: 'Configurar viagem',
setupTravelSubText: 'Configurar regras específicas de viagem',
addFirstReceipt: 'Adicione seu primeiro recibo',
- addFirstReceiptSubText: 'Escaneie ou insira manualmente um recibo',
+ addFirstReceiptSubText: 'Digitalize ou insira um recibo manualmente',
addName: 'Adicione seu nome',
- addNameSubText: 'Ajude seus colegas de equipe a reconhecer você no Expensify.',
+ addNameSubText: 'Ajude seus colegas a reconhecer você no Expensify.',
downloadApp: 'Baixe o app',
- downloadAppSubText: 'Digitalize recibos, envie despesas e aprove relatórios em qualquer lugar.',
+ downloadAppSubText: 'Escaneie recibos, envie despesas e aprove relatórios de onde estiver.',
},
yourSpend: {
title: 'Seus gastos',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index a06dcef5..4a2df97b 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1154,12 +1154,12 @@ const translations: TranslationDeepObject<typeof en> = {
configureApprovalsSubText: '定义报表审批',
setupTravel: '设置差旅',
setupTravelSubText: '配置差旅专用规则',
- addFirstReceipt: '添加您的第一张票据',
+ addFirstReceipt: '添加第一张收据',
addFirstReceiptSubText: '扫描或手动输入收据',
addName: '添加你的姓名',
addNameSubText: '帮助你的队友在 Expensify 中认出你。',
- downloadApp: '下载应用程序',
- downloadAppSubText: '随时随地扫描收据、提交报销并审批报表。',
+ downloadApp: '下载应用',
+ downloadAppSubText: '随时随地扫描票据、提交报销并审批报表。',
},
yourSpend: {title: '您的支出', awaitingApproval: '等待审批', repaidLast30Days: '过去30天已偿还'},
seeMore: ({count}: {count: number}) => `再查看 ${count} 个`,
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
|
@ZhenjaHorbach friendly bump |
|
Will check today! |
|
@adamgrzybowski |
…oyee-getting-started-home # Conflicts: # src/pages/home/GettingStartedSection/hooks/useGettingStartedItems.ts
|
@ZhenjaHorbach done |
Explanation of Change
Getting startedsection with three steps: Add your name, Add your first receipt and Download the app.Fixed Issues
$ #105972
PROPOSAL:
Tests
Offline tests
QA Steps
Getting startedsection shows "Add your name", "Add your first receipt" and "Download the app", with no "Need help?" footer.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
getting-started-employee-demo-v2.mp4