Skip to content

[Home Page] Rename the Getting started expense step to Add your first receipt - #106471

Merged
NicolasBonet merged 8 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/add-first-receipt-getting-started-step
Nov 13, 2026
Merged

NicolasBonet merged 8 commits into
Expensify:mainfrom
software-mansion-labs:@adamgrzybowski/add-first-receipt-getting-started-step

Conversation

@adamgrzybowski

@adamgrzybowski adamgrzybowski commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

  • Users on the Track and Submit intents missed that the Getting started expense step is how they add receipts.
  • The step was "Create an expense" ("Scan, drag and drop, or manually enter an expense using the + button") and only existed for Organize my personal spend. It is now "Add your first receipt" ("Scan or manually enter a receipt") for Organize my personal spend, Track expenses for my company, and Submit to my employer.
  • Clicking it opens the create expense flow on the Scan tab, and it is marked done as soon as the user has any expense, including ones created before this change.

Fixed Issues

$ #105997
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Sign up a new account and onboard with "Organize my personal spending", "Track expenses for my business", or "Submit expenses to my employer", then go to Home.
  2. Verify the Getting started section shows "Add your first receipt" with "Scan or manually enter a receipt", not done. Click Begin and verify the create expense flow opens on the Scan tab.
  3. Create an expense (scan or manual), go back to Home, and verify the step shows Done.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
final.mp4

@melvin-bot

melvin-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@adamgrzybowski adamgrzybowski changed the title Update Create an expense Getting started step to Add your first receipt [Home Page] Rename the Getting started expense step to Add your first receipt Nov 10, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff
diff --git a/src/languages/de.ts b/src/languages/de.ts
index d4075d6b..5f6580f6 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1178,6 +1178,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'Berichtsfreigaben festlegen',
             setupTravel: 'Reisen einrichten',
             setupTravelSubText: 'Reisespezifische Regeln konfigurieren',
+            addFirstReceipt: 'Fügen Sie Ihren ersten Beleg hinzu',
+            addFirstReceiptSubText: 'Beleg scannen oder manuell eingeben',
         },
         freeTrialSection: {
             title: ({count}: {count: number}) => ({
diff --git a/src/languages/el.ts b/src/languages/el.ts
index ba409a10..daaffa02 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -1236,6 +1236,8 @@ const translations: TranslationDeepObject<typeof en> = {
             linkPersonalCardSubText: 'Εισαγάγετε αυτόματα τις δαπάνες',
             setupTravel: 'Ρύθμιση ταξιδιού',
             setupTravelSubText: 'Ρύθμιση ειδικών κανόνων για ταξίδια',
+            addFirstReceipt: 'Προσθέστε την πρώτη σας απόδειξη',
+            addFirstReceiptSubText: 'Σαρώστε ή καταχωρίστε χειροκίνητα μια απόδειξη',
         },
         upcomingTravel: 'Επερχόμενα ταξίδια',
         upcomingTravelSection: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index 37fdf70e..7a54665b 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -1180,6 +1180,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'Definir aprobaciones de informes',
             setupTravel: 'Configurar viajes',
             setupTravelSubText: 'Configura reglas específicas de viaje',
+            addFirstReceipt: 'Añade tu primer recibo',
+            addFirstReceiptSubText: 'Escanear o introducir manualmente un recibo',
         },
         upcomingTravel: 'Próximos viajes',
         upcomingTravelSection: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index d487a103..b5531c95 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1198,6 +1198,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'Définir les approbations de notes de frais',
             setupTravel: 'Configurer les déplacements',
             setupTravelSubText: 'Configurer des règles spécifiques aux déplacements',
+            addFirstReceipt: 'Ajoutez votre premier reçu',
+            addFirstReceiptSubText: 'Scanner ou saisir manuellement un reçu',
         },
         yourSpend: {
             title: 'Vos dépenses',
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 79c3e93c..346ba2a4 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1197,6 +1197,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'Definisci le approvazioni dei report',
             setupTravel: 'Configura viaggi',
             setupTravelSubText: 'Configura regole specifiche per i viaggi',
+            addFirstReceipt: 'Aggiungi la tua prima ricevuta',
+            addFirstReceiptSubText: 'Scansiona o inserisci manualmente una ricevuta',
         },
         yourSpend: {
             title: 'Le tue spese',
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 2eaad98e..a2569e5e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1182,6 +1182,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'レポート承認を定義する',
             setupTravel: '出張を設定',
             setupTravelSubText: '出張用のルールを設定する',
+            addFirstReceipt: '最初のレシートを追加する',
+            addFirstReceiptSubText: 'レシートをスキャンするか手入力します',
         },
         yourSpend: {
             title: 'あなたの支出',
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index fc4e7c40..75c95063 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1193,6 +1193,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'Definieer rapportgoedkeuringen',
             setupTravel: 'Reizen instellen',
             setupTravelSubText: 'Reisspecifieke regels instellen',
+            addFirstReceipt: 'Voeg je eerste bon toe',
+            addFirstReceiptSubText: 'Scan of voer handmatig een bon in',
         },
         yourSpend: {
             title: 'Je uitgaven',
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index df6e36b5..b0c4c432 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1220,6 +1220,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'Zdefiniuj zatwierdzanie raportów',
             setupTravel: 'Skonfiguruj podróże',
             setupTravelSubText: 'Skonfiguruj zasady dotyczące podróży',
+            addFirstReceipt: 'Dodaj swój pierwszy paragon',
+            addFirstReceiptSubText: 'Zeskanuj lub wprowadź paragon ręcznie',
         },
         yourSpend: {
             title: 'Twoje wydatki',
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index eb282b53..71647f0a 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -1196,6 +1196,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: 'Definir aprovações de relatórios',
             setupTravel: 'Configurar viagem',
             setupTravelSubText: 'Configurar regras específicas de viagem',
+            addFirstReceipt: 'Adicione seu primeiro recibo',
+            addFirstReceiptSubText: 'Escaneie ou insira manualmente um recibo',
         },
         yourSpend: {
             title: 'Seus gastos',
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 981594ba..7e5e4732 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1156,6 +1156,8 @@ const translations: TranslationDeepObject<typeof en> = {
             configureApprovalsSubText: '定义报表审批',
             setupTravel: '设置差旅',
             setupTravelSubText: '配置差旅专用规则',
+            addFirstReceipt: '添加您的第一张票据',
+            addFirstReceiptSubText: '扫描或手动输入收据',
         },
         yourSpend: {title: '您的支出', awaitingApproval: '等待审批', repaidLast30Days: '过去30天已偿还'},
         seeMore: ({count}: {count: number}) => `再查看 ${count} 个`,

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

View workflow run

@adamgrzybowski
adamgrzybowski marked this pull request as ready for review November 10, 2026 12:29
@adamgrzybowski
adamgrzybowski requested review from a team as code owners November 10, 2026 12:29
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and removed request for a team November 10, 2026 12:29
@melvin-bot

melvin-bot Bot commented Nov 10, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from flaviadefaria and removed request for a team November 10, 2026 12:29
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-10T12:44:31.487957Z 428ed7c Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@grgia
grgia self-requested a review November 10, 2026 12:31
@flaviadefaria

Copy link
Copy Markdown
Contributor

@adamgrzybowski, just to confirm, if the user creates an expense elsewhere in the product, instead of clicking the Begin button, the task would also get checked off, right?

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@flaviadefaria correct!

@grgia grgia left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NAB

a customer who types "create an expense" in the Search Router no longer sees the Create expense suggestion.

is it intended that createExpense match terms drop the "Create an expense" phrase? swapping in addFirstReceipt adds "receipt" but that phrase stops matching.

@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@grgia Hmm, good catch. I will leave the "Create an expense" in place

grgia
grgia previously approved these changes Nov 12, 2026
@ZhenjaHorbach

ZhenjaHorbach commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-11-13.at.12.00.26.mov
Android: mWeb Chrome
Screen.Recording.2026-11-13.at.12.00.26.mov
iOS: HybridApp
Screen.Recording.2026-11-13.at.11.46.50.mov
iOS: mWeb Safari
Screen.Recording.2026-11-13.at.11.50.23.mov
MacOS: Chrome / Safari
Screen.Recording.2026-11-13.at.11.26.57.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

Minor comment
But after reloading the page with the Create expense modal, we open the Spend flow in the background

Screen.Recording.2026-11-13.at.11.28.22.mov

But the same issue with Inbox flow

Screen.Recording.2026-11-13.at.11.30.22.mov

@ZhenjaHorbach

Copy link
Copy Markdown
Contributor

@adamgrzybowski
Let's fix this
#106471 (comment)

But LGTM

@melvin-bot

melvin-bot Bot commented Nov 13, 2026

Copy link
Copy Markdown

We did not find an internal engineer to review this PR, trying to assign a random engineer to #105997 as well as to this PR... Please reach out for help on Slack if no one gets assigned!

@melvin-bot
melvin-bot Bot requested a review from NicolasBonet November 13, 2026 11:05
@adamgrzybowski

Copy link
Copy Markdown
Contributor Author

@ZhenjaHorbach done!

@NicolasBonet
NicolasBonet merged commit 9542d9e into Expensify:main Nov 13, 2026
40 of 41 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.5.40-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site update needed — this PR renames and expands an onboarding shortcut to the existing receipt-creation flow without making any existing article sentence incorrect.


view run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants