Repository navigation
[Payment due @ZhenjaHorbach] [NO QA][Wise][Business Onboarding][Fix] Open the business details form without a spinner after Get started - #106714
Conversation
…om the intro API.read waits for the sequential write queue to drain, so the two DismissProductTraining writes queued by Get started held the page's OpenReimbursementAccountPage read, and its loader, for two extra round trips. The dismisses now fire from the business details page once the form has rendered on a new visit for an eligible account.
…banners-after-form
The business details page already holds several inline effects for unrelated concerns, so the banner dismissal lives in useDismissWiseGlobalReimbursementsBanners and the page only calls it.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@MonilBhavsar Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a961b4025
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
The business details form waited on OpenReimbursementAccountPage after Get started. The intro page now starts that read while it is in focus and records which bank account it is for, so the form opens on those details and only reads for itself on a direct link or another account. Both reads keep the bank account setup draft. Continue to the status page dismisses the banners again, since only the form dismissed them after the earlier commit.
The action and hook are named after OpenReimbursementAccountPage, and the in-memory key says it holds a bank account ID.
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-11-12.at.19.01.07.movAndroid: mWeb ChromeScreen.Recording.2026-11-12.at.19.01.07.moviOS: HybridAppScreen.Recording.2026-11-12.at.19.01.07.moviOS: mWeb SafariScreen.Recording.2026-11-12.at.19.01.07.movMacOS: Chrome / SafariScreen.Recording.2026-11-12.at.18.59.39.mov |
…t's details The record is set before the request and stays after a failed read, so the form skipped its own read and could open without the business details. It now reads for itself unless the intro's read is still running or the details on the device are for this bank account.
|
Changes look good! |
|
🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
BUG: unable to access in-progress bank account setup on this buildI logged into this Adhoc build in an account that had a bank account that was partway through the Wise onboarding flow. When I tap the "Continue" button to try to continue with the form where I was, the loading screen just hangs, and I'm unable to access the form. I did try in an account that did not have a partially set up bank account, where I started the Wise onboarding experience from the beginning, and it is working as expected there. See below for two comparison videos. Partially setup wise flow2026-11-12_14-26-13.mp4Starting wise flow from beginning2026-11-12_14-33-12.mp4 |
|
Works as expected for me with Partially setup wise flow Screen.Recording.2026-11-12.at.20.49.00.mov |
|
@joekaufmanexpensify found it, thanks for the two videos. That bank account has source of wealth answers saved from the EDD PR yesterday, and |
|
Ah, okay, that makes sense. Nice find. I'll retest with a different account now. 👍 |
|
Yep, confirmed working well in a different account that had an existing partially completed Wise onboarding flow. 👍 2026-11-13_08-25-33.mp4 |
|
🚧 MonilBhavsar has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/MonilBhavsar in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR only improves loading performance within the existing beta-gated Wise onboarding flow, without changing documented steps or releasing the beta. |
Explanation of Change
get-started-main-vs-intro-read.mp4
The business details form for Wise global reimbursements now opens straight after Get started, without a spinner in the usual case.
Get started dismissed the Wallet and Workspace banners before opening the form. The form waits for the business details from
OpenReimbursementAccountPage, and that read was held until both dismissals had finished, one after the other. The intro page now starts that read when it opens, and the banners are dismissed once the form has opened. Dismissing them for good when onboarding starts is deliberate and kept.PREVIOUS COMMIT VIDEO (DISREGARD)
https://github.com/user-attachments/assets/59a50af9-3aa3-44fd-b2a3-9d9e3d3ecde5
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/703270
PROPOSAL:
Tests
Needs the
wiseReimbursementsbeta and a USD business bank account that has not started Wise onboarding.api.OpenReimbursementAccountPageis sent when the intro page opens.OpenReimbursementAccountPageis sent.DismissProductTrainingrequests are sent after the form opens.DismissProductTrainingrequests are sent.OpenReimbursementAccountPageis sent, then the form opens.Offline tests
OpenReimbursementAccountPageto return.QA Steps
Same as tests, on an account with the
wiseReimbursementsbeta.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari