Repository navigation
[Payment due @ZhenjaHorbach] [NO QA][Wise][Business Onboarding][Fix] Open the business details form without a spinner after Get started #106714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+275
−17
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
061c4a7
Dismiss the Wise banners once the business details form opens, not fr…
grgia f3d2fef
Merge remote-tracking branch 'origin/main' into georgia-wise-dismiss-…
grgia 5a961b4
Move the Wise banner dismissal into a named hook
grgia 2837bdf
Read the Wise business details when the intro page opens
grgia 14e8cde
Name the Wise intro read after the command and what the key holds
grgia a91bd00
Reuse the intro's read only while it runs or once it left this accoun…
grgia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| import {dismissWiseGlobalReimbursementsBanners} from '@userActions/WiseOnboarding'; | ||
|
|
||
| import {useEffect} from 'react'; | ||
|
|
||
| /** Dismisses the Wallet and Workspace banners that promote Wise global reimbursements once `shouldDismiss` turns true. */ | ||
| function useDismissWiseGlobalReimbursementsBanners(shouldDismiss: boolean) { | ||
| useEffect(() => { | ||
| if (!shouldDismiss) { | ||
| return; | ||
| } | ||
| dismissWiseGlobalReimbursementsBanners(); | ||
| }, [shouldDismiss]); | ||
| } | ||
|
|
||
| export default useDismissWiseGlobalReimbursementsBanners; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| import {clearWiseIntroReadBankAccountID, openReimbursementAccountPageForWiseIntro} from '@userActions/WiseOnboarding'; | ||
|
|
||
| import {useEffect} from 'react'; | ||
|
|
||
| /** Reads the business details for the Wise onboarding form whenever `shouldRead` turns true, so the form can open without waiting for them. */ | ||
| function useOpenReimbursementAccountPageForWiseIntro(bankAccountID: number, shouldRead: boolean) { | ||
| useEffect(() => { | ||
| if (!shouldRead) { | ||
| return; | ||
| } | ||
| openReimbursementAccountPageForWiseIntro(bankAccountID); | ||
| }, [bankAccountID, shouldRead]); | ||
|
|
||
| useEffect(() => clearWiseIntroReadBankAccountID, []); | ||
| } | ||
|
|
||
| export default useOpenReimbursementAccountPageForWiseIntro; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.