Repository navigation
[Payment due @daledah] Retain tag card parents in Insights Explain - #106908
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@luacmartins please resolve conflict, i'm reviewing this PR |
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / SafariScreen.Recording.2026-11-19.at.23.19.15.mov |
|
🎯 @daledah, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
|
Conflicts @luacmartins |
…-explain-metadata # Conflicts: # src/pages/Insights/ai/InsightsAICard.tsx # tests/ui/InsightsAICardRowTest.tsx
|
@aldo-expensify resolved |
|
🚧 aldo-expensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.5.43-0 🚀
|
|
No help site update needed — this PR fixes tag explanations to use the correct tag level and parent, restoring expected behavior without adding a workflow or making existing article text incorrect. |
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.5.47-0 🚀
|
|
This PR failing with Gmail account because of the issue #107520 |
|
🚀 Deployed to staging by https://github.com/aldo-expensify in version: 9.5.51-0 🚀
|
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.51-1 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #107638 |
Explanation of Change
Use each tag card's level and encoded parent path when sending its Explain request. Keep the shared dashboard scope unchanged and preserve the existing behavior for cards without metadata. This is stacked on #105096. Deploy https://github.com/Expensify/Auth/pull/26689, then https://github.com/Expensify/Web-Expensify/pull/58574, before this change.
Fixed Issues
For https://github.com/Expensify/Expensify/issues/704278
PROPOSAL:
Tests
Top tagsExplain button works correctly for an account with multi-level tagsOffline tests
N/A
QA Steps
same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified the components usingAvatarare working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari