Repository navigation
Render left navigation destinations as real links #106937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JS00001
merged 8 commits into
Expensify:main
from
Krishna2323:krishna2323/105770-sidebar-links
Nov 19, 2026
+402
−16
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2e3acee
Render left navigation destinations as real links
Krishna2323 e85eee2
Address coding standards review on navigation links
Krishna2323 3957abd
Keep sidebar links behind sign-in and disabled state
Krishna2323 ce4076d
Tighten navigation link behavior from review
Krishna2323 9cb26a5
Keep the bold tab label copy out of the link text on web
Krishna2323 f64c1c9
Merge remote-tracking branch 'origin/main' into krishna2323/105770-si…
Krishna2323 4adc54f
Document the tab bar label bold placeholder props
Krishna2323 6f2d882
Merge branch 'main' of https://github.com/Expensify/App into krishna2…
Krishna2323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 changes: 19 additions & 0 deletions
19
src/components/Navigation/NavigationTabBar/TabBarLabelBoldPlaceholder/index.native.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import Text from '@components/Text'; | ||
|
|
||
| import React from 'react'; | ||
|
|
||
| import type TabBarLabelBoldPlaceholderProps from './types'; | ||
|
|
||
| function TabBarLabelBoldPlaceholder({label, numberOfLines, style}: TabBarLabelBoldPlaceholderProps) { | ||
| return ( | ||
| <Text | ||
| aria-hidden | ||
| numberOfLines={numberOfLines} | ||
| style={style} | ||
| > | ||
| {label} | ||
| </Text> | ||
| ); | ||
| } | ||
|
|
||
| export default TabBarLabelBoldPlaceholder; |
23 changes: 23 additions & 0 deletions
23
src/components/Navigation/NavigationTabBar/TabBarLabelBoldPlaceholder/index.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import Text from '@components/Text'; | ||
|
|
||
| import CONST from '@src/CONST'; | ||
|
|
||
| import React from 'react'; | ||
|
|
||
| import type TabBarLabelBoldPlaceholderProps from './types'; | ||
|
|
||
| /** The label is drawn by a CSS pseudo-element, so it stays out of the text a browser takes when the tab link is dragged or copied. */ | ||
| function TabBarLabelBoldPlaceholder({label, numberOfLines, style}: TabBarLabelBoldPlaceholderProps) { | ||
| return ( | ||
| <Text | ||
| aria-hidden | ||
| numberOfLines={numberOfLines} | ||
| style={style} | ||
| dataSet={{[CONST.TAB_BAR_LABEL_BOLD_PLACEHOLDER]: label}} | ||
| > | ||
| {null} | ||
| </Text> | ||
| ); | ||
| } | ||
|
|
||
| export default TabBarLabelBoldPlaceholder; |
14 changes: 14 additions & 0 deletions
14
src/components/Navigation/NavigationTabBar/TabBarLabelBoldPlaceholder/types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| import type {StyleProp, TextStyle} from 'react-native'; | ||
|
|
||
| type TabBarLabelBoldPlaceholderProps = { | ||
| /** Tab label whose bold width is reserved. On web it goes in a data attribute instead of the text, so it stays out of the link text */ | ||
| label: string; | ||
|
|
||
| /** Number of lines the visible label is limited to */ | ||
| numberOfLines: number; | ||
|
|
||
| /** Style of the visible label in bold, so the placeholder takes the same width */ | ||
| style: StyleProp<TextStyle>; | ||
| }; | ||
|
Krishna2323 marked this conversation as resolved.
Resolved
|
||
|
|
||
| export default TabBarLabelBoldPlaceholderProps; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.