Skip to content

[NO QA] Merge duplicate usePaymentOptions test files to fix lint on main - #107148

Merged
blimpich merged 1 commit into
mainfrom
blimpich-fixDuplicateUsePaymentOptionsTest
Nov 17, 2026
Merged

blimpich merged 1 commit into
mainfrom
blimpich-fixDuplicateUsePaymentOptionsTest

Conversation

@blimpich

@blimpich blimpich commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The lint check on main has been failing since two PRs merged on the same day that each added a test file for the payment options hook: one named usePaymentOptions.test.ts and one named usePaymentOptions.test.tsx. When two files differ only by that extension, TypeScript loads just the .ts one. The lint check therefore had no type information for the .tsx file and flagged almost every line in it. This PR moves the two invoice tests into the existing .ts file, rewrites them to use real Onyx data like the rest of that file, and deletes the duplicate.

Fixed Issues

$ #107145
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A, this only changes unit tests.

QA Steps

N/A, this only changes unit tests.

  • Verify that no errors appear in the JS console

@blimpich
blimpich requested a review from a team as a code owner November 17, 2026 17:49
@blimpich blimpich self-assigned this Nov 17, 2026
@expensify-chore-bot
expensify-chore-bot Bot requested review from sobitneupane and removed request for a team November 17, 2026 17:49
@expensify-chore-bot

Copy link
Copy Markdown

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T18:01:16.360246Z 18ec786 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@blimpich
blimpich merged commit 63a47c8 into main Nov 17, 2026
36 of 37 checks passed
@blimpich
blimpich deleted the blimpich-fixDuplicateUsePaymentOptionsTest branch November 17, 2026 17:57
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.41-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants