Repository navigation
[NO QA] Merge duplicate usePaymentOptions test files to fix lint on main - #107148
Merged
Merged
Conversation
expensify-chore-bot
Bot
requested review from
sobitneupane
and removed request for
a team
November 17, 2026 17:49
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 17, 2026
NicolasBonet
approved these changes
Nov 17, 2026
chuckdries
approved these changes
Nov 17, 2026
Contributor
|
🚀 Deployed to staging by https://github.com/blimpich in version: 9.5.41-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.5.41-2 🚀
Bundle Size Analysis (Sentry): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The lint check on main has been failing since two PRs merged on the same day that each added a test file for the payment options hook: one named
usePaymentOptions.test.tsand one namedusePaymentOptions.test.tsx. When two files differ only by that extension, TypeScript loads just the.tsone. The lint check therefore had no type information for the.tsxfile and flagged almost every line in it. This PR moves the two invoice tests into the existing.tsfile, rewrites them to use real Onyx data like the rest of that file, and deletes the duplicate.Fixed Issues
$ #107145
PROPOSAL:
Tests
Offline tests
N/A, this only changes unit tests.
QA Steps
N/A, this only changes unit tests.