Repository navigation
fix regex for debit card name - #21880
PauloGasparSv merged 3 commits into
Conversation
|
@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@narefyev91 @PauloGasparSv I have created the PR but haven't completed the PR author checklist since I wanted to confirm a few small details first -
Should we use the same error messages as well? |
I was also worried that the
Great catch, yes! Can you please update that error message so it matches that other one and reflects the new validation rules for that field?
Since that behavior also happens with the Legal Name field and since that data will be validated by a bunch of other Bank related API's I think it's ok to leave it like that. @Nikhil-Vats @narefyev91 LMK if you disagree with anything here |
|
@PauloGasparSv I agree with all your comments, updated the code as per your suggestions. |
|
@narefyev91 PR is ready for review. |
Reviewer Checklist
Screenshots/VideosWebweb.movMobile Web - Chromeandroid-web.movMobile Web - Safariios-web.movDesktopdesktop.moviOSios.movAndroidandroid.mov |
narefyev91
left a comment
There was a problem hiding this comment.
LGTM!
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/PauloGasparSv in version: 1.3.36-0 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.36-5 🚀
|


























Details
Fix regex for card name in add debit card form.
Fixed Issues
$ #21255
$ #21255 (comment)
Tests
Offline tests
Same as above.
QA Steps
Same as above.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
21255_chrome.mov
Mobile Web - Chrome
21255_mweb_chrome.mov
Mobile Web - Safari
21255_mweb_safari.mov
Desktop
21255_desktop.mov
iOS
21255_ios.mov
Android
21255_android.mov