Skip to content

Deploy Checklist: New Expensify 2023-07-03 #22116

Closed

Description

@OSBotify

Release Version: 1.3.36-4
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. self-assigned this
    on Jul 3, 2023
  2. Julesssss commented on Jul 3, 2023

    @Julesssss
    Contributor

    Hey @mvtglobally, there was one small issue with the iOS build and checklist generation. It seems okay now, but let me know if you see anything odd!

  3. OSBotify commented on Jul 3, 2023

    @OSBotify
    ContributorAuthor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.36-1 🚀

  4. Li357 commented on Jul 3, 2023

    @Li357
    Contributor

    Fix for #22123 is here: #22132

  5. dangrous commented on Jul 3, 2023

    @dangrous
    Contributor

    Fix for #22130 is in review - #22135

    EDIT: It pleases me how close together these numbers are

  6. Julesssss commented on Jul 4, 2023

    @Julesssss
    Contributor

    I'm not sure why the description wasn't updated, but a fix Cp has bumped the current version to 1.3.36-2

  7. Julesssss commented on Jul 4, 2023

    @Julesssss
    Contributor

    I cherry-picked the fixes for the remaining blockers.

    Were now on 1.3.36-4 -- I'll manually update it now

  8. Julesssss commented on Jul 4, 2023

    @Julesssss
    Contributor

    I have to sign off, and plan to deploy early tomorrow morning to give Applause plenty of time to work on the follow-up release checklist

  9. mvtglobally commented on Jul 4, 2023

    @mvtglobally

    PR #21557 is failing #21952
    PR #21700 is failing #22175. Repro in prod

  10. mvtglobally commented on Jul 4, 2023

    @mvtglobally

    @Julesssss can you pls confirm what CPs were added for us to validate? I am not seeing the checklist updated with new PRs

  11. mvtglobally commented on Jul 5, 2023

    @mvtglobally

    @Julesssss Regression is completed

    #22135 - Pass
    #22132 - Pass

    PR #21557 is failing #21952
    PR #21662 is failing #21662. repro in PROD, checking off
    PR #21834 (comment). Can you check it internally?
    PR #21895 is failing #22234. Repro in PROD

  12. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor

    Checked off the above items, and verified #21834 manually

  13. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor
  14. mvtglobally commented on Jul 5, 2023

    @mvtglobally

    @Julesssss We have to re-test one of the TCs on Android. Will update in a few min once the retest is completed

  15. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor

    No problem. I'll be back online in about 45 mins

  16. mvtglobally commented on Jul 5, 2023

    @mvtglobally

    @Julesssss We are done, no new blockers, so we are good to proceed

  17. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor

    Perfect. Thanks!

  18. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor

    Checked off #22258 after deploying the fix. @mvtglobally in order to release I'm going to verify myself, FYI

  19. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor
    • The final blocker is merged and has been tested against an AdHoc build (arguable it's not even worth blocking over)
    • timing looking good
    • raised an unrelated OldDot crash here
    • Single instance of a new ANR
    • One non-fatal iOS issue here
    • Github is up
  20. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor
  21. Julesssss commented on Jul 5, 2023

    @Julesssss
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions