Repository navigation
feat: Migrate LHNTestUtils.js to function component - #21939
Merged
srikarparsi merged 1 commit intoJul 3, 2023
Merged
Conversation
melvin-bot
Bot
requested review from
rushatgabhane and
shawnborton
and removed request for
a team
June 30, 2023 10:51
|
@shawnborton @rushatgabhane One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
1 task
rushatgabhane
approved these changes
Jun 30, 2023
Contributor
|
Hi @rushatgabhane! Could you please complete the reviewer checklist whenever you get a chance? |
Member
Reviewer Checklist
Screenshots/VideosWebMobile Web - ChromeMobile Web - SafariDesktopiOSAndroid |
Member
|
@srikarparsi completed. no screenshots because we're modifying the test. And npm run test is already successful in the GH workflow |
rushatgabhane
approved these changes
Jul 3, 2023
srikarparsi
approved these changes
Jul 3, 2023
srikarparsi
left a comment
Contributor
There was a problem hiding this comment.
looks good to me as well
40 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.36-1 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.36-5 🚀
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #16313
PROPOSAL: #16313 (comment)
Tests
npm run teston local dev to ensure that no tests are being failOffline tests
N/A
QA Steps
QA Steps will not be applicable here, need to test the changes on the local dev
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
web.mov
Mobile Web - Chrome
mWeb-chrome.mp4
Mobile Web - Safari
mWeb-safari.mov
Desktop
desktop.mov
iOS
iOS.mov
Android
Android.mp4