Repository navigation
Fix expand button won't show if composer contains only new lines/spaces - #28512
Conversation
|
@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
We currently have an issue on mWeb where we are unable to add new lines. |
|
@bernhardoj The issue mentioned is closed citing not reproducible. |
|
Maybe it's fixed in the latest ver, I will check it later. |
|
I can still reproduce it. I have commented on that issue. |
|
@bernhardoj Any way to unblock this PR from that issue? |
|
@abdulrahuman5196 I think the only way is to revert the offending PR locally, but QA still needs to wait for that issue to be solved I guess. |
|
@abdulrahuman5196 I reverted it locally and added the missing recordings. |
|
@abdulrahuman5196 you can also apply the solution I posted there |
|
Thank you will check on this PR now |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-10-02.at.4.20.12.PM.mp4Mobile Web - Chromeaz_recorder_20231002_164545.mp4Mobile Web - SafariScreen.Recording.2023-10-02.at.4.34.56.PM.mp4DesktopScreen.Recording.2023-10-02.at.4.57.10.PM.mp4iOSScreen.Recording.2023-10-02.at.4.47.34.PM.mp4AndroidScreen.Recording.2023-10-02.at.4.51.08.PM.mp4 |
abdulrahuman5196
left a comment
There was a problem hiding this comment.
Changes looks good and works well. Reviewers checklist is also complete.
All yours. @marcaaron
🎀 👀 🎀
C+ Reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.3.77-7 🚀
|
Details
The composer expand button won't show if the composer contains only new lines/spaces
Fixed Issues
$ #28093
PROPOSAL: #28093 (comment)
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Web
Screen.Recording.2023-09-30.at.00.30.19.mov
Mobile Web - Chrome
Screen.Recording.2023-10-02.at.15.44.20.mov
Mobile Web - Safari
Screen.Recording.2023-10-02.at.15.43.28.mov
Desktop
Screen.Recording.2023-09-30.at.00.30.44.mov
iOS
Screen.Recording.2023-09-30.at.00.31.21.mov
Android
Screen.Recording.2023-09-30.at.00.31.43.mov