Repository navigation
Restrict room rename for Task - #30886
Conversation
| * @param {Object|null} policy - the workspace the report is on, null if the user isn't a member of the workspace | ||
| * @returns {Boolean} | ||
| */ | ||
| function canEditWriteCapability(report, policy) { |
There was a problem hiding this comment.
Why are we modifying the write capability conditions? Is this relevant to the issue?
There was a problem hiding this comment.
@Ollyws I included it in my proposal and it is modified to have consistency as it is not shown for normal tasks
There was a problem hiding this comment.
Ahh I see. Makes sense, thanks.
Reviewer Checklist
Screenshots/VideosAndroid: Native01_Android_Native.mp4Android: mWeb Chrome02_Android_Chrome.mp4iOS: Native03_iOS_Native.mp4iOS: mWeb Safari04_iOS_Safari.mp4MacOS: Chrome / Safari05_MacOS_Chrome.mp4MacOS: Desktop06_MacOS_Desktop.mp4 |
|
@esh-g We have some merge conflicts if you could take a look, thanks! |
|
@Ollyws Fixed the conflict! |
Ollyws
left a comment
There was a problem hiding this comment.
Just to be clear this PR will disable room rename and write capability editing in the settings of any thread.
LGTM.
| * @param {Object|null} policy - the workspace the report is on, null if the user isn't a member of the workspace | ||
| * @returns {Boolean} | ||
| */ | ||
| function canEditWriteCapability(report, policy) { |
There was a problem hiding this comment.
Does the API already check for this? Or are we only checking this on the front end?
There was a problem hiding this comment.
It seems to be determined by the front end, I can seemingly change the write-capability for a workspace room that I'm not admin of if I change the front-end to allow it.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.4.2-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀
|
Details
this PR will disable room rename and write capability editing in the settings of any thread (including tasks especially)
Fixed Issues
$ #30001
PROPOSAL: #30001 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2023-11-04.at.9.59.19.PM.mov
Android: mWeb Chrome
Screen.Recording.2023-11-04.at.10.53.04.PM.mov
iOS: Native
Screen.Recording.2023-11-04.at.11.00.18.PM.mov
iOS: mWeb Safari
Screen.Recording.2023-11-04.at.11.04.10.PM.mov
MacOS: Chrome / Safari
Screen.Recording.2023-11-04.at.9.41.50.PM.mov
MacOS: Desktop
Screen.Recording.2023-11-04.at.11.01.44.PM.mov