Skip to content

Deploy Checklist: New Expensify 2023-11-22 #31667

Closed

Description

@github-actions

Release Version: 1.4.2-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

Activity

  1. melvin-bot commented on Nov 22, 2023

    @melvin-bot

    📣 @github-actions[bot]! 📣
    Please report bugs or suggest features in the #expensify-open-source Slack channel, don't directly open issues in this repo!
    Instructions here to join the channel 📖

  2. os-botify commented on Nov 22, 2023

    @os-botify

    Sorry, only members of @Expensify/Mobile-Deployers can close deploy checklists.
    Reopening!

  3. melvin-bot commented on Nov 22, 2023

    @melvin-bot
  4. OSBotify commented on Nov 22, 2023

    @OSBotify
    Contributor

    🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.4.2-0 🚀

  5. mountiny commented on Nov 22, 2023

    @mountiny
    Contributor

    Btw, made a PR to fix this issue with the checklist being closed upon creation https://github.com/Expensify/Web-Expensify/pull/39805

  6. kavimuru commented on Nov 22, 2023

    @kavimuru

    Regression is 24% progress

    #31517 is blocked in Desktop and intended as per this comment #25790 (comment) and checking it off.
    #31545 failing with #31707

  7. Julesssss commented on Nov 22, 2023

    @Julesssss
    Contributor

    @luacmartins blocker #31688 is about to be resolved here, but I might be out for the day by then. Would you mind keeping an eye on the fix and CPing it?

  8. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Checking off #31688. Demoted to NAB since it's a navigation wide issue that affects App on reloading a page and it's not that sensitive.

  9. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Checking off #31704. Demoted to NAB.

  10. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Checking off #31725 and #31734. We reverted the offending PR

  11. 6 remaining items

  12. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    @mvtglobally checking off #27670, since we reverted the PR

  13. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Checking off #31738 and #31743, tested in staging and related blockers are no longer reproducible

  14. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Checking off #31287. We merged a fix.

  15. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Checking off #31294. The type error no longer happens, but we hit another KI.

  16. luacmartins commented on Nov 22, 2023

    @luacmartins
    Contributor

    Checking off #31545. This is intended for now since we reverted the PR that introduced the skeleton, but just merged the PR that reintroduces it today.

  17. kavimuru commented on Nov 22, 2023

    @kavimuru

    Regression is just 3 steps left

    #28453 failing with #31757

  18. luacmartins commented on Nov 23, 2023

    @luacmartins
    Contributor

    Checked off #31760. Demoted to NAB

  19. kavimuru commented on Nov 23, 2023

    @kavimuru

    Regression is completed.

    Unchecked PR:

    #28453 failing with #31757

  20. luacmartins commented on Nov 23, 2023

    @luacmartins
    Contributor

    Checking off #31763. We CPed a fix.

  21. luacmartins commented on Nov 23, 2023

    @luacmartins
    Contributor

    Checking off #28453, since the feature is still WIP and it doesn't break any functionality.

  22. self-assigned this
    on Nov 23, 2023
  23. luacmartins commented on Nov 23, 2023

    @luacmartins
    Contributor

    Checklist is clear. Kicking off the deploy.

  24. luacmartins commented on Nov 23, 2023

    @luacmartins
    Contributor

    :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions