Repository navigation
Conversation
|
This is resolved. |
| titleStyle={styles.flex1} | ||
| disabled={didConfirm} | ||
| interactive={!props.isReadOnly} | ||
| rightLabel={Permissions.canUseViolations() && Boolean(props.policy.requiresCategory) ? translate('common.required') : ''} |
There was a problem hiding this comment.
Everything looks good, but I need to make sure we're setting requiresCategory and requiresTag in the policy object in Onyx
There was a problem hiding this comment.
@cead22 is that something to be addressed here or in a separate issue?
There was a problem hiding this comment.
I confirmed this is how this is supposed to be 👍
There was a problem hiding this comment.
@cead22 just following up here. I'm rewriting the testing instructions and I've set the proper requirements in old Dot to have categories and tags be required, however I'm not seeing requiresTags or requiresCategories coming through anywhere on the props from Onyx, in the policy object or otherwise. props.policyTags.Tag.required comes through correctly but that's it.
There was a problem hiding this comment.
Yeah that's fine, maybe we can skip QA steps that depend on those values being true for now, since the backend change for that isn't ready yet
There was a problem hiding this comment.
Alright @cead22, I updated the test cases and made a note in the QA section that links to this thread.
|
@cdanwards can you update your tests and QA sections
|
|
@shawnborton can you please take a look and see if we need different styles on the |
|
Hi @cead22, I need to test another relatively complex modal refocusing issue first. Could you please un-assign me here or assign another C+ if needed? 😄 |
|
Yup, we do need some style adjustments. The text should be using our textSupporting color, and it should be in our label font size (13px). |
|
@cdanwards after pulling main, app crashes
|
|
@situchan thanks for the review! I'll get it updated. |
…ions/required-confirmation-list
Reviewer Checklist
Screenshots/VideosiOS: Nativeios.moviOS: mWeb Safarimsafari.movMacOS: Chrome / Safariweb.movMacOS: Desktopdesktop.mov |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cead22 in version: 1.4.2-0 🚀
|
|
Hello @cdanwards, can you please help us, where I can set the |
|
@izarutskaya apologies! If you're able to access the |
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀
|



Details
Fixed Issues
$ #31090
PROPOSAL:
Tests
Configuring Categories and Tags in Old Dot
For Categories:
Settings > Workspaces > [the workspace] > Categories.For Tags:
Settings > Workspaces > [the workspace] > Tags.Test Steps
General Steps:
canUseViolationsPermissions to true within thePermissionsfile.Case 1: Neither Categories nor Tags Required
Requiredtag.Case 2: Both Categories and Tags Required
Requiredtag.Case 3: Only Categories Required
Requiredtag and Tags do not.Case 4: Only Tags Required
Requiredtag and Categories do not.Additional Steps for Forced Requirement Display
MoneyRequestConfirmationList, setshouldShowTagsandshouldShowCategoriesto true.Boolean(props.policy.requiresCategories)andBoolean(props.policy.requiresTags)to true. Note: This will cause an error if not implemented correctly due to normal guards being disabled.Offline tests
Same as Tests
QA Steps
QA should be skipped for now: see here
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop