Repository navigation
fix 29852 - #31046
fix 29852#31046marcochavezf merged 3 commits into
Conversation
|
PR ready for review @Ollyws |
| } | ||
|
|
||
| result.text = reportName; | ||
| result.text = reportName || LocalePhoneNumber.formatPhoneNumber(personalDetail.login); |
There was a problem hiding this comment.
Seeing as this only applies to the display name, wouldn't it be better if we applied it only to this line?
There was a problem hiding this comment.
Yes, that works.
We can use here this
reportName = ReportUtils.getDisplayNameForParticipant(accountIDs[0]) || LocalePhoneNumber.formatPhoneNumber(personalDetail.login);We cannot wrap the ReportUtils.getDisplayNameForParticipant(accountIDs[0]) with LocalePhoneNumber(formatPhoneNumber directly because the personal details for this accountID are not merged to Onyx and this here returns ''
Reviewer Checklist
Screenshots/Videos |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/marcochavezf in version: 1.4.2-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.2-3 🚀
|






Details
Fixed Issues
$ #29852
PROPOSAL: #29852 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)/** comment above it */thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
countryCodeAndroidNative.mov
Android: mWeb Chrome
countryCodeAndroidChrome.mov
iOS: Native
countryCodeiOSNative.mov
iOS: mWeb Safari
countryCodeiOSSafari.mov
MacOS: Chrome / Safari
countryCodeWebChrome.mov
MacOS: Desktop
countryCodeDesktop.mov