Repository navigation
Release profiler - #36414
Release profiler#36414
Conversation
|
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
I can help if requires C+ review |
|
Hi, yes that would be great thanks @situchan |
situchan
left a comment
There was a problem hiding this comment.
I see you marked as draft. Please request my review when ready. Thanks
yes, I already confirmed in adhoc build |
@situchan, with |
|
@situchan @srikarparsi, if it tested well, when can we expect to get this merged? |
🟢 from me |
|
Changes look good to me as well, waiting on confirmation about adding new modules to package.json before merging. |
|
Hey @situchan and @hoangzinh, we have to get approval before adding libraries to package.json so I created two new issues for the two packages, react-native-share and react-native-release-profiler. react-native-share - @situchan or @hoangzinh could you please help with the last three questions. You can leave a comment in the GH issue and I can update the body. react-native-release-profiler - @situchan or @hoangzinh could you please help with the last four questions as well as the number of monthly downloads. Thanks! |
|
@srikarparsi I've added some comments to the issues above. I hope it will help push it forward |
|
Hey! Could someone clarify why we're using react-native-share instead of the regular share from react native? |
|
We're using |
|
@srikarparsi, any updates on this? Can I somehow push it forward? |
|
@srikarparsi added my comments |
| urls: [`file://${sharePath}`, actualInfoFile], | ||
| }; | ||
|
|
||
| await Share.open(shareOptions); |
There was a problem hiding this comment.
can you explain what this line does? Does it just open the native file in the default browser?
There was a problem hiding this comment.
oh, I see. This is opening the native share menu so you can do whatever you want with the file:
- save it to the filesystem
- email it
- send it in slack
- print it
- whatever else
|
Awesome thanks @perunt! Also, do you think you could fix the conflicts whenever you get a chance. I think we should get approval for |
|
@srikarparsi done. |
|
Hey @perunt, we're still waiting on approval for react-native-share. We can merge as soon as that's done, hopefully today or tomorrow. |
srikarparsi
left a comment
There was a problem hiding this comment.
lgtm, also got approval for both libraries being added
|
@srikarparsi looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.4.50-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.4.50-5 🚀
|
| <TestToolMenu /> | ||
| <View style={[StyleUtils.getTestToolsModalStyle(windowWidth)]}> | ||
| {isDevelopment && <TestToolMenu />} | ||
| <ProfilingToolMenu /> |

Usually performance issues are profiled in debug builds, which could lead to false positives (e.g. JS Garbage Collectors, Hermes-specific debug markers, or other LLDB hangs).
react-native-release-profiler allows you to profile your app in release builds, both in a local environment to profile specific issues, as well as in a production environment to spot regressions or collect performance samples from a wider variety of user devices.
This menu should be available in production. That's why I removed
isDevelopmentchecks fromsrc/components/TestToolsModal.tsxAfter you've captured the performance trace, you can download and process it from your phone to your PC
On Android:
npx react-native-release-profiler --fromDownload --appId <your appId>On IOS:
npx react-native-release-profiler --local <path to profile>Also, after capturing metrics, you are able to share them. In the sharing process, you would see two files
Details
Fixed Issues
$ https://expensify.slack.com/archives/C05LX9D6E07/p1707759274500039?thread_ts=1707758148.919829&cid=C05LX9D6E07
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodWaiting for Copylabel for a copy review on the original GH to get the correct copy.STYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel so the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
2024-02-13.16.10.16.mp4
Android: mWeb Chrome
iOS: Native
RPReplay_Final1707834726.MP4
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop