Repository navigation
[NoQA] Add orderWeight to tag view and tag edit routes - #42149
hayata-suenaga merged 3 commits into
Conversation
|
Adding NoQA because this PR is not fully testable yet and requires API commands to be added first namely the one to enable/disable tags and to rename tags. |
|
@s77rt @hayata-suenaga do we need a c+ review here? |
|
@s77rt, could you make a PR against this branch -> https://github.com/Expensify/App/tree/qbo-freeze-branch? 🙇 |
|
Done! |
|
Thank you! |
[NoQA] Add orderWeight to tag view and tag edit routes
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.77-11 🚀
|
|
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.4.77-11 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.78-5 🚀
|
|
🚀 Deployed to production by https://github.com/Julesssss in version: 1.4.79-11 🚀
|
Details
Fixed Issues
$ #42056
PROPOSAL:
Tests
Preconditions:
Offline tests
Same as Tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.mov
Android: mWeb Chrome
Networking issue
iOS: Native
ios.mov
iOS: mWeb Safari
mweb-safari.mov
MacOS: Chrome / Safari
web.mov
MacOS: Desktop
desktop.mov