Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 1.4.79-11
Compare Changes: production...staging
This release contains changes from the following pull requests:
- Login via deeplink should open modal in request money #31529
- fix Reddot pinned chat appears for approver after failed scanned #39970
- IOU - RBR is present in LHN with transaction thread #40460
- fix add center button and blue dot #40759
- Allow system account chat to be listed in LHN, fix chat icons #41290
- Last synced just now does not update #41310
- Update RequestStepCategory to add Empty and Loading states for category list #41344
- Fix composer isn't auto focused when click reply in a thread #41402
- fix: Pay someone - Add receipt placeholder is shown when receipt is not allowed when paying someone #41635
- Prevent invalid configuration between location and JE selection #41638
- Add offline status log #41719
- Move Leave button into a row of the Report Details page #41823
- GBR and Settlement button for the receiver on the invoice report preview #41859
- Fix: display joined public rooms in search results #41865
- Prevent the user from requiring tags when there is no active tag #42004
- Fix: ws options available from all devices for same user #42008
- Send invoice - workspace list should be in alphabetical order #42048
- Redirect user to concierge when onboarding completed #42087
- [NoQA] Add orderWeight to tag view and tag edit routes #42149
- feat: add Down Caret to Report Titles #42154
- Add HybridApp deploy when we deploy staging #42166
- Receipts are displayed in the full size of canvas when not needed #42174
- Add canned searches #42184
- feat: update ProfilePage #42188
- Delay in removing mention list when pressing CMD+K #42255
- Display blocking view and remove download button when user have no access to the report #42312
- Enable / Disable multi level tags #42315
- Clear search input in multiple selection list #42336
- Fix: Split menu RHP header does not show the updated scanning message #42338
- Combine report name routes #42369
- [phase2] fix delete modal flicker #42423
- fix: remove redundant slash in path #42465
- Add cancel function when you select an option in search and navigate away from the optionList #42471
- Fix: display last message when searching for the rooms #42476
- add optional chaining #42502
- fix user is not prompted with a warning message when leaving group #42512
- Fix left modal navigator weird navigation animation #42517
- perf: Optimize AppNavigator #42532
- QBO freeze branch #42543
- QBO: Add explicit description for each export entity #42548
- SelectionList: Added listEmptyContent prop + QBO: Added an illustration for empty lists (when there is no accounts found) #42561
- fix Unread message marker disappeared for next message #42568
- FIX the logic to check if there is an accounting connection in the workspace #42613
- fix: Transaction report shows multiline title for expense with multiline description #42631
- Chore: Update eslint-config-expensify to 2.0.49 #42650
- feat: Payment card subscription size screen UI #42683
- [Payment card / Subscription] Implement “Your plan” section (UI) #42690
- Put self DM at the top of search result #42704
- Fix: navigate to invite list by arrow keys #42713
- Delete docs/articles/new-expensify/chat/Expensify-Chat-For-Admins.md #42717
- Updated required condition #42731
- fix: Default vendor toggle switch activation is delayed #42732
- Add bottom margin below header in Onfido step #42746
- Fix normal Profile Page displayed for invalid accountID #42769
- [Fix]: Inconsistency with task subtitle view with other report types #42791
- fix: empty ui does not show when deleting all tags #42810
- Fix: intercept mouse selection when out of input field #42823
- Update Upgrade-to-the-new-Expensify-Card-from-Visa.md #42855
- [No QA] Improve documentation on testing Google Sign-In on desktop #42857
- [VIP][Travel] Add book travel demo button #42864
- Remove deprecated
CompleteEngagementModalAPI command call and associated logic #42873 - Fix linter error on
main#42878 - Disable tax deletion if connected to accounting #42881
- Remove outdated conditions #42883
- [Wave Collect] [Xero] Don't show error while syncing #42899
- Fix distance tax rate and amount not updating offline and inaccurate tax amount and refactor code #42909
- [Wave Collect] [Xero] Remove text jitter for More Features modal #42919
- Fix entity select page footer styles #42921
- Pass configUpdate correctly to onyx #42929
- [NoQA] Adding babel to the default plugins #42964
- [Fix]: Saving tax name without altering displays error message #42966
- [HelpDot] choose a platform by default #42983
- Fix rendering TransactionListItemRow #42986
- [NoQA] fix: e2e long loading #42991
- Fix InitialUrlContextProvider for HybridApp #2 #42997
- [No QA] Temporarily disable queries that are not implemented yet #43016
- [CP Staging] Revert "Add HybridApp deploy when we deploy staging" #43035
- Add HybridApp deploy to platform deploy #43046
- [CP staging] Fix system chat participant count #43054
- [CP Staging] Search bottom-up if a component is in a narrow modal navigator #43074
- Revert "Add HybridApp deploy to platform deploy" #43078
- Add gh cli call to deploy of HybridApp when we deploy staging NewExpensify #43080
- [CP Staging] Update
SendInvoiceParamstyping #43095 - fixes the "Unable to remove stop from the route" #43112 #43147
- [No QA] Commit Podfile.lock diff #43150
Deploy Blockers:
- [HOLD for payment 2024-06-20] Group chat - Member amount is 0 when creating group chat offline #43042
- Android & iOS - Profile - Default avatar is small when viewed in full screen #43050
- Profile - 2 options instead of 4 to pick in Troubleshoot > New search page #43051
- [$250] Log out - URL in sign in page is ../settings/troubleshoot after logging out #43057
- [HOLD for payment 2024-06-28] [$250] Distance - "Center" button has no hover and press effect #43058
- [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] send invoice-Unexpected error shown while sending invoice #43060
- [HOLD for payment 2024-06-28] [$250] Web - Categorizing - Offline indicator appears in Edit categories RHP on web layout #43062
- [HOLD for payment 2024-06-28] [$250] Web - Categorizing - Folder icon in empty state screen is not centered #43064
- [HOLD #21219][$250] Android - Group - Inconsistency in showing group name in header in mweb & Android #43068
- [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] Subscription size value not trim able to add spaces before the value #43069
- [$250] Track Expense - Hmm..not here page on selecting category with no existing workspace #43073
- [HOLD for payment 2024-06-20] [Payment card / Subscription] Subscription size "Save" button has no margin #43075
- [HOLD for payment 2024-07-10] [HOLD for payment 2024-07-02] [$125] Expense - "Receipt" label does not appear above receipt placeholder for p2p expense #43076
- [$250] Track Expense - Hmm not here page & user not redirected to new WS chat on submitting expense #43096
- Distance tax - Tax amount is zero when selecting a distance rate on confirmation page #43111
- [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [HOLD for payment 2024-06-13] [$250] Distance - Unable to remove stop from the route #43112
- [HOLD for payment 2024-07-10] [$250] Distance - Blue dot does not set to current location after enabling location access #43113
- [HOLD for payment 2024-06-28] [HOLD for payment 2024-06-24] [$250] iOS - System chat - Chat with your setup specialist message not aligned and gets out of box #43115
- [HOLD for payment 2024-06-20] Troubleshoot - App is stuck offline after "Force offline" toggled on and off #43116
- QBO - Location switch button hint text is not as expected #43119
- [$250] Workspace - Account title is not displaying on Export out-of-pocket expenses as #43130
- [$250] Mention - User profile shows the old UI when clicking on user mention after sending it #43131
- Send invoice - Incomplete options on payment button when sending an invoice #43145
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
amyevans commentedon Jun 4, 2024
Demoted #43075
amyevans commentedon Jun 4, 2024
Demoted #43069 as well
tgolen commentedon Jun 4, 2024
Demoted #43057
aldo-expensify commentedon Jun 4, 2024
Checked #43042 off (QA: #43054 (comment))
blimpich commentedon Jun 4, 2024
Demoting #43073 since it no longer is reproducible on staging or on my local. Asked QA to retest.
kbecciv commentedon Jun 5, 2024
TR is 5 % left
#31529 is pending verification
#39970 is pending verification
#40460 is pending verification
#41638 is pending verification
#41638 is pending verification on Desktop
#41859 is failing with #43060 on Web, mWeb, Desktop and IOS app
#42004 is pending verification on Android and IOS app
#42008 is pending verification o IOS app
#42184 is failing with #43051
#42188 is pending verification on IOS and Desktop
#42315 is pending verification on mWeb, Android and IOS app
#42543 is pending verification
#42548 is pending verification on IOS app
#42561 is pending verification on IOS app and Desktop
#42568 is pending verification on Desktop
#42613 is pending verification on IOS app and Desktop
#42631 is pending verification on Desktop
#42690 is pending verification on Desktop
#42704 is failing with #42627 on mWeb, Desktop, Android and IOS app
#42731 is pending verification on Desktop
#42746 is pending verification on Desktop
#42909 is pending verification
#42997 is pending verification
CP #43054 is pending verification
CP #43074 is pending verification
Deploy Blockers:
#43050
#43060
#43096
#43111
#43112
#43113
#43115
#43116
#43119
kbecciv commentedon Jun 5, 2024
TR is completed!
#31529 is blocked with #25790 (comment) on Desktop, Android and IOS app
#39970 is pending verification on Desktop, Android and IOS app
#40460 is failing with #39689 on Web, left comment #40460 (comment)
#41638 is failing with #43119
#41859 is failing with #43060 on Web, mWeb, Desktop and IOS app
#42184 is failing with #43051
#42315 is pending validation in IOS app
#42543 is pending validation
#42568 is pending validation in IOS app
#42631 is failing with #41584 on Desktop and Web
#42704 is failing with #42627 on mWeb, Desktop, Android and IOS app
#42909 is pending validation on Desktop
CP #43095 is pending validation on IOS app
Deploy Blockers:
#43112
#43113
#43130
#43131
#43145
roryabraham commentedon Jun 6, 2024
status update on our remaining blockers:
1.4.79-10+, but due to a problem iOS hasn't deployed yet. Working on getting an iOS staging build done so that we can check this one offroryabraham commentedon Jun 6, 2024
#43112 is fixed, checking it off.
roryabraham commentedon Jun 6, 2024
So that leaves us with just two blockers:
and we already discussed both and agree they don't necessarily need to be blockers.
kbecciv commentedon Jun 6, 2024
Regression is completed!
#31529 is blocked with #25790 (comment) on Desktop, Android and IOS app
#40460 is failing with #39689 on Web, left comment #40460 (comment)
#41638 is failing with #43119, checking off per comment #43119 (comment)
#41859 is failing with #43060 on Web, mWeb, Desktop and IOS app
#42184 is failing with #43051, checking off per comment #43051 (comment)
#42568 is failing with #43148 in IOS, repro in prod, checking off
#42631 is failing with #41584 on Desktop and Web
#42704 is failing with #42627 on mWeb, Desktop, Android and IOS app
#42909 is failing with #43111 on Web and Desktop, checking off per comment #43111 (comment)
Deploy Blockers:
#43113
#43131
Julesssss commentedon Jun 6, 2024
I'm demoting the last two blockers, which are in no way critical. More reasoning here.
Julesssss commentedon Jun 6, 2024
Checking off PRs
Julesssss commentedon Jun 6, 2024
1.4.79-11Julesssss commentedon Jun 6, 2024