Company Cards - Bank UI by narefyev91 · Pull Request #50716 · Expensify/App

narefyev91 · 2024-10-14T10:41:10Z

Details

Company Cards - Bank UI flow

Fixed Issues

$ #50448
PROPOSAL:

We will use here "example url" - https://secure.chase.com/web/auth/#/logon/logon/chaseOnline?redirect_url=
User should have company cards available

Tests

WEB, Desktop, mWeb:
For WEB - to open a new tab in modal overlay - browser should not be in full screen mode

Choose any bank account (not Other) -> Next (For Brex point 2 is skipped)
Choose Direct feed or Business Card (for Amex)
Verify that user sees a new screen with image, text and link button to open a new tab
Verify that new tab was opened in default browser with "example url"
Close a new tab and move back to app screen
Click on link to open a new tab -> Verify that new tab is opened
Move back to the app -> click Go back button -> Verify that opened tab with "example url" is closed as well (not working for Desktop - based on global rule set here)
Verify that go back land user to Select Feed or Card Type for Amex or Select Bank for Brex

Native App:

Choose any bank account (not Other) -> Next (For Brex point 2 is skipped)
Choose Direct feed or Business Card (for Amex)
Verify that user sees "example url" opened in WebView
Click Go back button -> Verify that go back land user to Select Feed or Card Type for Amex or Select Bank for Brex

Verify that no errors appear in the JS console

Offline tests

Same rules as was defined to the whole feature

QA Steps

WEB, Desktop, mWeb:
For WEB - to open a new tab in modal overlay - browser should not be in full screen mode

Choose any bank account (not Other) -> Next (For Brex point 2 is skipped)
Choose Direct feed or Business Card (for Amex)
Verify that user sees a new screen with image, text and link button to open a new tab
Verify that new tab was opened in default browser with "example url"
Close a new tab and move back to app screen
Click on link to open a new tab -> Verify that new tab is opened
Move back to the app -> click Go back button -> Verify that opened tab with "example url" is closed as well (not working for Desktop - based on global rule set here)
Verify that go back land user to Select Feed or Card Type for Amex or Select Bank for Brex

Native App:

Choose any bank account (not Other) -> Next (For Brex point 2 is skipped)
Choose Direct feed or Business Card (for Amex)
Verify that user sees "example url" opened in WebView
Click Go back button -> Verify that go back land user to Select Feed or Card Type for Amex or Select Bank for Brex

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

android-web2.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

web2.mov

MacOS: Desktop

8mb.video-pFt-7xpB0Idl.mp4

# Conflicts: # src/CONST.ts # src/pages/workspace/companyCards/addNew/AddNewCardPage.tsx

melvin-bot · 2024-10-18T10:28:12Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

allgandalf · 2024-10-18T10:43:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-18.at.4.41.10.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-10-18.at.4.39.42.PM.mov

iOS: Native

Screen.Recording.2024-10-18.at.4.44.16.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-10-18.at.4.45.57.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-10-18.at.4.19.53.PM.mov

MacOS: Desktop

Screen.Recording.2024-10-18.at.4.38.48.PM.mov

allgandalf

♻️ Code LGTM, good work @narefyev91 🙇

We fallback to chase chase for all banks for now, as we are yet to have the BE ready.
Verified that On web platforms, when we go back to the app and press bank button, the chase website closes.
On Native devices for a split second before we get the web-view, we get loading indicators of both the native device and web-view, I feel this is a edge case and we can create a issue for this to see if we can deal with this issue.

Let's merge this, we are almost set for production testing 💪

shawnborton · 2024-10-18T13:51:11Z

The videos look pretty good to me. The only thing that caught my eye was that when you manually press the link here:

...can we make that open up the Chase/bank login window the same way it previously opened (small window centered on top) rather than a new tab? Or maybe we're doing a new tab on purpose?

narefyev91 · 2024-10-21T07:46:04Z

The videos look pretty good to me. The only thing that caught my eye was that when you manually press the link here:

...can we make that open up the Chase/bank login window the same way it previously opened (small window centered on top) rather than a new tab? Or maybe we're doing a new tab on purpose?

@shawnborton i think it was just an example video from @allgandalf to show that when we click back button - tab is closed. Technically when browser is not in a full mode and user clicks on the link - we will open new browser in a modal:

Screen.Recording.2024-10-21.at.10.43.20.mov

shawnborton · 2024-10-21T08:10:11Z

Okay great, thanks for confirming!

mountiny

Great job!

mountiny · 2024-10-21T10:58:50Z

Reassure Performance Tests / perf-tests (pull_request) Failing after 17m

Processing measurement 1: [ReportScreen] should render ReportScreen
Error: Render count difference exceeded the allowed deviation of 0. Current difference: 1

There is nothing in this PR that could influence the ReportScreen rendering so I will go ahead and merge it @OlimpiaZurek any chance this could be related to the change from last week

melvin-bot · 2024-10-21T10:59:01Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2024-10-21T10:59:37Z

This is not an emergency, seems like the Reassure test is broken at the moment so I proceeded with merging

OSBotify · 2024-10-21T11:08:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-22T04:48:24Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.52-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T16:25:51Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.52-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

DylanDylann · 2024-11-05T11:23:40Z

+        if (isBankConnectionCompleteRoute) {
+            customWindow?.close();
+            return;
+        }


@allgandalf @narefyev91 This change isn't worked because the URL is not changed to include BANK_CONNECTION_COMPLETE --> isBankConnectionCompleteRoute always be false even though the user completed the bank connection

The above bug is reported here

@DylanDylann sorry i didn't understand by:

the URL is not changed to include BANK_CONNECTION_COMPLETE --> isBankConnectionCompleteRoute

Can you explain or point me to some code for better context?

rojiphil · 2025-02-19T06:05:53Z

+                title={translate('workspace.companyCards.addCardFeed')}
+                onBackButtonPress={handleBackButtonPress}
+            />
+            <BlockingView


We missed considering the offline scenario while performing online bank authentication. We addressed this in #55096

thanks for pointing that out, AFAIK, I guess this was implemented following the design doc, did we miss this details @narefyev91 ?

No I dont think this was covered in the design doc

Not really remember that it was specified in design doc

narefyev91 added 5 commits October 14, 2024 13:39

Company Cards - Bank UI

fa98968

Merge branch 'refs/heads/main' into company-cards-bank-ui

6d7221e

# Conflicts: # src/CONST.ts # src/pages/workspace/companyCards/addNew/AddNewCardPage.tsx

latest updates for the whole flow

b5e555b

Merge branch 'refs/heads/main' into company-cards-bank-ui

60bfad4

Add constants

d725a59

narefyev91 marked this pull request as ready for review October 18, 2024 10:28

narefyev91 requested review from a team as code owners October 18, 2024 10:28

melvin-bot Bot requested a review from allgandalf October 18, 2024 10:28

melvin-bot Bot removed the request for review from a team October 18, 2024 10:28

allgandalf reviewed Oct 18, 2024

View reviewed changes

Comment thread src/libs/actions/getCompanyCardBankConnection/index.tsx Resolved

add more todo

03c8aea

allgandalf approved these changes Oct 18, 2024

View reviewed changes

melvin-bot Bot requested a review from mountiny October 18, 2024 11:21

mountiny assigned narefyev91 Oct 21, 2024

mountiny previously approved these changes Oct 21, 2024

View reviewed changes

Comment thread src/CONST.ts Resolved

clean up

be97e7d

narefyev91 dismissed mountiny’s stale review via be97e7d October 21, 2024 10:36

mountiny approved these changes Oct 21, 2024

View reviewed changes

mountiny merged commit b2fc5c9 into Expensify:main Oct 21, 2024

melvin-bot Bot added the Emergency label Oct 21, 2024

mountiny removed the Emergency label Oct 21, 2024

github-actions Bot mentioned this pull request Oct 22, 2024

Deploy Checklist: New Expensify 2024-10-22 #51219

Closed

74 tasks done

melvin-bot Bot mentioned this pull request Oct 23, 2024

[HOLD for payment 2024-11-05] [HOLD for payment 2024-11-01] [HOLD for payment 2024-10-30] [Direct Feeds] [App] Adding Direct Card Feed: Bank UI #50448

Closed

DylanDylann reviewed Nov 5, 2024

View reviewed changes

rojiphil reviewed Feb 19, 2025

View reviewed changes

MelvinBot mentioned this pull request May 28, 2026

[$250] Company cards - RHP loads infinitely after adding existing direct feed #81573

Closed

4 of 7 tasks

Conversation

narefyev91 commented Oct 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 18, 2024

Uh oh!

Uh oh!

allgandalf commented Oct 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

allgandalf left a comment

Choose a reason for hiding this comment

Uh oh!

shawnborton commented Oct 18, 2024

Uh oh!

narefyev91 commented Oct 21, 2024

Uh oh!

shawnborton commented Oct 21, 2024

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mountiny commented Oct 21, 2024

Uh oh!

melvin-bot Bot commented Oct 21, 2024

Uh oh!

mountiny commented Oct 21, 2024

Uh oh!

OSBotify commented Oct 21, 2024

Uh oh!

github-actions Bot commented Oct 22, 2024

Uh oh!

github-actions Bot commented Oct 23, 2024

Uh oh!

DylanDylann Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

allgandalf Nov 5, 2024

Choose a reason for hiding this comment

Uh oh!

rojiphil Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

allgandalf Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mountiny Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

narefyev91 Feb 19, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

narefyev91 commented Oct 14, 2024 •

edited

Loading

allgandalf commented Oct 18, 2024 •

edited

Loading

allgandalf Feb 19, 2025 •

edited

Loading