[UX Reliability] New modal in `AttachmentPickerWithMenuItems` by BartoszGrajdek · Pull Request #56605 · Expensify/App

BartoszGrajdek · 2025-02-10T14:30:28Z

Explanation of Change

We've decided to refactor the react-native-bottom-modal code so that it utilizes react-native-reanimated, our goal was to improve FPS, remove the outdated library and gradually switch to the new solution. This PR enables the new solution in AttachmentModal.

Fixed Issues

$ #49354

Tests

I think testing should go like this:

Open the modal.
Close it by clicking the backdrop.
Open the modal.
Close it through the "back" button if it exists on your device.
Open the modal.
Go through each button/option in that modal and verify that everything's functioning properly.

To open the modal you need to:

Open any chat
Click on the "+" button next to composer - this is the modal

Offline tests

Same as above, but it shouldn't matter

QA Steps

Same as above

PR Author Checklist

Screenshots/Videos

Android: Native

Android.mov

Android: mWeb Chrome

Android.-.mWeb.mov

iOS: Native

iOS.mov

iOS: mWeb Safari

iOS.-.mWeb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

chrispader · 2025-02-17T14:22:47Z

How does this affect the AttachmentModal(s)? I see only changes in components like PopoverMenu, etc. but not in the actual AttachmentModal logic.

I have a PR running which migrates all usages of AttachmentModal to actual @react-navigation screens here: #56219.

Does this conflict with that PR? I think we'll definitely want to have the attachment modals as screens, since they always animate in from right-to-left and they are not used "modally" anywhere.

BartoszGrajdek · 2025-02-17T14:30:53Z

It seems I may have initially used incorrect terminology. What I meant to refer to is the AttachmentPickerWithMenuItems component. I'll update the title accordingly, sorry for the confusion 🙏🏻

From the linked issue's description:

composer action modal to add attachments or to submit expenses in a chat

chrispader · 2025-02-17T14:49:04Z

Got it, perfect thanks! No conflicts then :)

…ttachment-modal

melvin-bot · 2025-03-04T13:57:19Z

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

blazejkustra · 2025-03-04T14:10:57Z

@shawnborton @ZhenjaHorbach One of you needs to copy/paste the

@shawnborton, you're a C+ now too? 😆

blazejkustra · 2025-03-04T14:11:58Z

@ZhenjaHorbach I'll be handling this PR, so if anything comes up, please let me know!

ZhenjaHorbach · 2025-03-04T14:12:39Z

@ZhenjaHorbach I'll be handling this PR, so if anything comes up, please let me know!

No problem !
I will check it soon

ZhenjaHorbach · 2025-03-04T15:06:28Z

                        <PopoverMenu
-                            animationInTiming={CONST.ANIMATION_IN_TIMING}
+                            animationInTiming={menuItems.length * 50}
+                            animationOutTiming={((menuItems.length * 50) / 3) * 2}


Do we really need these mathematical operations ? 😅
Or at least I think we can update this like (menuItems.length * 50) * 0.66
This option looks a bit clearer as for me that the closing animation should be 33 percent faster

I agree! Just pushed a fix with a comment 😄

ZhenjaHorbach · 2025-03-04T15:08:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

2025-03-04.16.27.49.mov

Android: mWeb Chrome

2025-03-04.16.31.36.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

shawnborton · 2025-03-04T15:19:08Z

@shawnborton, you're a C+ now too? 😆

More like a D+! We're code owners in src maybe? So we just creep on PRs to make sure it's all good from a design perspective. Let us know if you need us to review anything!

blazejkustra · 2025-03-04T15:21:44Z

One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it

Haha, I was just joking because usually only C+ folks post the checklist! But thanks for keeping an eye on things! 🙌

ZhenjaHorbach · 2025-03-04T15:30:32Z

On android-web I have some visual artifacts
That the modal window is displayed on a next screen for a short period of time

2025-03-04.16.28.23.mov

blazejkustra · 2025-03-04T17:51:40Z

On android-web I have some visual artifacts
That the modal window is displayed on a next screen for a short period of time

@ZhenjaHorbach Could you test it on a physical device? I've seen similar issues (connected to navigation) and they only appear on emulators for some reason.

ZhenjaHorbach · 2025-03-04T17:53:18Z

On android-web I have some visual artifacts
That the modal window is displayed on a next screen for a short period of time

@ZhenjaHorbach Could you test it on a physical device? I've seen similar issues (connected to navigation) and they only appear on emulators for some reason.

Oh
Yeah
Looks similar
I will check it today or tomorrow !

ZhenjaHorbach · 2025-03-05T07:57:36Z

On a real device I have the same issue

Screenrecorder-2025-03-05-08-56-09-557.mp4

ZhenjaHorbach · 2025-03-05T08:01:35Z

Although I tested on dev env on the real device

@shawnborton
Could you please trigger adhoc builds?

shawnborton · 2025-03-05T08:17:43Z

On it!

github-actions · 2025-03-05T08:18:21Z

🚧 @shawnborton has triggered a test hybrid app build. You can view the workflow run here.

github-actions · 2025-03-05T08:44:01Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56605/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56605/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
❌ FAILED ❌	❌ FAILED ❌
The QR code can't be generated, because the Android Hybrid build failed	The QR code can't be generated, because the iOS Hybrid build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/56605/NewExpensify.dmg	https://56605.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

ZhenjaHorbach · 2025-03-05T08:51:36Z

This bug is specific to dev only
In that case I have no more questions
LGTM !

blazejkustra · 2025-03-05T09:17:40Z

#56605 (comment) is specific to dev only

That’s really strange, and the fact that it only happens in the dev environment makes it even more confusing. I'll ask someone from SWM to take a look, as I suspect this issue might resurface from time to time.

edit: this shouldn't block merging

mountiny

Thanks for thorough testing @ZhenjaHorbach!

Lets be on a look out for any potential regressions

OSBotify · 2025-03-06T00:06:34Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-06T23:14:35Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-10T21:10:07Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

feat: enable new modal in attachment picker

d0ef546

BartoszGrajdek changed the title ~~[UX Reliability] Use new modal code in AttachmentModal~~ [UX Reliability] New modal in AttachmentPickerWithMenuItems Feb 17, 2025

BartoszGrajdek added 2 commits February 27, 2025 09:13

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/new-a…

2e55620

…ttachment-modal

Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/new-a…

bb0b4aa

…ttachment-modal

BartoszGrajdek marked this pull request as ready for review March 4, 2025 13:57

BartoszGrajdek requested a review from a team as a code owner March 4, 2025 13:57

melvin-bot Bot requested review from ZhenjaHorbach and shawnborton and removed request for a team March 4, 2025 13:57

ZhenjaHorbach reviewed Mar 4, 2025

View reviewed changes

Adjust popover menu closing timing to improve user experience

b3e271c

shawnborton added the Ready To Build label Mar 5, 2025

ZhenjaHorbach approved these changes Mar 5, 2025

View reviewed changes

melvin-bot Bot requested a review from mountiny March 5, 2025 08:52

mountiny assigned BartoszGrajdek Mar 5, 2025

mountiny approved these changes Mar 5, 2025

View reviewed changes

mountiny merged commit c62e310 into Expensify:main Mar 5, 2025

github-actions Bot mentioned this pull request Mar 6, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks done

melvin-bot Bot mentioned this pull request Mar 10, 2025

[UX Reliability] Improve the bottom modal animations quality and reliability on native and mWeb platforms #49354

Closed

Conversation

BartoszGrajdek commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

chrispader commented Feb 17, 2025

Uh oh!

BartoszGrajdek commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chrispader commented Feb 17, 2025

Uh oh!

melvin-bot Bot commented Mar 4, 2025

Uh oh!

blazejkustra commented Mar 4, 2025

Uh oh!

blazejkustra commented Mar 4, 2025

Uh oh!

ZhenjaHorbach commented Mar 4, 2025

Uh oh!

ZhenjaHorbach Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blazejkustra Mar 4, 2025

Choose a reason for hiding this comment

Uh oh!

ZhenjaHorbach commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

shawnborton commented Mar 4, 2025

Uh oh!

blazejkustra commented Mar 4, 2025

Uh oh!

ZhenjaHorbach commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Mar 4, 2025

Uh oh!

ZhenjaHorbach commented Mar 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ZhenjaHorbach commented Mar 5, 2025

Uh oh!

shawnborton commented Mar 5, 2025

Uh oh!

github-actions Bot commented Mar 5, 2025

Uh oh!

github-actions Bot commented Mar 5, 2025

Uh oh!

ZhenjaHorbach commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blazejkustra commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Mar 6, 2025

Uh oh!

github-actions Bot commented Mar 6, 2025

Uh oh!

github-actions Bot commented Mar 10, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

BartoszGrajdek commented Feb 10, 2025 •

edited

Loading

BartoszGrajdek commented Feb 17, 2025 •

edited

Loading

ZhenjaHorbach Mar 4, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 4, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 4, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 4, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 5, 2025 •

edited

Loading

ZhenjaHorbach commented Mar 5, 2025 •

edited

Loading

blazejkustra commented Mar 5, 2025 •

edited

Loading