Skip to content

[UX Reliability] New modal in AttachmentPickerWithMenuItems #56605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mountiny merged 4 commits into from
Mar 5, 2025
Merged

[UX Reliability] New modal in AttachmentPickerWithMenuItems #56605

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d0ef546
feat: enable new modal in attachment picker
BartoszGrajdek Feb 10, 2025
2e55620
Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/new-a…
BartoszGrajdek Feb 27, 2025
bb0b4aa
Merge remote-tracking branch 'origin/main' into @BartoszGrajdek/new-a…
BartoszGrajdek Mar 4, 2025
b3e271c
Adjust popover menu closing timing to improve user experience
blazejkustra Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,9 @@ function AttachmentPickerWithMenuItems({
</View>
</View>
<PopoverMenu
animationInTiming={CONST.ANIMATION_IN_TIMING}
animationInTiming={menuItems.length * 50}
// The menu should close 2/3 of the time it took to open
animationOutTiming={menuItems.length * 50 * 0.66}
isVisible={isMenuVisible && isFocused}
onClose={onPopoverMenuClose}
onItemSelected={(item, index) => {
Expand All @@ -375,6 +377,7 @@ function AttachmentPickerWithMenuItems({
menuItems={menuItems}
withoutOverlay
anchorRef={actionButtonRef}
shouldUseNewModal
/>
<DelegateNoAccessModal
isNoDelegateAccessMenuVisible={isNoDelegateAccessMenuVisible}
Expand Down