Repository navigation
Add feed syntax key - #57454
Add feed syntax key#57454
feed syntax key#57454Conversation
Kicu
left a comment
Kicu
left a comment
There was a problem hiding this comment.
Good job. There are things that we can improve here, because the code surrounding cards is already pretty complex, so I think it's worth taking another look.
Also congratz for trying to write some tests 👍
General comment about commiting project.pbxproj: if you have not changed anything in package.json, did not update any dependencies and/or pods - just app code, then do not commit changes to this file - just discard them.
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
sobitneupane
left a comment
sobitneupane
left a comment
There was a problem hiding this comment.
@JakubKorytko As you can see in the following video, we display the suggestion feed:"All Expensify", but clicking on it does nothing. I believe that since feed:"All Expensify" is already selected, we should not show this suggestion.
We don't show the suggestion when a card is selected.
Screen.Recording.2025-03-05.at.13.13.22.mov
Steps To Reproduce the issue:
- Click on the search anywhere in the application.
- Type in feed: followed by existing card feed (workspace or domain) and select it.
- Click on the search bar in the expense page.
|
The app crashes when Screen.Recording.2025-03-05.at.13.34.34.mov |
|
Initially, the feed name was "All Expensify", but it changed to "All Expensify - WS". After clearing the cache, it reverted to "All Expensify". Could this be due to a backend and frontend sync issue?
|
luacmartins
left a comment
luacmartins
left a comment
There was a problem hiding this comment.
Code is looking good. We just need to get rid of the submodule change. I feel like that'll create issues if we leave it in
|
@luacmartins are worried that even if the hash is correct now, but there is a commit changing this hash in history that will cause some problems? |
There was a problem hiding this comment.
Thanks for the changes @JakubKorytko
I noticed that the Feed name used under Card in Advanced Filters is different from the actual feed name. This might be related to this issue, but I'm not entirely sure.
Screen.Recording.2025-03-06.at.13.46.14.mov
There was a problem hiding this comment.
Screenshots/Videos
Android: Native
Screen.Recording.2025-03-06.at.14.16.16.mov
Android: mWeb Chrome
Screen.Recording.2025-03-06.at.14.19.43.mov
iOS: Native
Screen.Recording.2025-03-06.at.19.36.41.mov
iOS: mWeb Safari
Screen.Recording.2025-03-06.at.14.26.59.mov
MacOS: Chrome / Safari
Screen.Recording.2025-03-06.at.13.51.39.mov
Screen.Recording.2025-03-06.at.13.53.09.mov
MacOS: Desktop
Screen.Recording.2025-03-06.at.14.36.39.mov
I think that should be fine. |
|
I've applied fixes according to @Kicu comment.
I think I found problem mentioned by @sobitneupane and fixed it, from my tests it seems to work correctly now. |
|
Nice, let's review this again @sobitneupane @Kicu |
|
@JakubKorytko I can still reproduce this issue. Reproduction steps:
I was able to reproduce this issue in staging as well, so it does not appear to be related to this PR. I also believe this issue is related to this issue. @luacmartins Is this the expected behavior? |
sobitneupane
left a comment
sobitneupane
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel and/or tagged@Expensify/designso the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
- If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
I don't think so, but if this behavior is reproducible in staging, we don't need to block this PR on it |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.1.10-0 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀
|
| onChangeText={(value) => { | ||
| setSearchTerm(value); | ||
| }} | ||
| showLoadingPlaceholder |
There was a problem hiding this comment.
Coming from: #58886, we should show the loading indicator only when data is loading
| return []; | ||
| } | ||
|
|
||
| return domainFeedCards[cardFeedKey].filter((cardNumber) => cards[cardNumber].state !== CONST.EXPENSIFY_CARD.STATE.STATE_NOT_ISSUED); |
There was a problem hiding this comment.
domainFeedCards[cardFeedKey] may not exist which would result in an exception. We fixed this in #73529
Explanation of Change
Fixed Issues
$ #56855
PROPOSAL: N/A
Tests
feed:followed by existing card feed (workspace or domain).feed:fundID_bank.Cardrow.Offline tests
N/A
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android.mov
Android: mWeb Chrome
iOS: Native
iOS.mov
iOS: mWeb Safari
MacOS: Chrome / Safari
Web.mov
MacOS: Desktop
Desktop.mov