Repository navigation
fix lhn not show tooltip - #61914
Merged
Merged
fix lhn not show tooltip#61914
Conversation
Contributor
Author
4 of 8 tasks
JS00001
self-requested a review
May 13, 2025 19:22
JS00001
requested changes
May 13, 2025
3 of 16 tasks
Contributor
Reviewer Checklist
|
JS00001
approved these changes
May 14, 2025
OSBotify
pushed a commit
that referenced
this pull request
May 14, 2025
fix lhn not show tooltip (cherry picked from commit 1fa4cf0) (cherry-picked to staging by francoisl)
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.1.45-5 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Cherry-picked to staging by https://github.com/francoisl in version: 9.1.45-11 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
Contributor
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.1.45-21 🚀
|
2 of 16 tasks
88 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Fixed Issues
$ #61119
$ #61938
$ #61921
PROPOSAL: #61119 (comment)
Tests
Same QA step
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)myBool && <MyComponent />.src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-05-13.at.22.24.53.mp4
MacOS: Desktop