Repository navigation
Closed
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 9.1.46-12
Compare Changes: production...staging
This release contains changes from the following pull requests:
- [NoQA] Migrate to
react-native-nitro-sqlitein E/App and Onyx #53149 - Fix: On tapping device back button to close troubleshoot box from LHN, navigated out of site #58608
- fix: the system message when someone requests to join a workspace #58897
- [Desktop Navigation] Add a new Workspaces tab to the navigators and update navigation bar styles #60184
- Setup
react-native-walleton Android #60270 - Update onboarding page with new integration choices #60505
- fix: update title and url correctly when changing category name #60792
- fix: avoid duplicated /SearchForReport calls #60810
- [UX Reliability] Add new modal for MoneyRequestReportTransactionList #60952
- Improve bottom tab switching by hiding PopoverMenu #60959
- fix: expense report disappears from LHN after opening transaction thread header in RHP #61130
- Fixed trip cancellation text #61205
- Update IOU action when moving reports #61221
- Fix workspace features multiselect #61358
- fix: ComposeBox - When you click on the mention again, extra characters appear. #61362
- fix: Remove mobile offline indicator on "Start chat" page #61367
- Fix clearing selection when mobile selection mode is on #61377
- Fix attachment modal for broken images #61459
- [No QA] chore: bump RNEF from 0.7.1 to 0.7.6 #61490
- fix: user gets onboarding modals multiple times #61546
- [NO QA] Update Reimburse-Reports.md #61613
- fix: required field error is not displayed when clearing the field #61653
- Add popToSidebar method #61689
- [Internal QA] Update Company Cards logic to show domain cards #61706
- Delete & Hold are present when there are two expense previews, app crashes with Hold option #61761
- Optimize Reports view to prevent memory leaks after long usage #61771
- [Better Expense Report View] Update the go to parent logic in Reports tab #61774
- [Better Expense Report View] Deleting second to last expense & [Not BERV] concierge message fix + #61680 follow-up #61777
- Fix: Infinite loading when clicking on the self expense's chat #61798
- Fix existing approver is shown in additional approver briefly #61819
- Fix: private domain onboarding check doesn't show for hybrid app iOS #61837
- Move selected transactions #61839
- Migrate RN Gesture Handler in AttachmentCarouselPager to Gestures API #61841
- Fix - Client side calculation of overLimit violation doesn't take forex rates into account #61852
- Update artifacts workflow to verify diff in patches based on hash of their contents #61862
- Fix unread marker displayed consistently on chat after creating new expense and switching reports #61867
- [No QA] Mark getTransaction as deprecated #61879
- Feat: Show settlement account for admins who don't own bank account #61880
- Help Modal - Help modal is shown when reducing the size of the window #61884
- Fix: We show wallet balance badge even for those who haven't enabled Expensify wallet #61888
- [No QA] Add longer timeout for Concierge sent typing requests #61933
- Filter out report previews that shouldn't be shown in ReportPreview & MoneyRequestReportView #62002
- Move "Download as PDF" to "More" button #62022
- [No QA] Paginate commit diff when creating checklist #62061
- fix: Tapping change workspace directs to hmm not here page #62073
- Fix missing space after punctuation & Learn more link in Upgrade RHP #62074
- Remove old report preview implementation #62098
- Fix - Reports - Responsive "Pay" button displayed on preview for unsubmitted expenses. #62122
- [CP Staging] Revert "Filter out report previews that shouldn't be shown in ReportPreview & MoneyRequestReportView" #62151
- Revert GH Action changes, fix broken and incomplete deploy checklists #62164
- [CP Staging] Account - Account tab is accessible when navigating to public room as guest #62180
- [CP Staging] Fix request step report when sharing with accountant #62183
- [CP Staging] Revert "fix modal backdrop animation changes" #62190
- [CP Staging] Revert "Merge pull request #61884 from nkdengineer/fix/61016" #62200
- [CP staging] fix: Account icon on bottom tab is briefly highlighted when returning from create workspace page. #62226
- [CP Staging] Fix member details display to include any Expensify Card related information #62229
- [CP Staging] Align primary/search action logic #62237
- [CP Staging] Reports - Self DM opened from Reports tab does not show expenses, Download is not working #62269
- [CP Staging] Correct PR #62002 & (reverted) #61777 #62275
- [CP Staging] Remove the navigation bar from the screen where it shouldn't be #62304
Internal QA:
Deploy Blockers:
- [Due for payment 2025-05-30] Tooltip - Workspaces tooltip appears above Workspaces row and overlaps with Workspaces header #62141
- Expense - Missing Move expense in transaction thread, Report field is missing in Gmail account #62142
- Android - Device back button is not functional #62143
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] Expense - Optimistic expense report preview not showing after creating an expense while being offline #62144
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] [$250] Account icon on bottom tab is briefly highlighted when returning from create workspace page #62145
- [Due for payment 2025-06-02] [Due for payment 2025-05-28] [Due for payment 2025-05-27] Expense - Track expense preview shows "View" on chat but "Submit" is displayed on "Reports" #62152
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] Account - Account tab is accessible when navigating to public room as guest #62153
- [HOLD] Expense - Unable to move expense to the report of a track expense. #62154
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] Android - Help - Help panel doesn´t appear on new account until device´s back button is used #62155
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] Report field opens Not here page when sharing expense to accountant on confirmation page #62156
- Expense - Submit button isn't displayed for admin in employee's expense detail page #62168
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] Expensify Card - Member profile does not include any Expensify Card related information #62173
- Focus is not set on the edited message when editing is selected #62174
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] mWeb - LHN-Tapping backdrop doesn't closes FAB menu #62175
- [$250] Expense Report - System message is not bottom aligned #62176
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] mWeb - Profile - After selecting date, save button is greyed out #62187
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] AU - Chat - Deleted message with a thread disappears from chat #62191
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] Reports - Self DM opened from Reports tab does not show expenses, Download is not working #62193
- [Due for payment 2025-05-28] [Due for payment 2025-05-27] Reports - Composer is blocked by bottom tab when expense report is opened from transaction thread #62196
- [Due for payment 2025-06-11] [$250] iOS - Workspace - Unable to swipe right on Subscription page to go back to Upgrade page #62221
- Company Cards - The list of banks is not displayed when adding a company card #62246
- [Due for payment 2025-06-05] [$250] Expense-App opens expense report instead of returning to confirm page after selecting a report #62343
- [Due for payment 2025-07-01] [$250] mWeb - Room - Tapping device back button from workspaces page, chat tab briefly selected. #62346
Deployer verifications:
- I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
- I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
MonthlyKSv2KSv2StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
github-actions commentedon May 16, 2025
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.46-0 🚀
MonilBhavsar commentedon May 16, 2025
Just a heads up that Deploy blockers are not being added in the list in OP
lakchote commentedon May 16, 2025
Demoted #62176 for this reason.
izarutskaya commentedon May 16, 2025
Regression is at 94% completed.
#58608
#60505
#60959
#61362
This PRs from previously build which are reverted
#61850 - Internal QA
#61914 - I can't find in the list
mountiny commentedon May 16, 2025
Checking #60270 off
mountiny commentedon May 16, 2025
Demoted #62141
francoisl commentedon May 16, 2025
Checking all those as they were reverted:
#61362
#60959
#58608
#60505
mvtglobally commentedon May 16, 2025
Regression is at 97% completed.
Lots of PRs still in progress, Will share detailed list shortly
Blockers
#62142
#62143
#62144
#62145
#62152
#62154
#62156
#62173
#62175
#62187
#62191
#62193
#62196
#62221
mvtglobally commentedon May 16, 2025
PRs
#60792 - issue repro when running PR #62184. checking off
#60810 - Pending validation on All platforms
#61205 - Pending validation on All platforms
#61221 - Is failing with #62144
#61377 (comment) - Can you pls help with expected behavior ofline
#61459 - Issue repro #60554, checking off
#61761 (comment) - Can we check this off?
#61798 - Issue repro when running this PR #61798
#61837 - Failing on Hybrid with #62167
#61841 - Pending validation on All platforms
#61850 - Internal QA
#61862 (comment) - Is this Internal QA?
#61867 - facing #62144 on Web
#61880 - Pending validation on All platforms
#62002 - is failing with #58686
#62180 - Pending validation on All platforms
joekaufmanexpensify commentedon May 16, 2025
checked off #61850
francoisl commentedon May 16, 2025
The following blockers have been fixed and are ready to check:
mvtglobally commentedon May 19, 2025
Regression is completed
We are checking Blockers and will update shortly
22 remaining items
mvtglobally commentedon May 20, 2025
#62269 - Pass on Web, mWeb, Android. Pending validation on Desktop and IOS
#62304 - Pass on Web, mWeb, Android. Pending validation on Desktop and IOS
#61761 (comment) - Can we check this off?
isagoico commentedon May 20, 2025
#62143 - Issue is not reproducible in 2 different Android devices and OS. Posting details in tissue
marcaaron commentedon May 20, 2025
Checking off #62143
isagoico commentedon May 20, 2025
#62304 was a pass for me
ScreenRecording_05-19-2025.22-28-30_1.MP4
Checked off as I don't think we need to wait for a desktop reproduction as this was reported in a mobile environment (iOS native)
mvtglobally commentedon May 20, 2025
#62269 is Pass, checking off
mvtglobally commentedon May 20, 2025
@arosiclair @francoisl this is last unchecked PR #61761 (comment).
mountiny commentedon May 20, 2025
Demoted #62343 - behind beta
demoted #62346 - minor
Checked #61761 (comment) off as its not blocking behaviour compared to production
mountiny commentedon May 20, 2025
Did not notice any issues in the firebase so moving this ahead
mountiny commentedon May 20, 2025
os-botify commentedon May 20, 2025
This issue either has unchecked items or has not yet been marked with the
:shipit:emoji of approval.Reopening!
melvin-bot commentedon May 20, 2025
📣 @os-botify[bot]! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:
Format:
mountiny commentedon May 20, 2025