Skip to content

[CP Staging] Revert "PopoverWithMeasuredContent optimization" - #68156

Merged
chiragsalian merged 1 commit into
mainfrom
revert-67035-feat/popover-optimization
Aug 8, 2025
Merged

[CP Staging] Revert "PopoverWithMeasuredContent optimization"#68156
chiragsalian merged 1 commit into
mainfrom
revert-67035-feat/popover-optimization

Conversation

@jasperhuangg

@jasperhuangg jasperhuangg commented Aug 7, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Reverts #67035

$ #68107

@jasperhuangg jasperhuangg self-assigned this Aug 7, 2025
@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

Sign in to view
@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68156.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68156/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Desktop was skipped The build for Web was skipped

👀 View the workflow run that generated this build 👀

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68156.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68156/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Desktop was skipped The build for Web was skipped

👀 View the workflow run that generated this build 👀

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68156.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68156/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Desktop was skipped The build for Web was skipped

👀 View the workflow run that generated this build 👀

@github-actions

github-actions Bot commented Aug 7, 2025

Copy link
Copy Markdown
Contributor

🚧 @jasperhuangg has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #68156.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/68156/index.html
The build for Android was skipped iOS
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Desktop was skipped The build for Web was skipped

👀 View the workflow run that generated this build 👀

@m-natarajan

m-natarajan commented Aug 8, 2025

Copy link
Copy Markdown

Issue fixed in the ad-hoc build v9.1.90-8 PR:68156 Ad-Hoc

RPReplay_Final1754611744.MP4

@jasperhuangg jasperhuangg changed the title Revert "PopoverWithMeasuredContent optimization" [CP Staging] Revert "PopoverWithMeasuredContent optimization" Aug 8, 2025
@jasperhuangg
jasperhuangg marked this pull request as ready for review August 8, 2025 00:32
@jasperhuangg
jasperhuangg requested a review from a team as a code owner August 8, 2025 00:32
@melvin-bot
melvin-bot Bot requested review from arosiclair and removed request for a team August 8, 2025 00:32
@melvin-bot

melvin-bot Bot commented Aug 8, 2025

Copy link
Copy Markdown

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chiragsalian
chiragsalian merged commit 812beaf into main Aug 8, 2025
@chiragsalian
chiragsalian deleted the revert-67035-feat/popover-optimization branch August 8, 2025 00:42
@melvin-bot melvin-bot Bot added the Emergency label Aug 8, 2025
@melvin-bot

melvin-bot Bot commented Aug 8, 2025

Copy link
Copy Markdown

@chiragsalian looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@chiragsalian

chiragsalian commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

Not an emergency, straight revert

OSBotify pushed a commit that referenced this pull request Aug 8, 2025
@chiragsalian @OSBotify
Merge pull request #68156 from Expensify/revert-67035-feat/popover-op…
234d026 
…timization

[CP Staging] Revert "PopoverWithMeasuredContent optimization"

(cherry picked from commit 812beaf)

(cherry-picked to staging by jasperhuangg)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 8, 2025
@OSBotify

OSBotify commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions Bot mentioned this pull request Aug 8, 2025
Closed
@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.1.90-11 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@github-actions

github-actions Bot commented Aug 8, 2025

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/jasperhuangg in version: 9.1.91-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@jmusial jmusial mentioned this pull request Aug 8, 2025
Closed
@github-actions

github-actions Bot commented Aug 12, 2025

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/marcaaron in version: 9.1.92-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chiragsalian chiragsalian chiragsalian approved these changes
@arosiclair arosiclair Awaiting requested review from arosiclair

Assignees

@jasperhuangg jasperhuangg

Labels

CP Staging marks PRs that have been CP'd to staging Ready To Build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jasperhuangg @m-natarajan @chiragsalian @OSBotify