Repository navigation
Closed
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Description
Release Version: 9.1.90-11
Compare Changes: production...staging
💡 Deployer FYI: This checklist was generated using a new process. PR list from original method and detail logging can be found in the most recent deploy workflow labeled
staging, in thecreateChecklistaction. Please tag @Julesssss with any issues.
This release contains changes from the following pull requests:
- fix: reimbursable features #63054
- [Export Templates] Add Basic IS Templates as export options #64616
- [Export Templates] Add custom IS Templates to export dropdown #65149
- feat: create the
NumberWithSymbolForm#65197 - fix: Error message is not translated to Spanish after trying to move … #65531
- feat: add global_create emoji in chat intro line #65902
- Company Cards: Add statement close date to new and existing card feeds (Backend integration) #66748
- Merge qbd.setupPage.setupErrorBody translation #66773
- fix: Tags - List jumps to “Show More” when selecting tag after 500. #66780
- getting item extracted and spread operator got rid of #66924
- fix: Chat -Skeleton loading when open start chat page. #67012
- PopoverWithMeasuredContent optimization #67035
- Workspace - Usd currency changed displays blue border. #67045
- [NoQA] Update comments to ensure synchronization of distance expense rate logic with Auth #67055
- fix: unable to scroll down while tapping on report field #67066
- [No QA] Side help pane editing / adding content #67112
- fix: remove call to getReportNameValuePairs() in method findLastAccessedReport #67132
- Expensify card - "Expensify Card was not found" on limit page after opening invalid card page #67136
- Delete restore-old-line-height-algorithm React Native patch v2 #67176
- fix: delay transition to OD after onboarding #67209
- Missing the space in upgrade page #67228
- prevent education tooltip from showing when the page is not focused #67294
- [NoQA] Fixed track workspace storylane link #67321
- [NoQA] Show the TestDrive demo to users if they migrated from Classic #67348
- fix: group chat remains displayed on Search on member side after being removed #67443
- Enable Statements in LHN #67450
- fix: incorrect violation when moving smart scan failed expense #67456
- [NoQA] Refactored Console/index.ts to replace Onyx.connect with Onyx.connectWithoutView #67467
- fix: correct go back behaviour on assign card page #67475
- fix: default new WS to Control if user is in annual subscription #67477
- [No QA]: Remove Onyx.connect() for the key: ONYXKEYS.NVP_PREFERRED_LOCALE in src/libs/actions/Locale.ts #67487
- [NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in betaChecker #67493
- [NoQA] Replaced Onyx.connect with Onyx.connectWithoutView in addUtilsToWindow #67495
- Change Invite whisper actions #67496
- Fixed wrong animation direction of a skeleton by removing mirror #67498
- Replaced Onyx.connect with Onyx.connectWithoutView in ActiveClientManager #67524
- [No QA]: Remove Onyx.connect() for the key: ONYXKEYS.ONYX_UPDATES_LAST_UPDATE_ID_APPLIED_TO_CLIENT in src/libs/actions/__mocks__/OnyxUpdates.ts #67540
- Removed Onyx.connect in CardUtils lib file (part 1) #67548
- Change Trip room preview design #67580
- Refactored localeCompare in ReportUtils (part 2) #67690
- Remove minimum file size restriction for attachments #67697
- [No QA]: Remove Onyx.connect() for the key: ONYXKEYS.SESSION in src/libs/actions/QueuedOnyxUpdates.ts #67710
- Fix - Account setting - Display Name Character Limit Inconsistency #67719
- Merge initialSettingsPage.troubleshoot.description translation #67725
- Merge mergeAccountsPage translations #67726
- Merge billingCurrency.note translation #67728
- Merge delegate.notAllowedMessage translation #67729
- Merge workspace.(qbd/qbo).deepDiveExpensifyCard translations #67732
- Remove remaining withOnyx HOCs from the project | Batch 6 #67733
- Error shows up in Take a test drive task after deleting workspace and taking a test drive #67746
- fix: navigate to onboarding personal details from accounting #67758
- Expense - Tags are separated by colon instead of comma in split preview #67761
- Make Feed pill a multi select #67799
- [NoQA] 🤖 ProposalPolice: Added linking to the first >= 90% similarity original proposal #67816
- [No QA] Add tests for mergeDuplicates and resolveDuplicates #67824
- [No QA] Fix path matcher in unused-styles #67826
- fix: default badge is misaligned on medium screens #67831
- [No QA][Snyk] Upgrade electron-updater from 6.6.5 to 6.6.6 #67869
- Perf: Do not render
PopoverMenuuntil it gets opened #67877 - [NOQA] Fix Reassure test failures #67909
- Expense - RHP shows not here page when it is dismissing after unreporting expense #67925
- fix: shared offline image disappears from the chat after going online #67932
- [NO QA] Ignore files generated by Claude from git #67972
- [No QA]: Fix
gh-actions-unused-styles#67987 - [No QA] Load the convert experiments in dev too so we can test changes to them #68000
- [Export Templates] Fix selected reportIDs for search page #68003
- [CP Staging] Revert #63054 "fix: reimbursable features" #68061
- [CP Staging] fix: RBR appears when send image offline and back to online #68090
- [NoQA] [CP Staging] Revert "fix: remove call to getReportNameValuePairs() in method findLastAccessedReport" #68095
- [CP Staging] Revert "Merge pull request #66924 from callstack-internal/fix/1193-improve-workspace-opening" #68100
- fix: back navigation on onboarding interested features page #68125
- [CP Staging] Revert "fix: delay transition to OD after onboarding" #68144
- [CP staging] Revert "fix: default new WS to Control if user is in annual subscription" #68147
- Revert "feat: add global_create emoji in chat intro line" #68149
- [CP Staging] Revert "PopoverWithMeasuredContent optimization" #68156
- Revert "Change Invite whisper actions" #68157
Deploy Blockers:
- [Due for payment 2025-08-19] Expense - p2p expense shows "spent", error when trying to delete expense, unable to pay it #68055
- [Due for payment 2025-08-19] Expense - Reimbursable is enabled in transaction thread when it is disabled on confirm page #68057
- [Due for payment 2025-08-19] Categories - Checkbox is not marked as selected when selecting all categories #68058
- [Due for payment 2025-08-19] [Due for payment 2025-08-15] Reimbursable toggle is enabled when it is disabled before split, and split expense offline #68059
- [Due for payment 2025-09-17] [$250] Onboarding - After redirecting to ND from OD, app redirects back to OD #68060
- Expense RHP turns into skeleton loader after moving invoice to report and disable reimbursable #68063
- Reports- App crashes after deleting expense on empty state after disabling reimbursable toggle #68067
- [Due for payment 2025-08-22] All Data - report level option is missing for invoice report when searched with group-by:reports #68068
- [$250] Workspace - Expense rule settings are set to 0 for subsequent workspaces after first workspace #68070
- [$250] "Company cards" is disabled by default for subsequent workspaces after upgrading to Control #68071
- [Due for payment 2025-08-19] Attachment-RBR appears when send image offline and back to online #68072
- [Due for payment 2025-09-12] [Due for payment 2025-08-22] Share/Submit-"Create $0.00 expense" button displayed, nothing happens when tapping it #68074
- [Due for payment 2025-09-12] [$250] Room - "Got It" button on system message when inviting member, is unresponsive while offline #68076
- [Due for payment 2025-09-12] [$250] Export - Export has begun modal not dismissed when clicking the background page or device back button #68078
- Green Dot is shown on concierge after Exporting #68079
- Export - Exported file not received when online again after exporting all data while offline #68082
- Expense - Onboarding modal appears when clicking on Pay with Business Account #68085
- [Due for payment 2025-08-20] [Due for payment 2025-08-19] iOS- Reports-app not respond when tap delete IOU expense by select All in reports tab #68087
- [Due for payment 2025-08-19] Onboarding-Back button leads to Accounting page instead of the Personal details page #68089
- [$250] Expensify Card - Expensify Card link missing in system message on first attempt #68102
- [Due for payment 2025-09-02] Export - System message on exported expense, is not fully translated when changing language #68103
- [Due for payment 2025-08-20] Expensify Card - Workflows toggle is locked for new workspace when Expensify Card is not enabled #68104
- iOS - Chat - After editing a message, the chat is not scrolled down #68107
- Statement close date reverts to the previous value when first time edit #68108
- iOS - Chat - Emoji is cut off in conversation history when sending a text with emoji #68110
- [Due for payment 2025-08-19] Company cards - No "No results found" when there is no search result on "Custom day of month" #68112
- [BACK BUTTON] [HOLD on #59245] [$250] Room - Incorrect navigation of back button when navigating to links on invite system message #68142
- [Due for payment 2025-10-07] [BACK BUTTON] [$250] Onboarding-After refreshing the page and click back button, onboarding returns to initial page #68148
- Reports - Incorrect amount exported through Report Custom Export for edited expenses #68162
- IOS - Report Custom Export – Missing confirmation modal when export starts #68164
- IOS - Report is sent 2 times when Export via Report Custom Export #68165
- [$250] mWeb /Chrome - Confirmation modal for export is obscured by menu #68166
Deployer verifications:
- I checked Firebase Crashlytics for this release version and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked Firebase Crashlytics for the previous release version and verified that the release did not introduce any new crashes. More detailed instructions on this verification can be found here.
- I checked GitHub Status and verified there is no reported incident with Actions.
cc @Expensify/applauseleads
Metadata
Metadata
Assignees
Labels
StagingDeployCash🔐 LockCashDeploys 🔐Prevent new code from being deployed to stagingPrevent new code from being deployed to staging
Activity
github-actions commentedon Aug 6, 2025
🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/9.1.90-0 🚀
IuliiaHerets commentedon Aug 7, 2025
Regression is at 75% completed
Blockers:
#68055
#68057
#68058
#68059
#68060
#68063
#68067
#68068
#68070
#68071
#68072
#68074
#68076
#68078
#68079
#68082
#68085
#68087
#68089
Lots of PRs still in progress, will share a detailed list shortly
IuliiaHerets commentedon Aug 7, 2025
Regression is at 88% completed
Unchecked PRs:
#63054 - faced with #68019, pending validation on mWeb, Desktop and Native apps,
#64616 - faced with #68078 and #68079,
#65149 - pending validation on all,
#66748 - pending validation on all,
#66773 - pending validation on all,
#66780 - failed with #68058, pending validation on Desktop,
#67132 - pending validation on Web and Desktop,
#67136 - pending validation on Desktop and iOS,
#67209 - failed with #68096 on Android,
#67443 - pending validation on Desktop,
#67450 - pending validation on all,
#67475 - pending validation on iOS,
#67477 - pending validation on Desktop,
#67496 - faced with #68076 on mWeb and Android,
#67498 - pending validation on all,
#67548 - pending validation on Desktop and Native apps,
#67580 - pending validation on all,
#67697 - pending validation on Android,
#67733 - pending validation on Desktop and Native apps,
#67746 - pending validation on Desktop,
#67758 - faced with #68089, pending validation on Desktop,
#67761 - pending validation on Desktop and iOS,
#67799 - pending validation on Desktop,
#67925 - pending validation on Desktop,
#67932 - failed with #68072 on Native apps,
#68003 - pending validation on all.
JS00001 commentedon Aug 7, 2025
Demoting #68112
JS00001 commentedon Aug 7, 2025
Demoted #68108
blimpich commentedon Aug 7, 2025
Demoted #68102
dangrous commentedon Aug 7, 2025
Demoted #68071
aldo-expensify commentedon Aug 7, 2025
#68085 was fixed by #68144
IuliiaHerets commentedon Aug 7, 2025
Regression is almost complete, just a several steps are left untested in BS
Unchecked PRs:
#63054 - faced with #68019, pending validation on mWeb, Desktop and Native apps,
#64616 - faced with #68078 and #68079,
#65149 - pending validation on Web, mWeb and Native apps,
#66748 - failed with #68108,
#66773 - pending validation on all,
#66780 - failed with #68058,
#67132 - failed with #68114,
#67209 - failed with #68096 on Android,
#67496 - faced with #68076 on mWeb and Android,
#67498 - pending validation on all, comment,
#67580 - pending validation on mWeb and Android,
#67746 - failed with #68139 on Desktop,
#67758 - faced with #68089.
jasperhuangg commentedon Aug 7, 2025
@IuliiaHerets any updates on regression tests? Do you think this is something we can finish today?
kavimuru commentedon Aug 8, 2025
Regression is completed
Unchecked PRs:
#63054 - faced with #6801 - PR is reverted, ok to check it off?
#64616 - faced with #68078 and #68079,
#65149 failing with #68162
#66748 - failed with #68108, and waiting for the tester to report 2 more bugs
#66780 - failed with #68058,
#67132 - failed with #68114 repro in PROD checking it off
#67209 - failed with #68096 repro in PROD checking it off
#67496 - faced with #68076 on mWeb and Android,
#67498 (comment)
#67580 - pending validation on mWeb and Android,
#67746 - failed with #68139 on Desktop, Repro in PROD checking it off
#67758 - faced with #68089
#68147 failing with #68147 (comment)
jasperhuangg commentedon Aug 8, 2025
Checked off all the reverted PRs, the PRs related to Exports as that feature doesn't exist on production and we've already demoted all the related blockers. Also checked of any other PRs that are tied to issues that were demoted as blockers.
jasperhuangg commentedon Aug 8, 2025
os-botify commentedon Aug 8, 2025
This issue either has unchecked items or has not yet been marked with the
:shipit:emoji of approval.Reopening!
jasperhuangg commentedon Aug 8, 2025