Repository navigation
Enhance buildOptimisticTransaction function to include card details and eReceipt logic - #73892
Conversation
…nd update receipt handling
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
LGTM |
|
@ikevin127 @lakchote after checking one more time, addition to my statement here, I think we need to fix |
Why is your fix not working? The |
Hmm, I see.. Then we can use only |
|
@mukhrr I'll make a BE fix |
|
👍 thanks |
@mukhrr PR is under review. |
|
@mukhrr it should be good now |
@lakchote yes, thanks! This PR is also working. We can merge it. cc @ikevin127 |
This comment was marked as resolved.
This comment was marked as resolved.
Reviewer Checklist
Screenshots/Videosweb.mov#73806 regression fix: reg-fix.mov |
ikevin127
left a comment
There was a problem hiding this comment.
🎉 LGTM - the regression was addressed as well 🚀
🟢 Thanks everyone for the work!
|
@mukhrr perf tests are failing |
|
@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.55-3 🚀
|
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.57-0 🚀
|
|
@mukhrr QA team failed this with original issue. After editing split, the receipt of unedited expense disappears until after refresh 1763020191896.73892_web.mp4 |
|
@lakchote backend is deployed to staging, isn't it? |
yes, it's even deployed to production |
|
This wasn't an emergency - GH actions were quite buggy this week. |
|
@mukhrr could you please retest on staging and post the video test here? |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀
|
@lakchote we still get
I'm not sure why, but it was working when I checked after your last message about BE update |

Explanation of Change
Fixed Issues
$ #72975
PROPOSAL: #72975 (comment)
Tests
Precondition:
And also (#73806):
Offline tests
QA Steps
The same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_native.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_native.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web.mp4
MacOS: Desktop
desktop.mp4