Repository navigation
[Domain Control] Add RBR to domains - #81201
Conversation
|
@shawnborton @situchan One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@shawnborton @mountiny One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Looks like we need to add these to make checks happy. |
Are there any guidelines on how to add them? |
|
|
@codex review |
|
Codex Review: Didn't find any major issues. Hooray! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
sumo-slonik
left a comment
There was a problem hiding this comment.
LGTM, It looks good, but let’s add tests.
|
@shawnborton is that what you meant? Does it look right to you?
|
|
@shawnborton fixed! can you trigger an adhoc? 🙏 |
|
On it! |
|
🚧 @shawnborton has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
it's ready for tests! |
|
@war-in Prettier failing We should go with this design in case that was not clear yet #80206 (comment) |
Already implemented that way |
# Conflicts: # src/components/SelectionList/ListItem/BaseListItem.tsx
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: mWeb Safari |
mountiny
left a comment
There was a problem hiding this comment.
LGTM, lets fix the actions
|
@mountiny fixed! |
# Conflicts: # src/pages/workspace/WorkspacesListPage.tsx
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/mountiny in version: 9.3.16-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.16-9 🚀
|
| /** | ||
| * Checks if domain has any errors. Used to determine whether to show a red brick road indicator on domain row. | ||
| */ | ||
| function hasDomainErrors(domainErrors?: DomainErrors): boolean { | ||
| if (!domainErrors) { | ||
| return false; | ||
| } | ||
|
|
||
| return !isEmptyObject(domainErrors.errors) || hasDomainAdminsErrors(domainErrors) || hasDomainMembersErrors(domainErrors); | ||
| } |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.







Explanation of Change
This PR adds RBR to the domain admins page
Fixed Issues
$ #80206
PROPOSAL:
Tests
Simulate failing network requestsOffline tests
QA Steps
Simulate failing network requestsPR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-02-02.at.18.53.06.mov