Skip to content

Fix/85943 iou leave notfound loop fix - #88804

Closed
neerajbachani wants to merge 4 commits into
Expensify:mainfrom
neerajbachani:fix/85943-iou-leave-notfound-loop-fix
Closed

neerajbachani wants to merge 4 commits into
Expensify:mainfrom
neerajbachani:fix/85943-iou-leave-notfound-loop-fix

Conversation

@neerajbachani

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR updates IOU leave navigation for invitees so we only navigate to a parent report when the current user is a participant of that parent report.
If the user is not a participant, we navigate to Concierge instead of routing to an inaccessible report, which prevents the repeated "Hm... it's not here" navigation loop.

It also removes the local REPORT_USER_IS_LEAVING_ROOM write from leaveRoom() to align with the reviewed scope.

Fixed Issues

$ #85943
PROPOSAL: #85943 (comment)

Tests

  1. As User A and User B, create a 1:1 chat and send 2 IOUs.
  2. Mention User C (invitee) in the IOU report and send the invite.
  3. Log in as User C.
  4. Open the IOU report.
  5. Tap More > Leave.
  6. Verify app navigates to an accessible destination (Concierge) instead of opening a "Hm... it's not here" loop.
  7. Press Back and verify there is no infinite not-found bounce between inaccessible reports.
  8. Repeat the flow once more to confirm consistent behavior.
  • Verify that no errors appear in the JS console

Offline tests

  1. Start from the same setup and open the IOU report as User C.
  2. Turn network off.
  3. Tap More > Leave.
  4. Turn network back on and allow updates to sync.
  5. Verify User C is not trapped in a repeated "Hm... it's not here" back loop after navigation settles.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
lv_0_20260417213146.1.mp4
Android: mWeb Chrome

<VIDEO_LINK_ANDROID_MWEB>

iOS: Native
lv_0_20260417194544.mp4
iOS: mWeb Safari

<VIDEO_LINK_IOS_MWEB>

MacOS: Chrome / Safari

<VIDEO_LINK_WEB_DESKTOP>

@neerajbachani
neerajbachani requested review from a team as code owners April 26, 2026 14:02
@melvin-bot
melvin-bot Bot requested review from JmillsExpensify and huult April 26, 2026 14:02
@melvin-bot

melvin-bot Bot commented Apr 26, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed request for a team April 26, 2026 14:02
@codecov

codecov Bot commented Apr 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/pages/inbox/ReportNavigateAwayHandler.tsx 77.77% <100.00%> (+7.26%) ⬆️
... and 18 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b368895704

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +132 to +134
const prevParentReport = getReportOrDraftReport(prevParentReportID);
if (isReportParticipant(currentUserAccountID, prevParentReport)) {
Navigation.isNavigationReady().then(() => {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow navigation to accessible non-participant parent reports

This new gate only checks isReportParticipant before navigating to prevParentReportID, but report access in this codebase is broader than participation (for example canCurrentUserOpenReport() explicitly allows public rooms in src/libs/ReportUtils.ts). As a result, users who can legitimately open the parent report but are not listed in participants (or when participants are omitted from a cached room object) will now be redirected to Concierge after leaving the child report, which is a regression from the prior behavior.

Useful? React with 👍 / 👎.

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@huult quick question on process:

verifySignedCommits is failing because this branch includes one old unsigned commit in history (ac769eaa2b7), while the newer commits are signed/verified.

Would you allow a one-time history cleanup on this PR branch using:

git push --force-with-lease

to drop/re-sign only that bad commit and keep this same PR open?

If you prefer no force-push, I’ll open a fresh branch/PR from latest upstream/main with only the signed commits.

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@huult Gentle bump. thanks

@huult

huult commented May 1, 2026

Copy link
Copy Markdown
Contributor

@neerajbachani let’s try this because we didn’t review or make changes, so history is not needed.

@neerajbachani
neerajbachani force-pushed the fix/85943-iou-leave-notfound-loop-fix branch from 148ab58 to 2e33e71 Compare May 1, 2026 17:06
@neerajbachani

Copy link
Copy Markdown
Contributor Author

@huult PR is ready for review

@huult

huult commented May 3, 2026

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@huult

huult commented May 3, 2026

Copy link
Copy Markdown
Contributor

@neerajbachani Could you check the video attachment? It looks like the video upload failed.

@neerajbachani

neerajbachani commented May 3, 2026 •

Copy link
Copy Markdown
Contributor Author

@huult I’ve attached videos for Android native and iOS native only, since the issue occurs exclusively on those platforms.

@huult

huult commented May 3, 2026

Copy link
Copy Markdown
Contributor

@neerajbachani We should record the video on all platforms because we need to verify them. This will help ensure there are no impacts and that everything works correctly. 👍

@huult

huult commented May 3, 2026

Copy link
Copy Markdown
Contributor

@neerajbachani Could you please sync up with the main branch?

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@huult Thanks for the feedback 👍

I’ll record and upload the remaining platform videos by today.

In the meantime, feel free to proceed with the Reviewer Checklist if everything else looks good, I’ll update the PR shortly with the remaining recordings.

@huult

huult commented May 3, 2026 •

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-05-03.at.16.54.32.mov

Hey @neerajbachani , can you reproduce this issue on the latest main? I mean without including your fix. I asked that because I can’t reproduce it anymore.

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@huult the issue us still repro but on leave instead of that 'not found error', the app just crash on latest main

Screenshot_2026-05-03-15-44-54-21_90edb837a44a3f9f6561096750424192

@huult

huult commented May 4, 2026 •

Copy link
Copy Markdown
Contributor

@neerajbachani Are you testing on the main branch? I also tested on main, but I couldn't reproduce the crash like in the video above.

@huult

huult commented May 5, 2026

Copy link
Copy Markdown
Contributor

@neerajbachani Can you merge main and check if the crash is still reproducible?

@neerajbachani

Copy link
Copy Markdown
Contributor Author

Apologies @huult for the delayed reply. While testing on the main branch, I noticed the error behavior is quite inconsistent, it occurs intermittently. I’ve been digging into the code and haven’t found any fix on the main branch that explicitly handles this case, so it’s possible the issue isn’t fully resolved yet. I’ll continue analyzing and debugging, and aim to identify a clear repro by today.

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@huult seems like we are good to close this issue as it works fine on main now!!

@neerajbachani

Copy link
Copy Markdown
Contributor Author

Tested on latest main and I’m not able to reproduce the original bug anymore.

What I validated

  1. Primary flow (issue repro)

    • Invitee opens invited IOU report
    • Invitee taps Leave
    • App redirects to an accessible destination:
      • Concierge when invitee is not a participant of the parent report
      • Workspace chat when invitee is a participant
    • No repeated “Hm... it’s not here” loop on Back, no app crash (which was happening 2 days back)
  2. Read-only expense report flow

    • Invitee opens invited IOU
    • Opens full expense report (read-only)
    • Opens invited IOU again
    • Taps Leave
    • Redirect happens immediately to Concierge/workspace chat
    • Back navigates to read-only expense report, then inbox
    • No navigation trap / no infinite loop

Based on current behavior, the original issue appears resolved on main, so can we close this issue @huult ?

@amyevans

amyevans commented May 8, 2026

Copy link
Copy Markdown
Contributor

Closing per the above

@amyevans amyevans closed this May 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants