Repository navigation
Fix/85943 iou leave notfound loop fix - #88804
neerajbachani wants to merge 4 commits into
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b368895704
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| const prevParentReport = getReportOrDraftReport(prevParentReportID); | ||
| if (isReportParticipant(currentUserAccountID, prevParentReport)) { | ||
| Navigation.isNavigationReady().then(() => { |
There was a problem hiding this comment.
Allow navigation to accessible non-participant parent reports
This new gate only checks isReportParticipant before navigating to prevParentReportID, but report access in this codebase is broader than participation (for example canCurrentUserOpenReport() explicitly allows public rooms in src/libs/ReportUtils.ts). As a result, users who can legitimately open the parent report but are not listed in participants (or when participants are omitted from a cached room object) will now be redirected to Concierge after leaving the child report, which is a regression from the prior behavior.
Useful? React with 👍 / 👎.
|
@huult quick question on process:
Would you allow a one-time history cleanup on this PR branch using:
to drop/re-sign only that bad commit and keep this same PR open? If you prefer no force-push, I’ll open a fresh branch/PR from latest |
|
@huult Gentle bump. thanks |
|
@neerajbachani let’s try this because we didn’t review or make changes, so history is not needed. |
148ab58 to
2e33e71
Compare
|
@huult PR is ready for review |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
@neerajbachani Could you check the video attachment? It looks like the video upload failed. |
|
@huult I’ve attached videos for Android native and iOS native only, since the issue occurs exclusively on those platforms. |
|
@neerajbachani We should record the video on all platforms because we need to verify them. This will help ensure there are no impacts and that everything works correctly. 👍 |
|
@neerajbachani Could you please sync up with the main branch? |
|
@huult Thanks for the feedback 👍 I’ll record and upload the remaining platform videos by today. In the meantime, feel free to proceed with the Reviewer Checklist if everything else looks good, I’ll update the PR shortly with the remaining recordings. |
Screen.Recording.2026-05-03.at.16.54.32.movHey @neerajbachani , can you reproduce this issue on the latest main? I mean without including your fix. I asked that because I can’t reproduce it anymore. |
|
@huult the issue us still repro but on leave instead of that 'not found error', the app just crash on latest main
|
|
@neerajbachani Are you testing on the main branch? I also tested on main, but I couldn't reproduce the crash like in the video above. |
|
@neerajbachani Can you merge main and check if the crash is still reproducible? |
|
Apologies @huult for the delayed reply. While testing on the main branch, I noticed the error behavior is quite inconsistent, it occurs intermittently. I’ve been digging into the code and haven’t found any fix on the main branch that explicitly handles this case, so it’s possible the issue isn’t fully resolved yet. I’ll continue analyzing and debugging, and aim to identify a clear repro by today. |
|
@huult seems like we are good to close this issue as it works fine on main now!! |
|
Tested on latest What I validated
Based on current behavior, the original issue appears resolved on |
|
Closing per the above |

Explanation of Change
This PR updates IOU leave navigation for invitees so we only navigate to a parent report when the current user is a participant of that parent report.
If the user is not a participant, we navigate to Concierge instead of routing to an inaccessible report, which prevents the repeated "Hm... it's not here" navigation loop.
It also removes the local
REPORT_USER_IS_LEAVING_ROOMwrite fromleaveRoom()to align with the reviewed scope.Fixed Issues
$ #85943
PROPOSAL: #85943 (comment)
Tests
More>Leave.Offline tests
More>Leave.QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
lv_0_20260417213146.1.mp4
Android: mWeb Chrome
<VIDEO_LINK_ANDROID_MWEB>
iOS: Native
lv_0_20260417194544.mp4
iOS: mWeb Safari
<VIDEO_LINK_IOS_MWEB>
MacOS: Chrome / Safari
<VIDEO_LINK_WEB_DESKTOP>