Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions src/pages/inbox/ReportNavigateAwayHandler.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,16 @@ import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
import Navigation, {navigationRef} from '@libs/Navigation/Navigation';
import type {PlatformStackRouteProp} from '@libs/Navigation/PlatformStackNavigation/types';
import {isDeletedParentAction} from '@libs/ReportActionsUtils';
import {isAdminRoom, isAnnounceRoom, isGroupChat, isMoneyRequest, isMoneyRequestReport, isMoneyRequestReportPendingDeletion, isPolicyExpenseChat} from '@libs/ReportUtils';
import {
isAdminRoom,
isAnnounceRoom,
isGroupChat,
isMoneyRequest,
isMoneyRequestReport,
isMoneyRequestReportPendingDeletion,
isPolicyExpenseChat,
isReportParticipant,
} from '@libs/ReportUtils';
import type {ReportsSplitNavigatorParamList, RightModalNavigatorParamList} from '@navigation/types';
import {setShouldShowComposeInput} from '@userActions/Composer';
import {navigateToConciergeChat} from '@userActions/Report';
Expand Down Expand Up @@ -81,6 +90,7 @@ function ReportNavigateAwayHandler() {

const isOptimisticDelete = report?.statusNum === CONST.REPORT.STATUS_NUM.CLOSED;
const {wasDeleted: reportWasDeleted, parentReportID: deletedReportParentID} = useReportWasDeleted(reportIDFromRoute, report, isOptimisticDelete, userLeavingStatus);
const [deletedReportParent] = useOnyx(`${ONYXKEYS.COLLECTION.REPORT}${getNonEmptyStringOnyxID(deletedReportParentID)}`);

// Track whether the current route is an own workspace chat. A vacation delegate split sends
// a temporary Onyx SET that wipes the report; by the time effects fire, report is undefined
Expand Down Expand Up @@ -216,6 +226,13 @@ function ReportNavigateAwayHandler() {

// Try to navigate to parent report if available
if (deletedReportParentID && !isMoneyRequestReportPendingDeletion(deletedReportParentID)) {
if (deletedReportParent && !isReportParticipant(currentUserAccountID, deletedReportParent)) {
Navigation.popToSidebar();
Navigation.isNavigationReady().then(() => {
navigateToConciergeChat(conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas);
});
return;
}
Navigation.isNavigationReady().then(() => {
Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(deletedReportParentID));
});
Expand All @@ -226,7 +243,18 @@ function ReportNavigateAwayHandler() {
Navigation.isNavigationReady().then(() => {
navigateToConciergeChat(conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas);
});
}, [reportWasDeleted, isFocused, deletedReportParentID, conciergeReportID, introSelected, currentUserAccountID, isSelfTourViewed, betas]);
}, [
reportWasDeleted,
isFocused,
deletedReportParentID,
deletedReportParent,
conciergeReportID,
introSelected,
currentUserAccountID,
isSelfTourViewed,
betas,
isCurrentRouteOwnWorkspaceChatRef,
]);

return null;
}
Expand Down
177 changes: 177 additions & 0 deletions tests/navigation/ReportNavigateAwayHandlerTest.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,177 @@
/* eslint-disable @typescript-eslint/naming-convention */
import {render, waitFor} from '@testing-library/react-native';
import React from 'react';
import useIsOwnWorkspaceChatRef from '@hooks/useIsOwnWorkspaceChatRef';
import useOnyx from '@hooks/useOnyx';
import Navigation from '@libs/Navigation/Navigation';
import {navigateToConciergeChat} from '@userActions/Report';
import ONYXKEYS from '@src/ONYXKEYS';
import useReportWasDeleted from '@src/pages/inbox/hooks/useReportWasDeleted';
import ReportNavigateAwayHandler from '@src/pages/inbox/ReportNavigateAwayHandler';

jest.mock('@react-navigation/native', () => ({
createNavigationContainerRef: jest.fn(() => ({
current: null,
dispatch: jest.fn(),
canGoBack: jest.fn(),
getRootState: jest.fn(),
getCurrentRoute: jest.fn(),
})),
useIsFocused: jest.fn(() => true),
useRoute: jest.fn(() => ({
name: 'Report',
params: {
reportID: '123',
},
})),
}));

jest.mock('@hooks/useCurrentReportID', () => ({
useCurrentReportIDState: jest.fn(() => ({currentReportID: '123'})),
}));

jest.mock('@hooks/useCurrentUserPersonalDetails', () => ({
__esModule: true,
default: jest.fn(() => ({accountID: 1})),
}));

jest.mock('@hooks/useResponsiveLayout', () => ({
__esModule: true,
default: jest.fn(() => ({isInNarrowPaneModal: false})),
}));

jest.mock('@hooks/useParentReportAction', () => ({
__esModule: true,
default: jest.fn(() => undefined),
}));

jest.mock('@hooks/useIsOwnWorkspaceChatRef', () => ({
__esModule: true,
default: jest.fn(() => ({current: false})),
}));

jest.mock('@userActions/Composer', () => ({
setShouldShowComposeInput: jest.fn(),
}));

jest.mock('@userActions/Report', () => ({
navigateToConciergeChat: jest.fn(),
}));

jest.mock('@src/pages/inbox/hooks/useReportWasDeleted', () => jest.fn());

jest.mock('@hooks/useOnyx', () => jest.fn());

jest.mock('@libs/Navigation/Navigation', () => ({
__esModule: true,
default: {
dismissModal: jest.fn(),
getTopmostReportId: jest.fn(() => 'different-report-id'),
getTopmostSearchReportID: jest.fn(() => undefined),
popToSidebar: jest.fn(),
navigate: jest.fn(),
isNavigationReady: jest.fn(() => Promise.resolve()),
},
navigationRef: {
getCurrentRoute: jest.fn(() => ({name: 'Report', params: {reportID: '123'}})),
},
}));

type MinimalReport = {
reportID?: string;
participants?: Record<number, {notificationPreference?: string}>;
statusNum?: number;
};

let deletedParentReport: MinimalReport | undefined;
let deletedReportParentID: string | undefined;
let reportWasDeleted = true;

const mockUseOnyx = jest.mocked(useOnyx);
const mockUseReportWasDeleted = jest.mocked(useReportWasDeleted);
const mockNavigateToConciergeChat = jest.mocked(navigateToConciergeChat);
const mockNavigation = jest.mocked(Navigation);
const onyxMeta = {status: 'loaded'} as const;

describe('ReportNavigateAwayHandler', () => {
beforeEach(() => {
jest.clearAllMocks();
deletedParentReport = undefined;
deletedReportParentID = 'parentReportID';
reportWasDeleted = true;

mockUseReportWasDeleted.mockReturnValue({
wasDeleted: reportWasDeleted,
parentReportID: deletedReportParentID,
});

mockUseOnyx.mockImplementation((key: string) => {
if (key === `${ONYXKEYS.COLLECTION.REPORT}123`) {
return [{reportID: '123', statusNum: 2} as MinimalReport, onyxMeta];
}
if (key === `${ONYXKEYS.COLLECTION.REPORT_USER_IS_LEAVING_ROOM}123`) {
return [false, onyxMeta];
}
if (key === ONYXKEYS.NVP_INTRO_SELECTED) {
return [undefined, onyxMeta];
}
if (key === ONYXKEYS.BETAS) {
return [[], onyxMeta];
}
if (key === ONYXKEYS.NVP_ONBOARDING) {
return [{selfTourViewed: true}, onyxMeta];
}
if (key === ONYXKEYS.CONCIERGE_REPORT_ID) {
return ['conciergeReportID', onyxMeta];
}
if (key === `${ONYXKEYS.COLLECTION.REPORT}parentReportID`) {
return [deletedParentReport, onyxMeta];
}
return [undefined, onyxMeta];
});
});

it('navigates to concierge when deleted parent exists but user is not a participant', async () => {
const participants: Record<number, {notificationPreference?: string}> = {};
participants[999] = {};
deletedParentReport = {reportID: 'parentReportID', participants};

render(<ReportNavigateAwayHandler />);

await waitFor(() => {
expect(mockNavigation.popToSidebar).toHaveBeenCalledTimes(1);
expect(mockNavigateToConciergeChat).toHaveBeenCalledTimes(1);
});

expect(mockNavigation.navigate).not.toHaveBeenCalled();
});

it('navigates to deleted parent when user is a participant', async () => {
const participants: Record<number, {notificationPreference?: string}> = {};
participants[1] = {};
deletedParentReport = {reportID: 'parentReportID', participants};

render(<ReportNavigateAwayHandler />);

await waitFor(() => {
expect(mockNavigation.navigate).toHaveBeenCalledWith(expect.stringContaining('parentReportID'));
});

expect(mockNavigation.popToSidebar).not.toHaveBeenCalled();
expect(mockNavigateToConciergeChat).not.toHaveBeenCalled();
});

it('does not navigate away when own workspace chat ref is true', async () => {
const mockUseIsOwnWorkspaceChatRef = jest.mocked(useIsOwnWorkspaceChatRef);
mockUseIsOwnWorkspaceChatRef.mockReturnValue({current: true});
const participants: Record<number, {notificationPreference?: string}> = {};
participants[999] = {};
deletedParentReport = {reportID: 'parentReportID', participants};

render(<ReportNavigateAwayHandler />);

expect(mockNavigation.popToSidebar).not.toHaveBeenCalled();
expect(mockNavigation.navigate).not.toHaveBeenCalled();
expect(mockNavigateToConciergeChat).not.toHaveBeenCalled();
});
});
Loading