Repository navigation
[No QA] Update help site deployment actions to build site manually - #88917
Conversation
|
A preview of your ExpensifyHelp changes have been deployed to https://5344d2c0.helpdot.pages.dev ⚡️ |
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.62-13 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.63-1 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to staging by https://github.com/pecanoro in version: 9.3.64-0 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Deployed to production by https://github.com/arosiclair in version: 9.3.64-31 🚀
|
| uses: actions/jekyll-build-pages@0143c158f4fa0c5dcd99499a5d00859d79f70b0e | ||
| - name: Set up Ruby | ||
| # v1.306.0 | ||
| uses: ruby/setup-ruby@c4e5b1316158f92e3d49443a9d58b31d25ac0f8f |
There was a problem hiding this comment.
The previous actions/jekyll-build-pages@0143c158f4fa0c5dcd99499a5d00859d79f70b0e has JEKYLL_ENV="production"
https://github.com/actions/jekyll-build-pages/blob/0143c158f4fa0c5dcd99499a5d00859d79f70b0e/entrypoint.sh#L22
Btw changing to the new build flow, it breaks some logics in the help page. We fixed it here #96323
Explanation of Change
Gemfile.lockusingbundle lock --add-platform x86_64-linuxto allow running the workflow on Linux machine(Github actions).csvandbase64Fixed Issues
$ https://github.com/Expensify/Expensify/issues/627773
PROPOSAL:
Tests
Ensured "Deploy ExpensifyHelp" workflow succeeds https://github.com/Expensify/App/actions/runs/24993285531/job/73183861487?pr=88917
Verified the page source has latest jekyll 4.3.4
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari