Repository navigation
[Non-fork] Web - Help site - Send a message button open error page - #96323
Merged
Merged
Conversation
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
43 tasks done
This comment has been minimized.
This comment has been minimized.
NicolasBonet
force-pushed
the
nicolas-fix-95607-nonfork
branch
from
July 16, 2026 23:23
6e310d8 to
0dac4cf
Compare
Contributor
Reviewer Checklist
Screenshots/VideosScreen.Recording.2026-07-17.at.16.59.14.mov |
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://39238e44.helpdot.pages.dev ⚡️ |
deetergp
approved these changes
Jul 21, 2026
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
49 tasks done
Contributor
|
🚀 Deployed to staging by https://github.com/deetergp in version: 9.4.42-0 🚀
|
Closed
2 of 7 tasks
Contributor
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.4.42-1 🚀
Bundle Size Analysis (Sentry): |
52 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a non-fork copy of #96220 by @lorretheboy, created so the ExpensifyHelp deploy workflow can run for testing (requested in #96220 (comment)). All credit to the original author — the commit is cherry-picked with authorship preserved.
Explanation of Change
Sets
JEKYLL_ENV: productionwhen building the Jekyll site in thedeployExpensifyHelpworkflow, so the Help site is built with production configuration and the "Send a message" button links resolve correctly instead of opening an error page.Fixed Issues
$ #95607
PROPOSAL: #95607 (comment)
Tests
Offline tests
N/A — CI workflow change only.
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-07-15.at.16.29.03.mov