Repository navigation
[NO QA] Surface Travel provisioning errors on the terms screen instead of failing silently - #94074
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90a0fc7a44
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@heyjennahay @ikevin127 please ignore the ping |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.4.21-2 🚀
|
|
🚀 Deployed to production by https://github.com/mountiny in version: 9.4.21-9 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
When enabling Expensify Travel on a workspace, agreeing to the terms can fail on the backend — most commonly because the workspace has no address — but today nothing is shown to the user. They tap Continue and the screen just sits there, with no error and no idea what went wrong.
This surfaces those failures: the terms screen now shows the error message returned by the backend (e.g. "Please add a workspace address to enable Expensify Travel") instead of silently swallowing it. Previously the screen hid its inline error whenever the backend returned an error code, so ~5 of the 7 possible provisioning errors produced no visible feedback at all.
The displayable message is provided by the backend; the frontend just reads and renders the
travelProvisioningOnyx error. No navigation or other special handling — the error is simply shown.Important
[HOLD] Depends on Web-Expensify PR https://github.com/Expensify/Web-Expensify/pull/53871, which returns the error message in the API response. That must be merged/deployed first.
Fixed Issues
$ #93997
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
– written by Claude on Ben's behalf