Repository navigation
Conversation
Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://1c374255.helpdot.pages.dev ⚡️ Updated articles: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change
Expensify/App#94074 makes the Travel terms screen surface backend provisioning errors that were previously swallowed silently. The most common of those errors is a missing workspace address, which the app reports as "A Workspace Address is required to enable Expensify Travel."
That prerequisite is now visible to users but isn't documented anywhere on the help site. This adds an FAQ entry to the Enable Expensify Travel on a workspace article explaining the requirement and how to add a company address.
What changed
## Why can’t I enable Expensify Travel?FAQ todocs/articles/travel/company-setup/Enable-Travel-on-a-Workspace.mdcovering the company address requirement and the steps to add one.UI verification
All labels were verified against the App source:
common.companyAddress→ "Company address")A Workspace Address is required to enable Expensify Travel(workspace.editor.addressContext)Scope notes
The source PR mentions ~7 possible provisioning errors, but only the company-address requirement is a stable, user-actionable prerequisite confirmed in the product UI. The other backend errors are not documented here because their messages are backend-controlled and not individually verifiable from the App source.
@blimpich, please review the files changed and confirm they reflect the current behavior. Then mark this PR
Ready for review.