Skip to content

Use a new command for dismissing the product marketing window - #97960

Merged
JS00001 merged 16 commits into
mainfrom
jsenyitko-new-command-for-dismissing-marketing-window
Aug 20, 2026
Merged

JS00001 merged 16 commits into
mainfrom
jsenyitko-new-command-for-dismissing-marketing-window

Conversation

@JS00001

@JS00001 JS00001 commented Aug 6, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Updates product marketing window dismissal to use a new command DismissMarketingWindow. Also fixes a bug where stale clients could mark future marketing windows as unseen, even if they were previously seen

Fixed Issues

$ #95791 (comment)

Tests

  • Run the same tests expected for the new bottom right product marketing window to work.
  • Login to an old device, which has not viewed the July product update (but will be shown it). This device should not be on the latest app version (which has the august product update)
  • Navigate to the web version of the app, and view the august product update
  • Reopen the app that is on the older version, and ensure that the july product update does not show up again

Internal QA

  • Supportal into an account, and dismiss the product marketing update
  • Ensure that the lastSeenMarketingWindow nvp is not updated by the support user
  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-08-06.at.7.35.59.AM.mov

@JS00001

JS00001 commented Aug 6, 2026

Copy link
Copy Markdown
Contributor Author

@JS00001 JS00001 changed the title Use a new command for dismissing the product marketing window [Hold] Use a new command for dismissing the product marketing window Aug 6, 2026
@JS00001 JS00001 changed the title [Hold] Use a new command for dismissing the product marketing window Use a new command for dismissing the product marketing window Aug 19, 2026
@JS00001
JS00001 marked this pull request as ready for review August 19, 2026 11:47
@JS00001
JS00001 requested review from a team as code owners August 19, 2026 11:47
@melvin-bot
melvin-bot Bot requested review from heyjennahay and huult and removed request for a team August 19, 2026 11:47
@melvin-bot

melvin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested a review from a team August 19, 2026 11:47
@JS00001

JS00001 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

@huult can you review this one please?

@melvin-bot
melvin-bot Bot requested review from chuckdries and removed request for a team August 19, 2026 11:48
@melvin-bot

melvin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@huult

huult commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

yes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75f714d238

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread src/libs/actions/User.ts Resolved
@huult

huult commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2026-08-20.at.11.40.45.mp4
Android: mWeb Chrome
Screen.Recording.2026-08-20.at.11.42.31.mp4
iOS: HybridApp
Screen.Recording.2026-08-20.at.11.48.48.mp4
iOS: mWeb Safari
Screen.Recording.2026-08-20.at.11.50.15.mp4
MacOS: Chrome / Safari
Screen.Recording.2026-08-20.at.11.35.42.mov

@huult

huult commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@JS00001 Could you check the failed unit tests?

@JS00001

JS00001 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

No, I'll update it. Also, fixing some things we discussed in slack, so hold on another approval from @huult please

@JS00001
JS00001 requested a review from huult August 20, 2026 14:22
@JS00001

JS00001 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

this should be ready @huult

@huult

huult commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Yes

@huult

This comment was marked as resolved.

@huult

huult commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
Screen.Recording.2026-08-20.at.22.00.53.mov

@JS00001 I think it’s good. I tested it using both the old and new app versions, and I was able to dismiss the modal successfully.

@huult

huult commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@JS00001 could you sync with main?

@JS00001

JS00001 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Thanks! Updated

@huult

huult commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

@chuckdries all yours

@chuckdries

Copy link
Copy Markdown
Contributor

@JS00001 approved. Please update the description with more detailed test/qa steps before merging

@JS00001
JS00001 merged commit a649766 into main Aug 20, 2026
46 of 47 checks passed
@JS00001
JS00001 deleted the jsenyitko-new-command-for-dismissing-marketing-window branch August 20, 2026 15:52
@github-actions

Copy link
Copy Markdown
Contributor

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Aug 21, 2026
55 tasks done
@m-natarajan

Copy link
Copy Markdown

@JS00001 @huult Can you please simplify the QA steps, Not sure how we can validate the steps mentioned as this requires older version which have not viewed the update.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.58-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

No help site changes required

I reviewed this PR against the help site content in App/docs/articles and no documentation updates are needed.

Why: This is a purely internal, technical change to the in-app product marketing window (the announcement popup shown on Home):

  • Switches dismissal persistence from the generic setNameValuePair to a dedicated DismissMarketingWindow write command.
  • Fixes a bug where stale/older clients could re-mark a future marketing window as unseen after it had already been seen on a newer client.

None of this changes a user-facing feature, setting, tab, button, or workflow that the help site documents. The product marketing window itself is not described in any help article — the only related content is a link to the external Expensify Product Updates blog, which is unaffected. Because there are no help-site changes to make, I did not create a draft PR.

JS00001 — if you believe a help article should exist for this feature (e.g. documenting the announcement popup itself), let me know and I can draft one.


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #99134 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #99136 was identified to be related to this PR.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #99137 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #99139 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.58-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants