Repository navigation
Use a new command for dismissing the product marketing window - #97960
Conversation
…mmand-for-dismissing-marketing-window
…mmand-for-dismissing-marketing-window
|
@huult can you review this one please? |
|
@chuckdries Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
yes |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75f714d238
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-08-20.at.11.40.45.mp4Android: mWeb ChromeScreen.Recording.2026-08-20.at.11.42.31.mp4iOS: HybridAppScreen.Recording.2026-08-20.at.11.48.48.mp4iOS: mWeb SafariScreen.Recording.2026-08-20.at.11.50.15.mp4MacOS: Chrome / SafariScreen.Recording.2026-08-20.at.11.35.42.mov |
|
@JS00001 Could you check the failed unit tests? |
…mmand-for-dismissing-marketing-window
|
No, I'll update it. Also, fixing some things we discussed in slack, so hold on another approval from @huult please |
|
this should be ready @huult |
|
Yes |
This comment was marked as resolved.
This comment was marked as resolved.
Screen.Recording.2026-08-20.at.22.00.53.mov@JS00001 I think it’s good. I tested it using both the old and new app versions, and I was able to dismiss the modal successfully. |
|
@JS00001 could you sync with main? |
…mmand-for-dismissing-marketing-window
|
Thanks! Updated |
|
@chuckdries all yours |
|
@JS00001 approved. Please update the description with more detailed test/qa steps before merging |
|
🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/JS00001 in version: 9.4.58-0 🚀
|
No help site changes requiredI reviewed this PR against the help site content in Why: This is a purely internal, technical change to the in-app product marketing window (the announcement popup shown on Home):
None of this changes a user-facing feature, setting, tab, button, or workflow that the help site documents. The product marketing window itself is not described in any help article — the only related content is a link to the external Expensify Product Updates blog, which is unaffected. Because there are no help-site changes to make, I did not create a draft PR.
|
|
Deploy Blocker #99134 was identified to be related to this PR. |
|
Deploy Blocker #99136 was identified to be related to this PR. |
|
Deploy Blocker #99137 was identified to be related to this PR. |
|
Deploy Blocker #99139 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.58-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Updates product marketing window dismissal to use a new command
DismissMarketingWindow. Also fixes a bug where stale clients could mark future marketing windows as unseen, even if they were previously seenFixed Issues
$ #95791 (comment)
Tests
Internal QA
lastSeenMarketingWindownvp is not updated by the support userOffline tests
N/A
QA Steps
Same as tests
PR Author Checklist
Reviewer Checklist
### Fixed Issuessection aboveTestssectionQA stepssectiontoggleReportand notonIconClick).Avatar, I verified the components usingAvatarhave been tested & I retested again)/** comment above it */thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor)thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Screen.Recording.2026-08-06.at.7.35.59.AM.mov