Skip to content

Clean up composer footer and match action buttons to the emoji button - #98781

Merged
mollfpr merged 10 commits into
mainfrom
shawn-composer
Aug 20, 2026
Merged

mollfpr merged 10 commits into
mainfrom
shawn-composer

Conversation

@shawnborton

@shawnborton shawnborton commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Cleans up the composer footer (the "Write something…" box at the bottom of every chat) and makes its action buttons consistent with the emoji and send buttons.

  • Removed the vertical divider (textInputComposeBorder) between the create (+) button and the text input, in both the live composer and the loading placeholder.
  • Restyled the create (+) button to match the emoji button exactly: PressableWithoutFeedback with a hover/pressed background color (getButtonBackgroundColorStyle) instead of the old opacity dim, and a dynamic icon fill (getIconFillColor).
  • Applied the same treatment to the expand/collapse button.
  • Grew the shared composerSizeButton from 32×32 to 40×40 and centered its icon (alignItems: 'center'), so the create, expand/collapse, and message-edit cancel buttons all match the 40px emoji/send buttons.
  • Anchored the create button to the bottom of the composer at all times (justifyContentStart in a reversed column), matching the emoji and send buttons, instead of only when the expand button is present.
  • Trimmed 8px of left padding from the composer text input so the text sits closer to the enlarged create button.

Note: composerSizeButton and textInputCompose are shared with the inline message-edit composer, so those buttons/input are updated consistently there too. Adding the Design label so @Expensify/design can review.

Fixed Issues

$ #98809
PROPOSAL:

Tests

  1. Open any chat and focus the composer at the bottom.
  2. Verify there is no vertical divider line between the + button and the text input.
  3. Hover the + button — verify it shows a background color and icon-fill change identical to the emoji button on the right (no opacity dim).
  4. Verify the + button is 40×40 with its icon centered, matching the emoji and send buttons.
  5. Type a couple of lines — verify the + button stays anchored to the bottom of the composer.
  6. Expand the composer (expand button) — verify the expand/collapse button has the same hover background and 40×40 size, and the + button remains bottom-anchored.
  7. Edit a sent message — verify the cancel (X) and expand buttons in the edit composer match the same size/hover treatment.
  8. Verify that no errors appear in the JS console.
  • Verify that no errors appear in the JS console

Offline tests

Not applicable — style-only change with no network behavior.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Aug 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
src/components/EmojiPicker/EmojiPickerButton.tsx 85.00% <100.00%> (+0.78%) ⬆️
...ortActionCompose/AttachmentPickerWithMenuItems.tsx 85.58% <100.00%> (+0.53%) ⬆️
...rt/ReportActionCompose/ComposerWithSuggestions.tsx 61.20% <ø> (ø)
...eport/ReportActionCompose/ExpandCollapseButton.tsx 100.00% <100.00%> (ø)
...rt/ReportActionCompose/MessageEditCancelButton.tsx 100.00% <100.00%> (ø)
...pages/inbox/report/ReportActionItemMessageEdit.tsx 58.33% <ø> (ø)
src/styles/index.ts 63.00% <ø> (ø)
src/styles/variables.ts 100.00% <ø> (ø)
...report/ReportActionCompose/ComposerPlaceholder.tsx 0.00% <0.00%> (ø)
... and 119 files with indirect coverage changes

@shawnborton

Copy link
Copy Markdown
Contributor Author

cc @dubielzyk-expensify to check this one out - this cleans up the composer's create and expand/collapse buttons to match the emoji button. It gets rid of the border as well:

CleanShot.2026-08-17.at.12.43.47.mp4

@github-actions

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Tested on web and iOS. Can we triple check that the text has the same padding from the left edge? Seeing the composer placeholder and a message it doesn't quite look like they add up to the same x pixel position:

CleanShot 2026-08-18 at 09 14 01@2x

Otherwise this feels great

@shawnborton

Copy link
Copy Markdown
Contributor Author

Good catch, let me dig into that!

@shawnborton

Copy link
Copy Markdown
Contributor Author

I think it is indeed off by 1px:
CleanShot 2026-08-17 at 20 02 16@2x

I will push a fix.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 shawnborton has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Is it still off?

CleanShot 2026-08-18 at 10 31 04@2x

@shawnborton

Copy link
Copy Markdown
Contributor Author

Maybe you need a hard refresh? This is what I see:
CleanShot 2026-08-17 at 20 40 04@2x

@shawnborton
shawnborton marked this pull request as ready for review August 18, 2026 00:58
@shawnborton
shawnborton requested review from a team as code owners August 18, 2026 00:58
@melvin-bot
melvin-bot Bot requested review from Eskalifer1 and garrettmknight and removed request for a team August 18, 2026 00:58
@melvin-bot

melvin-bot Bot commented Aug 18, 2026

Copy link
Copy Markdown

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 18, 2026 00:58
@shawnborton

Copy link
Copy Markdown
Contributor Author

@Eskalifer1 can you help with platform screenshots since this is a Claude/Melvin PR? Thanks!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8607581876

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

];

const textInputStyle = [styles.textInputComposeSpacing, styles.textInputComposeBorder, {paddingVertical: 0}];
const textInputStyle = [styles.textInputComposeSpacing, {paddingVertical: 0}];

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep the deferred composer placeholder aligned

When ComposerPlaceholder appears during a navigation transition, it still centers the plus icon and applies variables.avatarChatSpacing (12px) on both sides of its text, while the real composer now bottom-aligns the plus button and uses the new 5px left padding. Swapping in the real composer therefore visibly shifts the placeholder text horizontally and the plus icon vertically; update the placeholder's manual styles to mirror both new layout values.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment here: #98781 (review)

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

I did a hard refresh but maybe something went wrong. Looks good now 👍 Send it!

@Eskalifer1

Eskalifer1 commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
98781-android-native.mov
Android: mWeb Chrome
98781-android-web.mov
iOS: HybridApp
98781-ios-native.mov
iOS: mWeb Safari
98781-ios-web.mov
MacOS: Chrome / Safari
98781-web.mov

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When editing a comment, the old styles are still there, and it looks like the button has shifted out of place. Also, the close button doesn't have a hover effect

Image

@garrettmknight
garrettmknight removed their request for review August 18, 2026 15:55
@shawnborton

Copy link
Copy Markdown
Contributor Author

Everything should be fixed now:

  • placeholder alignment in loading composer
  • edit mode buttons are updated
  • no more hover states for buttons in disabled composer

Please give it another round of testing @Eskalifer1

@Eskalifer1

Copy link
Copy Markdown
Contributor

In this PR, when editing a 3-line message, we get this appearance. I’m not sure how to describe it correctly, but you can check for yourself—it looks like something’s off.

image

@Eskalifer1

Copy link
Copy Markdown
Contributor

I think this is probably fine?

All right, essentially, due to changes in this PR, the Expand button appears one line later than before. On the web, it moves from 3 lines to 4 (I suspect the button wouldn’t have fit on 3 lines on the web version anyway). And on the native version, it moves from 4 lines to 5.

@shawnborton

Copy link
Copy Markdown
Contributor Author

In this PR, when editing a 3-line message, we get this appearance. I’m not sure how to describe it correctly, but you can check for yourself—it looks like something’s off.

That looks technically correct to me. I think we're good?

@Eskalifer1

Copy link
Copy Markdown
Contributor

@codex review

@Eskalifer1

Copy link
Copy Markdown
Contributor

Okay, let's fix ofmt check @shawnborton!

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 39d166b678

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

// Keep focus on the composer when Collapse/Expand button is clicked.
onMouseDown={(e) => e.preventDefault()}
style={styles.composerSizeButton}
style={({hovered, pressed}) => [styles.composerSizeButton, StyleUtils.getButtonBackgroundColorStyle(getButtonState(hovered, pressed))]}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Suppress hover styling while expand is disabled

When the composer is disabled—for example, a blocked Concierge chat retaining a multiline or full-size composer—the expand/collapse control still receives hovered from GenericPressable, because disabled suppresses activation but not pointer hover tracking. Passing that state directly to getButtonState() makes this disabled button display the active background and icon color, unlike the emoji and create buttons updated in this commit, falsely suggesting it is actionable; gate both hover/pressed values on !disabled here as well.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I noticed that too, but I'm not sure we can have that in the actual workflow.

In any case we can also fix that

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MelvinBot can you fix please?

Co-authored-by: Shawn Borton <shawnborton@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor

Fixed the Oxfmt check failure and pushed to shawn-composer (f0717e9).

The check runs npm run fmt and fails on any diff. One line in AttachmentPickerWithMenuItems.tsx (the + button's inline style array) exceeded the print width, so oxfmt wanted it wrapped across multiple lines — pure formatting, no behavior change.

The other two red checks aren't code issues to fix here: Check independent approval and PR Author Checklist / checklist are review/approval gates, not test failures.

@Eskalifer1 Eskalifer1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@melvin-bot
melvin-bot Bot requested a review from mollfpr August 19, 2026 19:45
@melvin-bot

melvin-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

@mollfpr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mollfpr
mollfpr merged commit dee520c into main Aug 20, 2026
44 of 46 checks passed
@mollfpr
mollfpr deleted the shawn-composer branch August 20, 2026 13:27
@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions

Copy link
Copy Markdown
Contributor

🚧 mollfpr has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify OSBotify mentioned this pull request Aug 21, 2026
55 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/mollfpr in version: 9.4.58-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 No help site changes required.

I reviewed the changes in this PR against the help site files under docs/articles, applying HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

This is a style-only change to the composer footer (the "Write something…" box). It removes the vertical divider next to the create (+) button, restyles/resizes the create and expand-collapse buttons to match the emoji and send buttons (32×32 → 40×40, hover background instead of opacity dim), and trims some padding. No feature, behavior, workflow, label, tab name, or button label changes — the + button still exists and does exactly what it did before.

Why no article needs updating
  • The help site documents features, settings, and workflows — not pixel sizes, dividers, or hover styling of a chat button.
  • The only close match, Navigating-New-Expensify.md, documents the global navigation ➕ Create button (create a report, send money, track distance), which is a different button from the composer's + and is untouched by this PR.
  • Chat-Features-and-Moderation-Tools.md references the Write something field but describes no composer-button styling that this change would affect.

Because nothing needs to change, I did not open a draft help site PR (and there's no linked help site PR to mark Ready for review). If you'd like an article to explicitly cover the composer footer buttons anyway, let me know and I'll draft one.


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #99143 was identified to be related to this PR.

@jponikarchuk

Copy link
Copy Markdown

Deploy Blocker #99155 was identified to be related to this PR.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.58-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants