Repository navigation
[NO QA] Add Expensify Visa Commercial Card press release to Home announcements - #98803
Conversation
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
🤖 I looked into the failing checks — there's no code failure to fix here. The only check reporting Every substantive check that a code change could actually break is green:
The remaining Next step: this just needs an independent reviewer to approve. Nothing to push. |
|
@MelvinBot the title in the "Announcements" section should be "The Expensify Card: Proactive spend controls" and the oldest announcement should be removed from the section so there are only max 3 announcements total. |
Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
|
🤖 Done — pushed to
Change is in Checks: ESLint passed (0 errors). UI verification not completed: the prestarted web test session was stuck on a blank page (dev server itself was healthy), which is a session-health issue on the CI side rather than anything in this change — so I couldn't capture a live screenshot of the Announcements section. Worth a quick manual sanity check on Home once the branch builds. |
|
🤖 I re-checked after the latest commit ( The only check reporting Every substantive check that a code change could break is green on the latest commit:
The only checks still running are Next step: this just needs an independent reviewer to approve. Nothing to push. |
|
@robertjchen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / Safari |
|
🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/robertjchen in version: 9.4.56-0 🚀
|
|
🤖 No help site changes required. This PR only swaps one entry in the hardcoded The only help article touching this area is Expensify-Home-Overview.md, which describes the Announcements section generically ("shows recent Expensify product updates") without listing individual entries. Since it doesn't enumerate specific announcements, adding/removing a press-release link doesn't affect anything documented there. No draft PR was created because there is nothing to update. @jamesdeanexpensify, please confirm you agree no help site changes are needed here. If you'd like an article to document specific announcements (which isn't the case today), let me know and I'll draft one. |
|
@jponikarchuk @mitarachim sorry, not an engineer, but can I help somehow? |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Adds the "The Expensify Visa Commercial Card Brings New Proactive Spend Controls to 14 Countries" press release to the Announcements section of the Home tab. Home announcements are hardcoded in
CONST.HOME.ANNOUNCEMENTS, so this adds a new entry (title,Press releasesubtitle, the businesswire URL, and a2026-08-17published date). TheAnnouncementSectionsorts bypublishedDatedescending, so this shows at the top.Requested by
jamesdeanexpensify.Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari