Skip to content

[NO QA] Add Expensify Visa Commercial Card press release to Home announcements - #98803

Merged
robertjchen merged 2 commits into
mainfrom
claude-addVisaCommercialCardAnnouncement
Aug 18, 2026
Merged

robertjchen merged 2 commits into
mainfrom
claude-addVisaCommercialCardAnnouncement

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

Adds the "The Expensify Visa Commercial Card Brings New Proactive Spend Controls to 14 Countries" press release to the Announcements section of the Home tab. Home announcements are hardcoded in CONST.HOME.ANNOUNCEMENTS, so this adds a new entry (title, Press release subtitle, the businesswire URL, and a 2026-08-17 published date). The AnnouncementSection sorts by publishedDate descending, so this shows at the top.

Requested by jamesdeanexpensify.

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
@MelvinBot
MelvinBot requested a review from a team August 17, 2026 21:16
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I looked into the failing checks — there's no code failure to fix here.

The only check reporting fail is Check independent approval, which fails simply because the PR hasn't been approved by an independent reviewer yet. It's a process/approval gate, not a code problem, and it clears once a reviewer approves.

Every substantive check that a code change could actually break is green:

  • ✅ typecheck, test (jobs 1–8), ESLint check, Oxfmt check, spellcheck, Storybook tests, Bun tests, React Compiler Compliance, Check for unused styles

The remaining build (…) and *-perf-tests checks were still running when I looked. This PR only adds one data entry to src/CONST/index.ts (a new CONST.HOME.ANNOUNCEMENTS object with the exact same shape as the existing entries), so it can't affect the build or perf output — those are expected to pass.

Next step: this just needs an independent reviewer to approve. Nothing to push.

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@MelvinBot the title in the "Announcements" section should be "The Expensify Card: Proactive spend controls" and the oldest announcement should be removed from the section so there are only max 3 announcements total.

Co-authored-by: James Dean <jamesdeanexpensify@users.noreply.github.com>
@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 Done — pushed to claude-addVisaCommercialCardAnnouncement.

  • Renamed the new announcement's title to The Expensify Card: Proactive spend controls
  • Removed the oldest announcement (New feature: Consolidated travel billing, 2026-07-13), leaving 3 total

Change is in src/CONST/index.ts:9462 (CONST.HOME.ANNOUNCEMENTS). The section sorts by publishedDate descending, so the renamed entry (2026-08-17) stays at the top.

Checks: ESLint passed (0 errors). tsc couldn't run in this environment, but the edit only changes a string literal and drops one array element of identical shape, so it's type-safe by construction.

UI verification not completed: the prestarted web test session was stuck on a blank page (dev server itself was healthy), which is a session-health issue on the CI side rather than anything in this change — so I couldn't capture a live screenshot of the Announcements section. Worth a quick manual sanity check on Home once the branch builds.

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 I re-checked after the latest commit (9049fe38, "Update announcement title and cap announcements at 3") — there's still no code failure to fix.

The only check reporting fail is Check independent approval, which is a review/approval gate, not a code problem. It clears once an independent reviewer approves the PR.

Every substantive check that a code change could break is green on the latest commit:

  • ✅ typecheck, test (jobs 1–8), ESLint check, Oxfmt check, spellcheck, Storybook tests, Bun tests

The only checks still running are build (…) and *-perf-tests. This PR only edits data in src/CONST/index.ts (the CONST.HOME.ANNOUNCEMENTS array), so it can't affect the build or perf output — those are expected to pass.

Next step: this just needs an independent reviewer to approve. Nothing to push.

@jamesdeanexpensify
jamesdeanexpensify marked this pull request as ready for review August 17, 2026 21:46
@jamesdeanexpensify
jamesdeanexpensify requested a review from a team as a code owner August 17, 2026 21:46
@melvin-bot
melvin-bot Bot requested review from heyjennahay and robertjchen and removed request for a team August 17, 2026 21:46
@melvin-bot

melvin-bot Bot commented Aug 17, 2026

Copy link
Copy Markdown

@robertjchen Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@jamesdeanexpensify jamesdeanexpensify changed the title Add Expensify Visa Commercial Card press release to Home announcements [NO QA] Add Expensify Visa Commercial Card press release to Home announcements Aug 17, 2026
@robertjchen

robertjchen commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari

@robertjchen
robertjchen merged commit eb861f7 into main Aug 18, 2026
48 of 49 checks passed
@robertjchen
robertjchen deleted the claude-addVisaCommercialCardAnnouncement branch August 18, 2026 06:32
@github-actions

Copy link
Copy Markdown
Contributor

🚧 robertjchen has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/robertjchen in version: 9.4.56-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor Author

🤖 No help site changes required.

This PR only swaps one entry in the hardcoded CONST.HOME.ANNOUNCEMENTS list — adding the "The Expensify Card: Proactive spend controls" press release (src/CONST/index.ts:9463) and dropping the older "Consolidated travel billing" entry. It's a content-only change to the marketing announcements feed on the Home tab, not a product-behavior change.

The only help article touching this area is Expensify-Home-Overview.md, which describes the Announcements section generically ("shows recent Expensify product updates") without listing individual entries. Since it doesn't enumerate specific announcements, adding/removing a press-release link doesn't affect anything documented there.

No draft PR was created because there is nothing to update.

@jamesdeanexpensify, please confirm you agree no help site changes are needed here. If you'd like an article to document specific announcements (which isn't the case today), let me know and I'll draft one.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker issue #98934 is repro on all PRs. Could you please double check if it's not introduced by #98803

@jponikarchuk

jponikarchuk commented Aug 19, 2026 •

Copy link
Copy Markdown

The Deploy Blocker issue #98998 is repro on all PRs. Could you please double check if it's not introduced by #98803

@jamesdeanexpensify

Copy link
Copy Markdown
Contributor

@jponikarchuk @mitarachim sorry, not an engineer, but can I help somehow?

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.56-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants