Repository navigation
fix: open the sign in RHP for anonymous users in the Home Concierge prompt box - #99552
Conversation
41eab7c to
b404f97
Compare
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2026-08-26.13.38.13.movAndroid: mWeb Chrome2026-08-26.13.38.13.moviOS: HybridApp2026-08-26.13.38.13.moviOS: mWeb Safari2026-08-26.13.38.13.movMacOS: Chrome / Safari2026-08-26.13.36.50.mov |
|
🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
…x/99492-anonymous-concierge-prompt-login fix: open the sign in RHP for anonymous users in the Home Concierge prompt box (cherry picked from commit 61962cd) (cherry-picked to staging by puneetlath)
|
🔁 Filed a Staging retest request for deploy blockers #99492 after this PR was cherry-picked to staging. |
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.61-4 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under Why: This is a scoped, internal behavior fix. Anonymous (signed-out) users interacting with the Home Concierge prompt box (send, Enter, or "+") are now routed through The help site documents features and how to use them for signed-in users. The closest article, Expensify Home Overview, describes Home as "the starting point you see when you sign in" and does not document anonymous-user prompt-box behavior, so there is nothing to add or correct. No draft PR was created since there are no documentation updates to make. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀
Bundle Size Analysis (Sentry): |
|
🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.62-1 🚀
|
|
🤖 I reviewed the changes in this PR against Expensify's help site files under Why: This is a scoped, internal behavior fix. Anonymous (signed-out) users interacting with the Home Concierge prompt box (send, Enter, or "+") are now routed through The help site documents features and how to use them for signed-in users. The closest article, Expensify Home Overview, describes Home as "the starting point you see when you sign in" and does not document anonymous-user prompt-box behavior, so there is nothing to add or correct. No draft PR was created since there are no documentation updates to make. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.62-4 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
The Concierge prompt box on the Home page was fully usable while signed out, so an anonymous user could send a message straight to the Concierge report and open the attachment flow. Both entry points now go through
interceptAnonymousUser, which is what the rest of the app uses to send an anonymous user to sign in.In the app
In the code
ConciergePromptBoxwraps the submit handler and the "+" press handler ininterceptAnonymousUser(src/libs/interceptAnonymousUser.ts), the helper already used by the FAB, the floating camera button and the search suggestions.useAskConcierge, so the attachment path is cut off at the button instead of at the API call.tests/ui/ConciergePromptBoxTest.tsxcovers all three anonymous paths (send button, Enter, "+") with the realinterceptAnonymousUserover a mocked@userActions/Session.Out of scope
SearchRoutercallsaskConciergewithout the same guard. It is left alone here to keep the fix scoped to the box reported in the issue. An anonymous user cannot reach that item anyway:TopBarhides the search button for them, the search tab button already runsinterceptAnonymousUser, the Ctrl+K shortcut goes throughcallFunctionIfActionIsAllowed, and the search route is not incanAnonymousUserAccessRoute.askConciergeWithAttachmentis guarded through the "+" button rather than at the call itself. That covers every path that exists today: the Composer in this box does not passonPasteFile, and the page wide drop zone on Home is receipt scan only and already anonymous gated.Fixed Issues
$ #99492
PROPOSAL: N/A - internal regression fix, follows the maintainer guidance in the issue.
Tests
Offline tests
N/A - the guard is a local check on the session and runs before any request, so there is no new network or Onyx behavior to test offline.
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android-native.mp4
iOS: Native
ios-native-trimed.mp4
MacOS: Chrome / Safari
web-chrome.mp4