Skip to content

fix: open the sign in RHP for anonymous users in the Home Concierge prompt box - #99552

Merged
puneetlath merged 1 commit into
Expensify:mainfrom
software-mansion-labs:dariusz-biela/fix/99492-anonymous-concierge-prompt-login
Aug 26, 2026
Merged

puneetlath merged 1 commit into
Expensify:mainfrom
software-mansion-labs:dariusz-biela/fix/99492-anonymous-concierge-prompt-login

Conversation

@dariusz-biela

@dariusz-biela dariusz-biela commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Explanation of Change

The Concierge prompt box on the Home page was fully usable while signed out, so an anonymous user could send a message straight to the Concierge report and open the attachment flow. Both entry points now go through interceptAnonymousUser, which is what the rest of the app uses to send an anonymous user to sign in.

In the app

  • Sending a message from the Home Concierge prompt box (Enter or the send button) as an anonymous user opens the sign in RHP instead of posting the message and failing with "Unexpected error posting the comment".
  • The typed message stays in the box while the sign in RHP is open, so nothing is lost.
  • Pressing "+" as an anonymous user opens the sign in RHP instead of the "Add attachment" menu, which also blocks the attachment picker and the preview behind it.
  • Nothing changes for a signed in user.

In the code

  • ConciergePromptBox wraps the submit handler and the "+" press handler in interceptAnonymousUser (src/libs/interceptAnonymousUser.ts), the helper already used by the FAB, the floating camera button and the search suggestions.
  • The guard sits in the component rather than in useAskConcierge, so the attachment path is cut off at the button instead of at the API call.
  • tests/ui/ConciergePromptBoxTest.tsx covers all three anonymous paths (send button, Enter, "+") with the real interceptAnonymousUser over a mocked @userActions/Session.

Out of scope

  • SearchRouter calls askConcierge without the same guard. It is left alone here to keep the fix scoped to the box reported in the issue. An anonymous user cannot reach that item anyway: TopBar hides the search button for them, the search tab button already runs interceptAnonymousUser, the Ctrl+K shortcut goes through callFunctionIfActionIsAllowed, and the search route is not in canAnonymousUserAccessRoute.
  • askConciergeWithAttachment is guarded through the "+" button rather than at the call itself. That covers every path that exists today: the Composer in this box does not pass onPasteFile, and the page wide drop zone on Home is receipt scan only and already anonymous gated.

Fixed Issues

$ #99492
PROPOSAL: N/A - internal regression fix, follows the maintainer guidance in the issue.

Tests

  1. Sign out of New Expensify.
  2. Open the public room https://staging.new.expensify.com/r/4009163200148429 so an anonymous session is created, then go to Home with the tab bar (do not reload the URL, a full load of /home opens the sign in RHP on its own).
  3. Type a message in the Concierge prompt box and press Enter, then repeat with the send button. Verify that the sign in RHP opens each time, the message is not sent, the typed text stays in the box and no "Unexpected error posting the comment" appears.
  4. Close the sign in RHP and press "+". Verify that the sign in RHP opens and the "Add attachment" menu does not.
  5. Sign in with a real account and go to Home. Verify that the prompt box still sends messages to Concierge, and that "+" > "Add attachment" opens the picker and the attachment preview as before.
  • Verify that no errors appear in the JS console

Offline tests

N/A - the guard is a local check on the session and runs before any request, so there is no new network or Onyx behavior to test offline.

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native.mp4
iOS: Native
ios-native-trimed.mp4
MacOS: Chrome / Safari
web-chrome.mp4

@dariusz-biela
dariusz-biela force-pushed the dariusz-biela/fix/99492-anonymous-concierge-prompt-login branch from 41eab7c to b404f97 Compare August 26, 2026 11:13

@mhawryluk mhawryluk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dariusz-biela
dariusz-biela marked this pull request as ready for review August 26, 2026 11:17
@dariusz-biela
dariusz-biela requested review from a team as code owners August 26, 2026 11:17
@melvin-bot
melvin-bot Bot requested review from ZhenjaHorbach and flaviadefaria and removed request for a team August 26, 2026 11:18
@melvin-bot

melvin-bot Bot commented Aug 26, 2026

Copy link
Copy Markdown

@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 26, 2026 11:18
@ZhenjaHorbach

ZhenjaHorbach commented Aug 26, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
2026-08-26.13.38.13.mov
Android: mWeb Chrome
2026-08-26.13.38.13.mov
iOS: HybridApp
2026-08-26.13.38.13.mov
iOS: mWeb Safari
2026-08-26.13.38.13.mov
MacOS: Chrome / Safari
2026-08-26.13.36.50.mov

@puneetlath
puneetlath merged commit 61962cd into Expensify:main Aug 26, 2026
40 of 44 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 puneetlath has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Aug 26, 2026
…x/99492-anonymous-concierge-prompt-login

fix: open the sign in RHP for anonymous users in the Home Concierge prompt box
(cherry picked from commit 61962cd)

(cherry-picked to staging by puneetlath)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Aug 26, 2026
@OSBotify OSBotify mentioned this pull request Aug 26, 2026
63 tasks done
@os-botify

os-botify Bot commented Aug 26, 2026

Copy link
Copy Markdown

🔁 Filed a Staging retest request for deploy blockers #99492 after this PR was cherry-picked to staging.

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against Expensify's help site files under App/docs/articles and no help site changes are required.

Why: This is a scoped, internal behavior fix. Anonymous (signed-out) users interacting with the Home Concierge prompt box (send, Enter, or "+") are now routed through interceptAnonymousUser to the sign-in RHP instead of failing with "Unexpected error posting the comment." It introduces no new user-facing feature, setting, tab, label, or flow — it just makes the signed-out edge case behave the way the rest of the app already does (send anonymous users to sign in).

The help site documents features and how to use them for signed-in users. The closest article, Expensify Home Overview, describes Home as "the starting point you see when you sign in" and does not document anonymous-user prompt-box behavior, so there is nothing to add or correct.

No draft PR was created since there are no documentation updates to make.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.61-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.4.62-1 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against Expensify's help site files under App/docs/articles and no help site changes are required.

Why: This is a scoped, internal behavior fix. Anonymous (signed-out) users interacting with the Home Concierge prompt box (send, Enter, or "+") are now routed through interceptAnonymousUser to the sign-in RHP instead of failing with "Unexpected error posting the comment." It introduces no new user-facing feature, setting, tab, label, or flow — it just makes the signed-out edge case behave the way the rest of the app already does (send anonymous users to sign in).

The help site documents features and how to use them for signed-in users. The closest article, Expensify Home Overview, describes Home as "the starting point you see when you sign in" and does not document anonymous-user prompt-box behavior, so there is nothing to add or correct.

No draft PR was created since there are no documentation updates to make.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.62-4 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants